fix component destroy leak

[sherlock1982]

fixes #6499 #5999

[codecov]

Codecov Report

Merging #6522 (e39ca03) into development (663c70e) will decrease coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

@@               Coverage Diff               @@
##           development    #6522      +/-   ##
===============================================
- Coverage        76.98%   76.97%   -0.01%     
===============================================
  Files              315      315              
  Lines            10701    10701              
  Branches          2988     2988              
===============================================
- Hits              8238     8237       -1     
- Misses            2461     2462       +1     
  Partials             2        2              

Impacted Files	Coverage Δ
...hemes/bs/bs-daterangepicker-container.component.ts	71.72% <0.00%> (-2.76%)	⬇️
src/chronos/i18n/sk.ts	85.00% <0.00%> (-2.50%)	⬇️
src/chronos/i18n/cs.ts	87.36% <0.00%> (-2.11%)	⬇️
...ker/themes/bs/bs-datepicker-container.component.ts	85.14% <0.00%> (-1.99%)	⬇️
src/chronos/i18n/pl.ts	85.24% <0.00%> (ø)
src/chronos/i18n/uk.ts	90.62% <0.00%> (+3.12%)	⬆️
src/modal/modal-container.component.ts	53.84% <0.00%> (+8.97%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 663c70e...e39ca03. Read the comment docs.

[cypress]

---

Test summary

803 • 35 • 14 • 0

---

Run details

Project	ngx-bootstrap
Status	Failed
Commit	362cecd ℹ️
Started	Jan 5, 2023 7:41 AM
Ended	Jan 5, 2023 8:17 AM
Duration	36:06 💡
OS	Linux Ubuntu - 22.04
Browser	Electron 100

View run in Cypress Dashboard ➡️

---

Failures

	datepicker/locales_spec.ts		2
1	Datepicker demo testing suite: Locales > Change Locale Datepicker > when user chose locale es-pr for "Datepicker", container shown in appropriate language
2	Datepicker demo testing suite: Locales > Change Locale DateRangepicker > when user chose locale es-pr for "Daterangepicker", container shown in this language
	modals_service_page_spec.ts		8
1	Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Close" button, triggers the interceptor and doesn't close the modal
2	Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "Yes" button, closes the modal
3	Modals demo page testing suite: Service examples > Component modals with interceptor > when user clicks on "No" button, doesn't close the modal
4	Modals demo page testing suite: Service examples > Nested modals > when user clicks on the button "Open second modal" then the second modal with title "Second modal" is opened, "Close self" is present
5	Modals demo page testing suite: Service examples > Events > when user closes modal by click on the cross then should be messages "onHide event has been fired" and "onHidden event has been fired"
6	Modals demo page testing suite: Service examples > Events > when user closes modal by pressing ESC button then modal is closed and should be messages "onHide event has been fired" and "onHidden event has been fired"
7	Modals demo page testing suite: Service examples > Confirm Window > when user clicks on "Open modal" button then modal is opened, it contains two buttons: "Yes" and "No"
8	Modals demo page testing suite: Service examples > Custom css class > when user clicks on the cross button then the modal is closed
This comment includes only the first 10 test failures. See all 35 failures in the Cypress Dashboard.

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[Alexveselun]

Testing completed. Locally work correctly. No critical issues were found.

[sherlock1982]

Are these failures caused by my changes or it's just something random? I checked one of the tests and it looks like it's just stuck in the middle.

[SvetlanaMuravlova]

Are these failures caused by my changes or it's just something random? I checked one of the tests and it looks like it's just stuck in the middle.

failures in full e2e tests don't connect with your changes, not all tests are fixed, for some reasons

[valorkin]

I would go with this._componentRef?.destroy()

[lexasq]

Was merged another PR with the same code