Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix component destroy leak #6522

Closed
wants to merge 6 commits into from
Closed

fix component destroy leak #6522

Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e102783
fix component destroy leak
Nov 16, 2022
09a22f7
Merge branch 'development' into fix-component-hide-leak
sherlock1982 Dec 19, 2022
dde3d55
Merge branch 'development' into fix-component-hide-leak
SvetlanaMuravlova Jan 3, 2023
e39ca03
Merge branch 'development' into fix-component-hide-leak
SvetlanaMuravlova Jan 5, 2023
03d5021
Merge branch 'development' into fix-component-hide-leak
lexasq Jul 4, 2024
59892af
Merge branch 'development' into fix-component-hide-leak
lexasq Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/component-loader/component-loader.class.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,7 @@ export class ComponentLoader<T extends object> {
this._contentRef?.viewRef?.destroy();

this._contentRef = void 0;
this._componentRef.destroy();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would go with this._componentRef?.destroy()

this._componentRef = void 0;
this._removeGlobalListener();

Expand Down