refactor: Centralize Vega
project versioning
#3720
Open
+344
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR seeks to simplify version bumps of projects we depend on within the https://github.com/vega org.
The new process I'm proposing is documented in https://github.com/vega/altair/blob/5aec51ef8eaf345936436abddd903ea87b86b968/NOTES_FOR_MAINTAINERS.md.
In short, we bump versions in
pyproject.toml
and they propagate to everywhere they were previously manually maintained:altair/pyproject.toml
Lines 103 to 110 in 5aec51e
The new module https://github.com/vega/altair/blob/5aec51ef8eaf345936436abddd903ea87b86b968/tools/versioning.py handles said propagation.
Motivation
Vega-Lite
I think it was unintentional, but we missed a
vega-lite
bump in https://github.com/vega/altair/releases/tag/v5.5.0.We're still on https://github.com/vega/vega-lite/releases/tag/v5.20.1 but we should be on https://github.com/vega/vega-lite/releases/tag/v5.21.0 and now the latest is https://github.com/vega/vega-lite/releases/tag/v5.23.0
Additionally, these appear to be out-of-sync?
vl-convert
altair/pyproject.toml
Lines 56 to 58 in 1208c5d
altair/altair/utils/_importers.py
Lines 47 to 48 in 1208c5d
VegaFusion
altair/pyproject.toml
Line 66 in 1208c5d
altair/altair/utils/_importers.py
Lines 12 to 13 in 1208c5d
Future
I'm planning to pin
vega-datasets
for (#3631).There are also likely to be a lot of version changes coming up as a result of (vega/vega#3990).
IMO having a single, highly visible place to update will make this process hopefully painless for us
Tasks
tomllib
whensys.version_info < (3, 11)
RELEASING.md
(dc0215c)NOTES_FOR_MAINTAINERS.md