-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Centralize Vega
project versioning
#3720
Open
dangotbanned
wants to merge
12
commits into
main
Choose a base branch
from
vega-versioning
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+344
−57
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
37af611
refactor: Centralize `vega` project versioning
dangotbanned dd0980b
fix: add `tomllib/tomli` compat layer
dangotbanned eb3b9b0
fix: format `schemapi.py` on all platforms
dangotbanned 0e23fd3
fix: format after closing file
dangotbanned 537a5da
docs: Fill out `versioning` docs
dangotbanned c45f1c4
docs(DRAFT): Update `NOTES_FOR_MAINTAINERS.md`
dangotbanned dc0215c
docs: Add version check step to `RELEASING.md`
dangotbanned 5aec51e
refactor: Rewrite `versioning` around an class
dangotbanned ac689dd
revert: remove VegaFusion section
dangotbanned cd7c30b
Merge remote-tracking branch 'upstream/main' into vega-versioning
dangotbanned 041eb0d
Merge branch 'main' into vega-versioning
dangotbanned d49f0ff
Merge branch 'main' into vega-versioning
dangotbanned File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonmmease
I mentioned this in the PR description, but would you be able to clarify these for me?
Do we want the runtime version bound checks to match the lower bounds of
[project.optional-dependencies]
?VegaFusion
altair/pyproject.toml
Line 66 in 48e976e
altair/altair/utils/_importers.py
Lines 12 to 13 in 1208c5d
vl-convert
altair/pyproject.toml
Lines 56 to 58 in 1208c5d
altair/altair/utils/_importers.py
Lines 47 to 48 in 1208c5d
If so, I could avoid declaring
vegafusion
,vl-convert-python
a second time here.Instead, parsing them directly from
[project.optional-dependencies]
with https://packaging.pypa.io/en/stable/requirements.html