Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gen4 Planner: support aggregate UDFs #15710

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Conversation

systay
Copy link
Collaborator

@systay systay commented Apr 15, 2024

Description

The schema tracker can now tell us which aggregate UDFs exist on the underlying MySQL, and with this PR the planner will now use this information when planning queries.

It changes how the column binding is done in the HAVING and ORDER BY clause in a subtle but important way.

Vtgate can only handle these functions when it's possible to entirely push down the aggregation to mysql.

At the moment there is no support for actually installing the UDFs on MySQL - for now this exercise is left to the user.

Related Issue(s)

#15705

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

Copy link
Contributor

vitess-bot bot commented Apr 15, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Apr 15, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone Apr 15, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
@systay systay added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Query Serving and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Apr 15, 2024
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 93.28358% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.40%. Comparing base (f118ba2) to head (8162d43).
Report is 9 commits behind head on main.

Files Patch % Lines
...vt/vtgate/planbuilder/operators/queryprojection.go 86.66% 4 Missing ⚠️
go/vt/vtgate/vindexes/vschema.go 86.66% 2 Missing ⚠️
go/vt/vtgate/planbuilder/operators/aggregator.go 83.33% 1 Missing ⚠️
go/vt/vtgate/planbuilder/operators/hash_join.go 50.00% 1 Missing ⚠️
go/vt/wrangler/vexec_plan.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15710      +/-   ##
==========================================
- Coverage   68.40%   68.40%   -0.01%     
==========================================
  Files        1556     1556              
  Lines      195121   195393     +272     
==========================================
+ Hits       133479   133650     +171     
- Misses      61642    61743     +101     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

go/vt/vterrors/code.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/operators/offset_planning.go Outdated Show resolved Hide resolved
go/vt/vtgate/planbuilder/plan_test.go Show resolved Hide resolved
Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Member

@harshit-gangal harshit-gangal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall

Signed-off-by: Andres Taylor <andres@planetscale.com>
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@systay systay merged commit a63f9c9 into vitessio:main Apr 17, 2024
101 checks passed
@systay systay deleted the udf-planner branch April 17, 2024 10:58
systay added a commit that referenced this pull request Jul 22, 2024
* cherry pick of 15710

* Empty commit to trigger CI

Signed-off-by: Andres Taylor <andres@planetscale.com>

* implement interface

Signed-off-by: Andres Taylor <andres@planetscale.com>

---------

Signed-off-by: Andres Taylor <andres@planetscale.com>
Co-authored-by: Andres Taylor <andres@planetscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Query Serving Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants