Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert GRPC context changes #15780

Merged

Revert GRPC context changes

4736a0e
Select commit
Loading
Failed to load commit list.
Merged

Revert GRPC context changes #15780

Revert GRPC context changes
4736a0e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 23, 2024 in 1s

68.41% (-0.03%) compared to a89b2cb

View this Pull Request on Codecov

68.41% (-0.03%) compared to a89b2cb

Details

Codecov Report

Attention: Patch coverage is 84.61538% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 68.41%. Comparing base (a89b2cb) to head (4736a0e).
Report is 1 commits behind head on main.

Files Patch % Lines
go/vt/vtgate/grpcvtgateconn/conn.go 66.66% 2 Missing ⚠️
go/vt/vtgate/fakerpcvtgateconn/conn.go 0.00% 1 Missing ⚠️
go/vtbench/client.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15780      +/-   ##
==========================================
- Coverage   68.43%   68.41%   -0.03%     
==========================================
  Files        1556     1556              
  Lines      195433   195437       +4     
==========================================
- Hits       133743   133700      -43     
- Misses      61690    61737      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.