-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use replica queries when available #15808
Use replica queries when available #15808
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
Not all end-to-end tests here have been updated yet either, that's still pending to change to use the new syntax when available as well. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15808 +/- ##
==========================================
- Coverage 68.41% 68.39% -0.03%
==========================================
Files 1558 1558
Lines 196353 196547 +194
==========================================
+ Hits 134337 134422 +85
- Misses 62016 62125 +109 ☔ View full report in Codecov by Sentry. |
0449d9b
to
e7a61bb
Compare
b4579a8
to
21ac30d
Compare
This switches things over to use the replica syntax when available instead of the deprecated style. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
a5aca74
to
dffc19e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I only had minor nits/comments/suggestions.
Thank you for doing this!
Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
This switches things over to use the replica syntax when available instead of the deprecated style.
Related Issue(s)
Part of #9515. The new naming is not available for all of MySQL 8.0, so we have to carry the legacy still but we can use the new syntax moving forward where possible.
Checklist