Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vitess.io/vitess from 0.16.2 to 0.17.7 in /vitess-mixin #15918

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github May 10, 2024

Bumps vitess.io/vitess from 0.16.2 to 0.17.7.

Commits
  • 7c0245d [release-17.0] Release of v17.0.7 (#15884)
  • c46dc5b Merge pull request from GHSA-649x-hxfx-57j2
  • 3d8f63e [release-17.0] Code Freeze for v17.0.7 (#15878)
  • cf04a70 [release-17.0] Fix wrong assignment to sql_id_opt in the parser (#15862) (#...
  • efb6984 [release-17.0] Upgrade the Golang version to go1.21.10 (#15863)
  • 00f1673 [release-17.0] Improve performance for BaseShowTablesWithSizes query. (#157...
  • 04c483d [release-17.0] VReplication: Take replication lag into account in VStreamMana...
  • 8e98775 [release-17.0] Fix ZooKeeper Topology connection locks not being cleaned up c...
  • 8aea612 [release-17.0] [VTAdmin API] Fix schema cache flag, add documentation (#15704...
  • c7bc1ce [release-17.0] Fix aliasing in routes that have a derived table (#15550) (#15...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [vitess.io/vitess](https://github.com/vitessio/vitess) from 0.16.2 to 0.17.7.
- [Release notes](https://github.com/vitessio/vitess/releases)
- [Commits](v0.16.2...v0.17.7)

---
updated-dependencies:
- dependency-name: vitess.io/vitess
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from ajm188 as a code owner May 10, 2024 21:40
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label May 10, 2024
@dependabot dependabot bot requested a review from deepthi as a code owner May 10, 2024 21:40
@dependabot dependabot bot added the go label May 10, 2024
Copy link
Contributor

vitess-bot bot commented May 10, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 10, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 10, 2024
@frouioui frouioui added Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Dependencies Dependency updates and removed dependencies Pull requests that update a dependency file NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 14, 2024
Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how maintained vitess-mixin really is. I think it is probably fine to get that merged, but ideally we should go through this project to check if it makes sense still.

@frouioui frouioui merged commit 702f6af into main May 14, 2024
187 of 194 checks passed
@frouioui frouioui deleted the dependabot/go_modules/vitess-mixin/vitess.io/vitess-0.17.7 branch May 14, 2024 15:29
@systay systay mentioned this pull request May 20, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring go Type: Dependencies Dependency updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants