vtgateproxy include hostname in debug page #15949
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
* docs: added to the release notes Signed-off-by: Andres Taylor <andres@planetscale.com> * Add name to static check workflow Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
…vitessio#10471) (vitessio#10474) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rohit Nayak <rohit@planetscale.com>
Signed-off-by: Andrew Mason <andrew@planetscale.com>
…0453) (vitessio#10466) * fix: change planner_version to planner-version everywhere Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: actually change the planner version on vtgate after checking Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move CheckPlannerVersionFlag out from vtgate Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move the global plannerVersion to be a field on the executor. think global, act local, yo Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: use the planner in the session first Signed-off-by: Andres Taylor <andres@planetscale.com> * test: use DEFAULT instead of 0 Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: re-add the planner-version flag to vtcombo Signed-off-by: Andres Taylor <andres@planetscale.com>
* Add PingTablet to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for PingTablet Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RefreshState Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RefreshTabletReplicationSource Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add RunHealthCheck to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RunHealthCheck Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for SetReadOnly Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for SetReadWrite Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for StartReplication Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for StopReplication Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for TabletExternallyPromoted Signed-off-by: Andrew Mason <andrew@planetscale.com>
* add sharding column name/type deprecation to release notes summary Signed-off-by: deepthi <deepthi@planetscale.com> * deprecation: mark sharding-column-name and sharding-column-type for CreateKeyspace command as deprecated Signed-off-by: deepthi <deepthi@planetscale.com>
* [vtadmin] Add authz tests for remaining non-schema related actions (vitessio#10481) * Add authz tests for EmergencyFailoverShard Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for PlannedFailoverShard Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateSchemaKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateSchemaKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateVersionKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateVersionKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * fixup mock data sorting Signed-off-by: Andrew Mason <andrew@planetscale.com> * [vtadmin] Add schema-related authz tests (vitessio#10486) * Update template to support more tablet fields Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update template, add full srvvschema payload, add schema payload, add authz tests for VTExplain Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for GetSchema Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for GetSchemas Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for FindSchema Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ReloadSchemas Signed-off-by: Andrew Mason <andrew@planetscale.com>
…io#10502) (vitessio#10509) * Update docs for backup commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for cell commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for keyspace commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for legacy-shim command Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs, add aliases for reparent commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for root command Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for routing rule commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for schema commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for serving graph commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for shard commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for tablet commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for vschema commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for workflow commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Remove references to deprecated flags Signed-off-by: Andrew Mason <andrew@planetscale.com> * fixup! Update docs for keyspace commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Remove reparent command aliases Signed-off-by: Andrew Mason <andrew@planetscale.com> * Specify that `--server` is required Signed-off-by: Andrew Mason <andrew@planetscale.com>
… and move it to places which will only be called less frequently (vitessio#10516) (vitessio#10518) Signed-off-by: Manan Gupta <manan@planetscale.com>
… and vitessio#10514 (vitessio#10517) * Fix parsing of CAST() statements (vitessio#10512) * Fix parsing of CAST() statements CAST() was treated as an alias for CONVERT() but with slightly different syntax. This is also described in the documentation at https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html, specifically: With CAST(expr AS type syntax, the CAST() function takes an expression of any type and produces a result value of the specified type. This operation may also be expressed as CONVERT(expr, type), which is equivalent. If expr is NULL, CAST() returns NULL. This is wrong sadly. CAST() is not equivalent to CONVERT(), specifically in the context of a CREATE TABLE. For JSON keys, the ARRAY attribute is possible on a CAST(), but that is not accepted for a CONVERT(). The difference in parsing also shows in MySQL: ``` mysql> select convert(json_keys(c), char(64) array) from t; ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'array) from t' at line 1 mysql> select cast(json_keys(c) as char(64) array) from t; ERROR 1235 (42000): This version of MySQL doesn't yet support 'Use of CAST( .. AS .. ARRAY) outside of functional index in CREATE(non-SELECT)/ALTER TABLE or in general expressions' ``` Here the first statement can't be parsed at all. The second is properly parsed, but ARRAY is not allowed in the context of CAST() in this situation (and only in a CREATE TABLE). This means we should really treat these as two separate expressions and don't store them both in the same structure. The change here creates a separate CAST structure, removes the ARRAY option from CONVERT and updates the grammar and all tests accordingly. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Handle new cast expression in evalengine and planbuilder Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * evalengine: do not duplicate CAST/CONVERT translation Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> * Add back unary single column expression check (vitessio#10514) This was accidentally removed in vitessio#10512 but it shouldn't have been. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Vicent Marti <vmg@strn.cat>
…0538) (vitessio#10540) Signed-off-by: Andrew Mason <andrew@planetscale.com>
…#10508) (vitessio#10528) * addition of the release_notes_label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of a helper step in the release_notes_label to guide users Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of a set of rules for release_notes_labels's pull_request target Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove the previous workflow that used to check the release notes labels Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Change the review check list and enforce the use of type/component labels Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed syntax in check release notes label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…o#10484) Signed-off-by: Andrew Mason <andrew@planetscale.com>
…#10532) * generate the release changelog as a second document Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * include every PR in the release notes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Moved changelog metrics away from the changelog and added summary for v15 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…0553) * test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: handle empty row for scalar aggregation and also olap engine for scalar aggregation Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: update plan test output Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: e2e test for empty rows in non-scalar aggregates Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>
* docs: add blurb about gen4 being the new planner Signed-off-by: Andres Taylor <andres@planetscale.com> * docs: release notes Signed-off-by: Andres Taylor <andres@planetscale.com>
…tessio#10480) (vitessio#10554) Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…itessio#10464) (vitessio#10546) * Adds RPCs to vttablet that vtorc requires (vitessio#10464) * feat: add vttablet rpc to reset replication parameters Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: added end to end testing for the rpc and fixed bug Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix typing error Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add basic full status rpc functionality and add test for it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add all the fields needed in full status Signed-off-by: Manan Gupta <manan@planetscale.com> * test: moved the test to reparent tests and improved it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: bug fix for no replication status and no primary status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add version to the full status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add binlog information to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: fix the comment explaining the binlog information Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add semi-sync statuses to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: call the correct command Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add server uuid and id to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: make server_id a uint32 to accept the correct range of values Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add few more fields to the full status like version comment, semi-sync settings, binlog_row_image Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: generate vtadmin proto files Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add assertion to check binlog row format is read correctly Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: split GTID mode in its own function because mariadb doesn't support it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix parsing of empty mariadb gtid set Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add doucmentation for existing fields in ReplicationStatus Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add relay log file position to the replication status output Signed-off-by: Manan Gupta <manan@planetscale.com> * test: augmented full status test to check all the different positions stored Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add additional fields to replication status and read source user Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read sql delay from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read ssl allowed from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read has replication filters from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read auto position and using gtid from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add replication lag unknown too to replication status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return nils from replication and primary postiion if it is not present Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: rename FileRelayLogPosition in replication status output to RelayLogSourceBinLogEquivalentPosition and augment test to make sure rpc changes are backward compatible Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update vtadmin proto files Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: rename BinLog to binlog in renamed proto field Signed-off-by: Manan Gupta <manan@planetscale.com> * lint: add a new line to proto file Signed-off-by: Manan Gupta <manan@planetscale.com>
…io#10562) * VReplication: more unrecoverable error codes Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * correct path for test files Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>
* test: reproduce the panic as a unit test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: check ev is not nil before using its fields Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: increase timeout of LockShard and wait replicas in VTOrc default config Signed-off-by: Manan Gupta <manan@planetscale.com>
…#10535) (vitessio#10570) The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>
…sist and unrecoverable errors (vitessio#10573) * Fail VReplication workflows on errors that persist and unrecoverable errors (vitessio#10429) * Fail workflow if same error persists too long. Fail for unrecoverable errors also in non-online ddl workflows Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Update max time default to 15m, was 1m for testing purposes Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Leverage vterrors for Equals; attempt to address my own nits Signed-off-by: Matt Lord <mattalord@gmail.com> * sanity: validate range of vreplication_retry_delay and of vreplication_max_time_to_retry_on_error Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Fix flags test Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Remove leftover log.Flush() Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Revert validations min/max settings on retry delay since it is breaking unit tests that set the value to a very small value Signed-off-by: Rohit Nayak <rohit@planetscale.com> * captilize per request Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fix TestHelpOutput Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * spaces, not tabs Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Rohit Nayak <57520317+rohit-nayak-ps@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
…sts (vitessio#10522) * Take into account `github.ref` when doing upgrade-downgrade tests (vitessio#10504) * Take into account the github.ref variable when doing upgrade-downgrade tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed upgrade-downgrade workflows' syntax to use 'previous' instead of 'latest' Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed syntax error in backup upgrade downgrade workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed static_checks_etc workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…hannel might block the vstream thread if target channel goes away: context was not being checked then. Fix health stream goroutine leak. (vitessio#10576) Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* add-vtadmin-docker-image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * env as function, update tests and code Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * feat: fix remaining env usages to be function calls Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin build result in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin web cleaning Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin docker image entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add the possibility to custom vtadmin web port in Docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin docker port Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * set default vtadmin docker user as vitess Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * do not build vtadmin frontend in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * build vtadmin frontend only in vtadmin docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * vtadmin replace sed and custom entrypoint with config.js file Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * remove vitess web files in lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * move vtadmin config into a specific directory Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * restore vtadmin web file in mysql57 lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Léopold Jacquot <leopold.jacquot@gmail.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
* CherryPick: VDiff2: Support Resuming VDiffs (vitessio#10497) And fix a number of bugs discovered related to incorrect VDiff summary handling and other more minor things. Signed-off-by: Matt Lord <mattalord@gmail.com>
* refactor a bit more to consolidate the command line flags * rework again to have a single parser and move around all the logic This way we only have a single entity watching the file and dispatching out to the resolvers when things change rather than a bunch of tickers watching the file. Also cleaned up the code a bunch. * redo the shuffle to be a single pass * actually use the builder rand not the global one * add some metrics * only stat once per second * split out counter for unknown affinity
* reinitalise targets when parsing host list * remove metrics and logging changes
* move organization of target hosts to parse time * rework metrics and logging of parse errors * add discovery bits to debug status page * reset parseErr in the right place * add sync and change debug page to do the shuffle * unrelated but just move some code around --------- Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>
demmer
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188 and
notfelineit
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
demmer
requested review from
frouioui,
rohit-nayak-ps,
GuptaManan100,
shlomi-noach,
systay,
arthurschreiber and
derekperkins
as code owners
vitess-bot
bot
added
NeedsBackportReason
|
Whoops... This was intended for Slack's internal fork only. Sorry for the bother. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Minor improvement to the debug page to include the hostname for easier ... debugging.
Related Issue(s)
Checklist
Deployment Notes