vtgateproxy include hostname in debug page #15949

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* docs: added to the release notes Signed-off-by: Andres Taylor <andres@planetscale.com> * Add name to static check workflow Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

…vitessio#10471) (vitessio#10474) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rohit Nayak <rohit@planetscale.com>

Signed-off-by: Andrew Mason <andrew@planetscale.com>

…0453) (vitessio#10466) * fix: change planner_version to planner-version everywhere Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: actually change the planner version on vtgate after checking Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move CheckPlannerVersionFlag out from vtgate Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: move the global plannerVersion to be a field on the executor. think global, act local, yo Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: use the planner in the session first Signed-off-by: Andres Taylor <andres@planetscale.com> * test: use DEFAULT instead of 0 Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: re-add the planner-version flag to vtcombo Signed-off-by: Andres Taylor <andres@planetscale.com>

* Add PingTablet to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for PingTablet Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RefreshState Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RefreshTabletReplicationSource Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add RunHealthCheck to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for RunHealthCheck Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for SetReadOnly Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for SetReadWrite Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for StartReplication Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for StopReplication Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for TabletExternallyPromoted Signed-off-by: Andrew Mason <andrew@planetscale.com>

* add sharding column name/type deprecation to release notes summary Signed-off-by: deepthi <deepthi@planetscale.com> * deprecation: mark sharding-column-name and sharding-column-type for CreateKeyspace command as deprecated Signed-off-by: deepthi <deepthi@planetscale.com>

* [vtadmin] Add authz tests for remaining non-schema related actions (vitessio#10481) * Add authz tests for EmergencyFailoverShard Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for PlannedFailoverShard Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateSchemaKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateSchemaKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add ValidateVersionKeyspace to mock vtctld Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ValidateVersionKeyspace Signed-off-by: Andrew Mason <andrew@planetscale.com> * fixup mock data sorting Signed-off-by: Andrew Mason <andrew@planetscale.com> * [vtadmin] Add schema-related authz tests (vitessio#10486) * Update template to support more tablet fields Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update template, add full srvvschema payload, add schema payload, add authz tests for VTExplain Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for GetSchema Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for GetSchemas Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for FindSchema Signed-off-by: Andrew Mason <andrew@planetscale.com> * Add authz tests for ReloadSchemas Signed-off-by: Andrew Mason <andrew@planetscale.com>

…io#10502) (vitessio#10509) * Update docs for backup commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for cell commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for keyspace commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for legacy-shim command Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs, add aliases for reparent commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for root command Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for routing rule commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for schema commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for serving graph commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for shard commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for tablet commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for vschema commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Update docs for workflow commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Remove references to deprecated flags Signed-off-by: Andrew Mason <andrew@planetscale.com> * fixup! Update docs for keyspace commands Signed-off-by: Andrew Mason <andrew@planetscale.com> * Remove reparent command aliases Signed-off-by: Andrew Mason <andrew@planetscale.com> * Specify that `--server` is required Signed-off-by: Andrew Mason <andrew@planetscale.com>

… and move it to places which will only be called less frequently (vitessio#10516) (vitessio#10518) Signed-off-by: Manan Gupta <manan@planetscale.com>

… and vitessio#10514 (vitessio#10517) * Fix parsing of CAST() statements (vitessio#10512) * Fix parsing of CAST() statements CAST() was treated as an alias for CONVERT() but with slightly different syntax. This is also described in the documentation at https://dev.mysql.com/doc/refman/8.0/en/cast-functions.html, specifically: With CAST(expr AS type syntax, the CAST() function takes an expression of any type and produces a result value of the specified type. This operation may also be expressed as CONVERT(expr, type), which is equivalent. If expr is NULL, CAST() returns NULL. This is wrong sadly. CAST() is not equivalent to CONVERT(), specifically in the context of a CREATE TABLE. For JSON keys, the ARRAY attribute is possible on a CAST(), but that is not accepted for a CONVERT(). The difference in parsing also shows in MySQL: ``` mysql> select convert(json_keys(c), char(64) array) from t; ERROR 1064 (42000): You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'array) from t' at line 1 mysql> select cast(json_keys(c) as char(64) array) from t; ERROR 1235 (42000): This version of MySQL doesn't yet support 'Use of CAST( .. AS .. ARRAY) outside of functional index in CREATE(non-SELECT)/ALTER TABLE or in general expressions' ``` Here the first statement can't be parsed at all. The second is properly parsed, but ARRAY is not allowed in the context of CAST() in this situation (and only in a CREATE TABLE). This means we should really treat these as two separate expressions and don't store them both in the same structure. The change here creates a separate CAST structure, removes the ARRAY option from CONVERT and updates the grammar and all tests accordingly. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Handle new cast expression in evalengine and planbuilder Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * evalengine: do not duplicate CAST/CONVERT translation Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> * Add back unary single column expression check (vitessio#10514) This was accidentally removed in vitessio#10512 but it shouldn't have been. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Vicent Marti <vmg@strn.cat>

…0538) (vitessio#10540) Signed-off-by: Andrew Mason <andrew@planetscale.com>

…#10508) (vitessio#10528) * addition of the release_notes_label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of a helper step in the release_notes_label to guide users Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of a set of rules for release_notes_labels's pull_request target Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove the previous workflow that used to check the release notes labels Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Change the review check list and enforce the use of type/component labels Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed syntax in check release notes label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…o#10484) Signed-off-by: Andrew Mason <andrew@planetscale.com>

…#10532) * generate the release changelog as a second document Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * include every PR in the release notes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Moved changelog metrics away from the changelog and added summary for v15 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…0553) * test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: handle empty row for scalar aggregation and also olap engine for scalar aggregation Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: update plan test output Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: e2e test for empty rows in non-scalar aggregates Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* docs: add blurb about gen4 being the new planner Signed-off-by: Andres Taylor <andres@planetscale.com> * docs: release notes Signed-off-by: Andres Taylor <andres@planetscale.com>

…tessio#10480) (vitessio#10554) Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…itessio#10560)

…itessio#10464) (vitessio#10546) * Adds RPCs to vttablet that vtorc requires (vitessio#10464) * feat: add vttablet rpc to reset replication parameters Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: added end to end testing for the rpc and fixed bug Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix typing error Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add basic full status rpc functionality and add test for it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add all the fields needed in full status Signed-off-by: Manan Gupta <manan@planetscale.com> * test: moved the test to reparent tests and improved it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: bug fix for no replication status and no primary status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add version to the full status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add binlog information to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: fix the comment explaining the binlog information Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add semi-sync statuses to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: call the correct command Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add server uuid and id to full status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: make server_id a uint32 to accept the correct range of values Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add few more fields to the full status like version comment, semi-sync settings, binlog_row_image Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: generate vtadmin proto files Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add assertion to check binlog row format is read correctly Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: split GTID mode in its own function because mariadb doesn't support it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix parsing of empty mariadb gtid set Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add doucmentation for existing fields in ReplicationStatus Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add relay log file position to the replication status output Signed-off-by: Manan Gupta <manan@planetscale.com> * test: augmented full status test to check all the different positions stored Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add additional fields to replication status and read source user Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read sql delay from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read ssl allowed from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read has replication filters from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: read auto position and using gtid from show replica status output Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add replication lag unknown too to replication status Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return nils from replication and primary postiion if it is not present Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: rename FileRelayLogPosition in replication status output to RelayLogSourceBinLogEquivalentPosition and augment test to make sure rpc changes are backward compatible Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update vtadmin proto files Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: rename BinLog to binlog in renamed proto field Signed-off-by: Manan Gupta <manan@planetscale.com> * lint: add a new line to proto file Signed-off-by: Manan Gupta <manan@planetscale.com>

…io#10562) * VReplication: more unrecoverable error codes Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * correct path for test files Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* test: reproduce the panic as a unit test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: check ev is not nil before using its fields Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: increase timeout of LockShard and wait replicas in VTOrc default config Signed-off-by: Manan Gupta <manan@planetscale.com>

…#10535) (vitessio#10570) The canonical form of printing the vitess migration syntax would upcase the UUID value, but it needs to be passed through unchanged. This in turn led me to testing comments in a query as well and it turns out we wrongly change the case there as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

…sist and unrecoverable errors (vitessio#10573) * Fail VReplication workflows on errors that persist and unrecoverable errors (vitessio#10429) * Fail workflow if same error persists too long. Fail for unrecoverable errors also in non-online ddl workflows Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Update max time default to 15m, was 1m for testing purposes Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Leverage vterrors for Equals; attempt to address my own nits Signed-off-by: Matt Lord <mattalord@gmail.com> * sanity: validate range of vreplication_retry_delay and of vreplication_max_time_to_retry_on_error Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Fix flags test Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Remove leftover log.Flush() Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Revert validations min/max settings on retry delay since it is breaking unit tests that set the value to a very small value Signed-off-by: Rohit Nayak <rohit@planetscale.com> * captilize per request Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fix TestHelpOutput Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * spaces, not tabs Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Rohit Nayak <57520317+rohit-nayak-ps@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

…sts (vitessio#10522) * Take into account `github.ref` when doing upgrade-downgrade tests (vitessio#10504) * Take into account the github.ref variable when doing upgrade-downgrade tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed upgrade-downgrade workflows' syntax to use 'previous' instead of 'latest' Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed syntax error in backup upgrade downgrade workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fixed static_checks_etc workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…hannel might block the vstream thread if target channel goes away: context was not being checked then. Fix health stream goroutine leak. (vitessio#10576) Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* add-vtadmin-docker-image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * env as function, update tests and code Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * feat: fix remaining env usages to be function calls Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin build result in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin web cleaning Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add vtadmin docker image entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * add the possibility to custom vtadmin web port in Docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin docker port Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * fix vtadmin entrypoint Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * set default vtadmin docker user as vitess Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * do not build vtadmin frontend in the bootstrap image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * build vtadmin frontend only in vtadmin docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * vtadmin replace sed and custom entrypoint with config.js file Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * remove vitess web files in lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * move vtadmin config into a specific directory Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> * restore vtadmin web file in mysql57 lite docker image Signed-off-by: Léopold Jacquot <leopold.jacquot@infomaniak.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Léopold Jacquot <leopold.jacquot@gmail.com> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: deepthi <deepthi@planetscale.com>

* CherryPick: VDiff2: Support Resuming VDiffs (vitessio#10497) And fix a number of bugs discovered related to incorrect VDiff summary handling and other more minor things. Signed-off-by: Matt Lord <mattalord@gmail.com>

* feat: log acl warn error when schema tracking fails with unauthorized or permission error Signed-off-by: Harshit Gangal <harshit@planetscale.com> * feat: modified logging message for acl and improved testing time Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Documented the legacy healthcheck and tabletgateway and added summary to 14's summary (vitessio#10567) * Documented the legacy healthcheck and tabletgateway and added summary to 14_summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Revert unwanted change in 14_summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Updated the 14_summary fixed typo and remove unwanted content Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * release notes: fix repititions, inaccuracies and some other minor edits Signed-off-by: deepthi <deepthi@planetscale.com> * edit VTOrc durability section Signed-off-by: deepthi <deepthi@planetscale.com> * docs: added details to the release summary Signed-off-by: Andres Taylor <andres@planetscale.com> * Added more details to the insert select example Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * More consistent capitalization of components name Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update the release notes summary Signed-off-by: Matt Lord <mattalord@gmail.com> * Tweaks to VDiff2 notes Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: deepthi <deepthi@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

* enable schema tracking by default (vitessio#10455) * feat: enable schema tracking by default Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: fix test setup Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: fix vschema test setup Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: turn off schema tracking on the tablet Signed-off-by: Andres Taylor <andres@planetscale.com> * test: fix test assertion Signed-off-by: Andres Taylor <andres@planetscale.com> * Change read query for checks that test to which keyspace a table is routed to. This uses the /queryz vttablet endpoint where the query gets expanded if schema tracking is enabled, hence failing an exact query check Signed-off-by: Rohit Nayak <rohit@planetscale.com> * test: only use gen4 planner Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: column list population in insert with auto-inc column Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: change parser to keep empty column list as provided by user Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: fix test expectation Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: fix test expectation Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: Allow gen4 to handle variables on authoritative tables Signed-off-by: Andres Taylor <andres@planetscale.com> * Empty-Commit Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: system variable selection on a table only works in gen4 Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

* Release commit for 14.0.0 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Back to dev mode Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…essio#10604) * fix: handle planner_version and planner-version correctly (vitessio#10534) * fix: handle planner_version and planner-version correctly Signed-off-by: Andres Taylor <andres@planetscale.com> * test: clean up test and remove the '(default gen4)' Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Updated expected output for vtgate and vttablet flags Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

* Release commit for 14.0.0 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Back to dev mode Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* release notes: schema tracking no longer experimental Signed-off-by: deepthi <deepthi@planetscale.com> * Removed misleading sentence in 14_0_0 summary file Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Removed misleading sentence in 14_0_0 release notes file Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…io#10588) * Fixed the release notes CI check helper (vitessio#10574) * Fixed the release notes CI check Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fail the print helper step so its output can be displayed Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed check_pull_request_labels helper text Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…0613) (vitessio#10623) * unit test: fix mysql tests to run on MacOS Signed-off-by: deepthi <deepthi@planetscale.com> * unit test: add underscore to error message regex, macos temp folder names can have that Signed-off-by: deepthi <deepthi@planetscale.com> * unit test: clean up func signature, fix error formatting Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: deepthi <deepthi@planetscale.com>

Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: Frances Thai <31225471+notfelineit@users.noreply.github.com>

…sio#10677) Signed-off-by: Manan Gupta <manan@planetscale.com>

… vttablets (vitessio#10597) (vitessio#10644) * examples/compose: Set keyspace durability policy to help vtorc recognize vttablets Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Move SetKeyspaceDurabilityPolicy commands to a more appropriate place. Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Add a set_keyspace_durability_policy container to docker-compose.beginners.yml Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Adjust a generated docker-compose.yml by vtcompose/vtcompose.go to work Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Tweak docker-compose.beginners.yml to use the environment variable Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Fix a gofmt error Signed-off-by: yoheimuta <yoheimuta@gmail.com> Co-authored-by: yoheimuta <yoheimuta@gmail.com>

…ssio#10688) * Addition of a test waiter for schema tracking in online CREATE TABLE sub test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Change the vttablet schema tracking interval to a lower value for online ddl e2e tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* CI: mysql8 test for schemadiff_vrepl Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * adapt schemadiff_vrepl test for mysql8 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…sio#10680) * Expect different value for mysql80 in TestFloatValueDefault Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix TestShowTables for mysql80 Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix TestShowTables, TestShowTablesWithWhereClause, TestFunctionInDefault for mysql80 Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix TestFKConstraintUsingInformationSchema for mysql80 Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Fix TestShowColumns properly Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* test: set parameter on vtgate than on vttablet Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: match any for mysql 57 and 80 different for charset Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

… of update queries (vitessio#10723) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

vitessio#10734) * feat: keep apply join predicate when pushing new ones Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add end to end test for the bug fix Signed-off-by: Manan Gupta <manan@planetscale.com>

…er_version Flag (vitessio#10733) * Auto Detect MySQL Version and Use in vtgate mysql_server_version Flag (vitessio#10701) * Auto detect MySQL version and use in vtgate --mysql_server_version flag Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove any explicit static usage of mysql_server_version Signed-off-by: Matt Lord <mattalord@gmail.com> * The reservedconns test needs to override the mysql_server_version Signed-off-by: Matt Lord <mattalord@gmail.com> * Explicitly allow overriding the mysql_system_version Signed-off-by: Matt Lord <mattalord@gmail.com> * minimize diff Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix vitessio#10712 Signed-off-by: Matt Lord <mattalord@gmail.com> * Use more robust string comparisons Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix collation handling in tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix tm_init_test Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix more unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Another test fix Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix another test that requires 8.0 collations Signed-off-by: Matt Lord <mattalord@gmail.com> * Kick the CI :-| Signed-off-by: Matt Lord <mattalord@gmail.com>

…ssio#10616) * Use the old planner version flag in v14 upgrade-downgrade tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Increased timeout in TestSchemaTrackingError and avoid exiting on early failure Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestSchemaTrackingError if vtgate is < v14 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…o#10725) (vitessio#10778) Signed-off-by: Rohit Nayak <rohit@planetscale.com>

Signed-off-by: Phani Raj <phani@planetscale.com> Co-authored-by: Phani Raj <phani@planetscale.com>

…adSchema` (vitessio#10796) * Tablet Executor: consolidate ReloadSchema calls, and skip for Online DDL Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * ApplySchema: renew keyspace lock while iterating SQLs Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * ApplySchema: do not ReloadSchema on ExecuteFetchAsDba Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Online DDL: issue a ReloadSchema at the completion of any migration Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…tessio#10779) (vitessio#10795) * looking into onlineddl_vrepl_stress_suite flakiness in CI (vitessio#10779) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * rate limiter Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Upgrade to `go1.18.4` (vitessio#10705) * Upgrade to Go 1.18.4 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix golangci-lint error in collations package Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Reverted unwanted changes to collation package Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix xb backup mysql80 workflow go version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Migrate the rest of the CI workflows to go1.18.4 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…sio#10822) * Initial addition of the skip workflow directive in docker_test_cluster_10 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed assertion in skip workflow step Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Use github.event.push.ref to check the event type Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of debug information in the skip ci step Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of debug information in the skip ci step Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of debug information in the skip ci step Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip the step based on the skip-workflow step Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Applied the skip-workflow step on all the workflows Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed the vtadmin workflows' default directory to root Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Removed unwanted workflow files Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Better bash syntax for regex condition Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed skip to use boolean string and use better regex to match the release branch Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…vitessio#10831) * fix: only compare the same type otherwise fail Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added an e2e test that fail as per the fix Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Release commit for 14.0.1 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Back to dev mode Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…essio#10895) * Merge pull request vitessio#10847 from planetscale/8.0.30_builtin_backups ... removing the temporary workflow changes on main Backups: Support InnoDB Redo Log Location With 8.0.30+ Signed-off-by: Matt Lord <mattalord@gmail.com> * Address linter warning: WARN [linters context] structcheck is disabled because of go1.18. You can track the evolution of the go1.18 support by following the golangci/golangci-lint#2649. go/mysql/conn_flaky_test.go:658:2: S1001: should use copy() instead of a loop (gosimple) for j, i := range t.queryPacket { ^ Signed-off-by: Matt Lord <mattalord@gmail.com> * Pin MySQL Version at 8.0.29 for upgrade/downgrade manual e2e test This is needed as we do not currently plan on backporting the backup fixes to v13 and older, thus release-13.0 will not ever get the backup fixes to support 8.0.30+. If we do decide to backport the fixes to release-13.0 then this workflow change can be reverted. Signed-off-by: Matt Lord <mattalord@gmail.com> * Correct comment based on current plans Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

…icationStateConnecting (vitessio#10927) Signed-off-by: Manan Gupta <manan@planetscale.com>

…10638) (vitessio#10918) * report error message on cutover error Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * truncate original check constraint name if it includes table name; fail migration on error 1059 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * test Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

* CI: get mariadb 10.3 from rackspace mirror instead of DO Signed-off-by: deepthi <deepthi@planetscale.com> * CI: add mariadb102 back to template on release branch * regen workflow file with new mirror * backport launchable change which was missing on this branch * regen workflow produced other changes in a handful of workflows Signed-off-by: deepthi <deepthi@planetscale.com> * CI: fix mysql80 template to use vitessio fork of go-junit-report and regen workflow files Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: deepthi <deepthi@planetscale.com>

…eport (vitessio#11024) Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: deepthi <deepthi@planetscale.com>

10.2 is now EOL: https://mariadb.com/kb/en/mariadb-server-release-dates/ https://endoflife.date/mariadb And we also deprecated MariaDB support in v14+: vitessio#9518 Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

* ci: add worklow file to the path filter for generated workflows Signed-off-by: Manan Gupta <manan@planetscale.com> * ci: add worklow file to the path filter for non-generated workflows Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…itessio#11049) * feat: remove enable_queries from v14 tests and its uses Signed-off-by: Manan Gupta <manan@planetscale.com> * test: remove remaining usages of vttabletStreamHealth Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…o#11034) * ci: add upgrade test for new vtctl Signed-off-by: Manan Gupta <manan@planetscale.com> * ci: add upgrade test for new vttablet Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix vttablet upgrade-downgrade tests to not require the get_upgrade_downgrade_label step Signed-off-by: Manan Gupta <manan@planetscale.com> * ci: add tests for query serving for next release Signed-off-by: Manan Gupta <manan@planetscale.com> * ci: add tests for backups for next release Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix comment in next release script Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix replication thread state assertion to also account for v15 tablets in tests Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: move deprecated values from vtctld setup to only tests that require it to make upgrade-downgrade run Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

* Add SKIP check to workflows removed in v15 These workflows did not exist on main so they were not updated when vitessio#10768 was backported. This means that we'll need to backport this work to release-13.0 and release-12.0 as well. Signed-off-by: Matt Lord <mattalord@gmail.com> * Skip sharding multi and legacy local example if needed Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

) * Fix Upgrade Downgrade manual backup dependencies install Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update backup u/d e2e tests comments Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…io#11070) (vitessio#11077) * fix: return when instructions are nil in checkThatPlanIsValid Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added unit test Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

Backport of vitessio#11046 to release-14.0. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Because `healthCheck` was being explicitly declared as a concrete type, later, in `newTabletWithStatsAndURL` (in api.go), when we compare the _interface_ to `nil`, we get `false` (despite the underlying implementation being itself `nil`), and so we attempt to call `GetTabletHealth` on `nil`, resulting in a panic. See one of [my favorite talks](https://youtu.be/ynoY2xz-F8s?t=796) on why this is. Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…endtoend flakiness fix (vitessio#10928) * resolve conflict for cherry-pick 3012060 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * onlineddl_vrepl flakiness: further work (vitessio#10876) * onlineddl_vrepl flakiness: further work Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * uint64 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Upgrade go version to 1.18.5 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update test.go with the proper bootstrap version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

vitessio#11130) (vitessio#11132) * Include the compose examples in the do_release script Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix updateVitessExamples function call Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…#11158) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Release `v14.0.2`

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…ease-14.0 [release-14.0] Simple code freeze script and workflow (vitessio#11178)

…Pull Requests instead of one during a release (vitessio#11230) * Use two different branches and two different commits to do the release Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Enforce the use of BASE_REMOTE and BASE_BRANCH Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Unfreeze the branch when doing the release Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…esent in database_instance table (vitessio#10662) (vitessio#11238) * test: add failing test for durability policy setting after vtorc starts Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add query to also check for vttablets whose information is absent in the database_instance table Signed-off-by: Manan Gupta <manan@planetscale.com> * test: rename test Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…#11212 (vitessio#11232)

…essio#11236) * Initial rework of the release instructions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Added more content and description to the release cutover section Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Applied review suggestions Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Changed release doc to use a more recent version increment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update the documentation with a simpler tuto for the release and a new one for the code freeze Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of links to the vitess operator documentation Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Update doc/internal/ReleaseInstructions.md Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> * Apply review suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Restart the build Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: FlorentP <35779988+frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Co-authored-by: FlorentP <35779988+frouioui@users.noreply.github.com>

Fixes vitessio#11261 Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…ns for `LEFT JOIN` statements (vitessio#11333) * Fix complex predicates being pulled into `ON` conditions for `LEFT JOIN` statements. Also convert `LEFT JOIN` statements with complex predicates into `INNER JOIN` when possible. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Allow outer join simplification for `IS NOT NULL` expressions. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * update test assertions after move to R14 Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix conditions after `<=>` operator on left joined table columns being ignored for routing purposes. (vitessio#11310) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Update test assertions after backport Signed-off-by: Andres Taylor <andres@planetscale.com> * Update the expectation of TestFilterOnLeftOuterJoin to not fail Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix: include MultiEqual in engine variant execution, added unit test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* addition of empty release summary for 14.0.3 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * feat: add a line describing the VTOrc bug fix Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* Release notes for 14.0.3 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Release commit for 14.0.3 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Backport of vitessio#11379 * tests: add more plan_tests for derived tables and subqueries Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> * refactor: make switch pretty Signed-off-by: Andres Taylor <andres@planetscale.com> * feat: push derived table under the route Signed-off-by: Harshit Gangal <harshit@planetscale.com> * simplify logic Signed-off-by: Andres Taylor <andres@planetscale.com> * check for valid derived tables also when doing JOIN on the vtgate Signed-off-by: Andres Taylor <andres@planetscale.com> * comments Signed-off-by: Andres Taylor <andres@planetscale.com> * add more tests with derived tables Signed-off-by: Andres Taylor <andres@planetscale.com> * handle HAVING in derived tables correctly Signed-off-by: Andres Taylor <andres@planetscale.com> * merge tests into single file Signed-off-by: Andres Taylor <andres@planetscale.com> * rename test keypspace Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* produce the new json tests Signed-off-by: Andres Taylor <andres@planetscale.com> * change the output format and testing to use the new json format Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>

…vitessio#11458) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Upgrade to go1.18.7 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Upgrade the build.env file for go1.18.7 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix check_make_sizegen Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove test code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…indexes, but can be merged via join predicates. (vitessio#10942) (vitessio#11562) Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

… (vitessio#11564)

* refactor: clean up the JSON AST structs a little Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add failing test Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

… active during resharding (vitessio#11640) (vitessio#11651) * VTexplain topology only uses serving shards This addresses isse vitessio#11632 , which causes vtexplain to sometimes give bad results if the keyspace is being resharded, because sometimes it picks source shards and other times target shards, for routing the query. The issue is that the `VTExplain.buildTopolog()` adds both source and destination shards to the map that holds shards per keyspace, when only one of them is actually serving traffic at any point in time. Later on, vtexplain loops over this map. Because looping over the map gives a non-deterministic order, sometimes the results are correct, and sometimes incorrect - that is, sometimes it gives the result of the shard that is serving, and other times, the shard that is not serving. This change ensures that only the serving shards are added to the shards per keyspace map, thus avoiding the incorrect vtexplain. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * This addresses issue vitessio#11632 , which causes vtexplain to sometimes give bad results if the keyspace is being resharded, because sometimes it picks source shards and other times target shards, for routing the query. The issue is that the VTExplain.buildTopolog() adds both source and destination shards to the map that holds shards per keyspace, when only one of them is actually serving traffic at any point in time. Later on, vtexplain loops over this map. Because looping over the map gives a non-deterministic order, sometimes the results are correct, and sometimes incorrect - that is, sometimes it gives the result of the shard that is serving, and other times, the shard that is not serving. This change ensures that only the serving shards are added to the shards per keyspace map, thus avoiding the incorrect vtexplain. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix check_make_vtadmin_authz_testgen Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

…1671) * Do not multiply `AggregateRandom` in `JOIN`s (vitessio#11633) * Do not multiply AggregateRandom in JOIN Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update the releases notes with new known issue Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of the release notes for v14.0.4 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * set sql mode in TestAggregateRandom Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update plan test to remove table used json object Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…pcs when transaction or reserved connection is acquired (vitessio#11688) * Fix ordering when error happens during stream setup (vitessio#11592) * Fix ordering when error happens during stream setup When we already have an error during the stream setup, that errors needs to be returned immediately. Otherwise the stream will already be started and the error message is never returned to the client and it silently looks like a success even if it's a failure. This in turn can result in an empty result for example when an error would have been expected. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Add a bunch of testing to verify stream execute behavior Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> * Send errors in stream instead of a grpc error from streaming rpcs when transaction or reserved connection is acquired (vitessio#11656) * wip Signed-off-by: Harshit Gangal <harshit@planetscale.com> * feat: send errors in stream instead of a grpc error from streaming rpcs Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> * Empty-Commit Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…o#11695) * update jsonparser dependency Signed-off-by: deepthi <deepthi@planetscale.com> * small change to PR template Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: deepthi <deepthi@planetscale.com>

…sio#11668) (vitessio#11713) * Addition of a CI tool to detect dead links in test/config.json (vitessio#11668) * Addition of a tool to detect unrequireed CI clusters in test/config.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * move mysql80 derived to queries/derived in config.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test: clean the user table as well Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix flakyness in TestDerivedTableWithHaving Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestDerivedAggregationOnRHS Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * apply go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * clean up workflows, backport 10710 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * skip failing tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

* Push down derived tables under route when possible (vitessio#11379) * tests: add more plan_tests for derived tables and subqueries Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> * refactor: make switch pretty Signed-off-by: Andres Taylor <andres@planetscale.com> * feat: push derived table under the route Signed-off-by: Harshit Gangal <harshit@planetscale.com> * simplify logic Signed-off-by: Andres Taylor <andres@planetscale.com> * check for valid derived tables also when doing JOIN on the vtgate Signed-off-by: Andres Taylor <andres@planetscale.com> * comments Signed-off-by: Andres Taylor <andres@planetscale.com> * add more tests with derived tables Signed-off-by: Andres Taylor <andres@planetscale.com> * handle HAVING in derived tables correctly Signed-off-by: Andres Taylor <andres@planetscale.com> * merge tests into single file Signed-off-by: Andres Taylor <andres@planetscale.com> * rename test keypspace Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix select_cases.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestDerivedAggregationOnRHS Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix unwanted change Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove unwanted test function Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…cript (vitessio#11814) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Fix files changes filtering in CI (vitessio#11714) * test go.sum modification Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test filter with different go.mod and go.sum rules Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * use different filters for go.mod and go.sum everywhere Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * clean up go.sum Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix format issue in .github/workflows/cluster_endtoend_18.yml Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

… (vitessio#11833) * codeowners: have at least two for almost every package Signed-off-by: deepthi <deepthi@planetscale.com> * codeowners: add release team to /doc/ Signed-off-by: deepthi <deepthi@planetscale.com> * Add rohit to relevant packages with single codeowner Signed-off-by: Rohit Nayak <rohit@planetscale.com> * codeowners: fix vttablet packages that had none Signed-off-by: deepthi <deepthi@planetscale.com> * added harshit to vttabet/grpc package Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…sio#11487) (vitessio#11835) Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…ain (vitessio#11838) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

* Release notes for 14.0.4 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Release commit for 14.0.4 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

) * Fix closing the body for HTTP requests (vitessio#11842) One of the easy things to miss that can cause resource leaks is not closing a response body for an HTTP request. There's a linter available to make it easier to catch this, so this enables that linter and fixes all the cases reported. This is almost all test cases, except for one production code path case in the throttler. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Always close body for HTTP requests (vitessio#10835) Not closing the body leads to leaking goroutines for the reader / writer of the body. Found when validating that tests don't leak goroutines (to ensure other things get closed properly, but these cases where also found). Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix remaining body close issues Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

…vitessio#11769) * Move towards MySQL 8.0 as the default template generation (vitessio#11153) * Move towards MySQL 8.0 as the default template generation This upgrades the remaining things to Ubuntu 20.04 and makes MySQL 8.0 the default we run tests against. We still have tests for MySQL 5.7 but those are now explicitly opted into. This should finish up the Ubuntu 20.04 upgrade and also makes things easier for the future when we need to upgrade again. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * CI: rename shard vtorc_8.0 to vtorc_5.7, change expected test output for 8.0 Signed-off-by: deepthi <deepthi@planetscale.com> * CI: increase timeout for 8.0 tests on the actual test step from 30 to 45 mins Signed-off-by: deepthi <deepthi@planetscale.com> * CI: increase timeout to 45 minutes for mysql57 tests too. We really only need this for vtorc, but I've made the change to the template so all tests get it. Signed-off-by: deepthi <deepthi@planetscale.com> * CI: fix vtorc test to work with both 5.7 and 8.0 Signed-off-by: deepthi <deepthi@planetscale.com> * CI: missed docker flag in mysql57 template, one more fix to vtorc test Signed-off-by: deepthi <deepthi@planetscale.com> * removing spaces from pb file Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing spaces in pb file part 2 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: deepthi <deepthi@planetscale.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com> * changing update statement to alter Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Adding mysql 8.0.25 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix junit Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing failures Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing more unit tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix selfhost test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Fixing selfhosted workflows Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing vreplication_v2 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing cluster 12 and 18 from selfhosted Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * manual fixing some workflows Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * making vreplication_v2 exactly like upstream Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Moving all the workflow to latest mysql version (vanilla) Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * remove port restrictions Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * tmp fix for vreplication_v2 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * making vreplication_v2 to previous version Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * correcting typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * mvoing vreplication_v2 to selfhost Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * change docker image to mysql80 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing limited source from vrepl Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * revert back last commit changes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * test: fix aggregation test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * removing ptrtls Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * remove pitrTls tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * changing source/destination to mysql8.0 for vreplication Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * remove unwanted workflows Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding timeout to stress test Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * feeback through code review Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: deepthi <deepthi@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…itessio#11866) * Fix deprecated usage of set-output (vitessio#11844) (vitessio#11855) The `set-output` command is deprecated and will break in the future. This moves to the new style for all our GitHub Actions. See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Also upgrades some more runners to Ubuntu 20.04 that were missed in previous backports. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Upgrade to Ubuntu 20.04 for endtoend tests (vitessio#11113) This extracts the update to Ubuntu 20.04 (and thus MySQL 8 by default) just for the end to end tests and updates the associated tests. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

…vitessio#11901) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…o#11925) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

… server side error (vitessio#11928) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…itessio#12103) * Fix: Date math with Interval keyword (vitessio#12082) * feat: add failing parsing test and fix parser Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add e2e tests for interval with math functions Signed-off-by: Manan Gupta <manan@planetscale.com> * test: explictly set the time-zone to prevent failures in CI Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix expected output Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…upported (vitessio#12111) (vitessio#12118) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* fix: aggregation coming from right hand side of left join check for null * test: added a sum test * addressed review comments --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…cessary GetTablet calls to topo (vitessio#12194) (vitessio#12243) * check filter later in loadTablets. Add tests to confirm expected behavior * remove unnecessary assignment * add some explanation around TestFilterByKeypsaceSkipsIgnoredTablets * simplify filter check logic as well as major test cleanup, using testify where possible --------- Signed-off-by: Brian Ramos <brirams@users.noreply.github.com> Co-authored-by: Brian Ramos <brirams@users.noreply.github.com>

…ncation (vitessio#12468) (vitessio#12471) * Fix scalar aggregation engine primitive for column truncation (vitessio#12468) * fix: scalar aggregation truncation Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added scalar aggr engine unit test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * remove onecase change Signed-off-by: Harshit Gangal <harshit@planetscale.com> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> * feat: fix tests Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…sio#12484) (vitessio#12493) * test: add failing test for a query in an unsharded keyspace using a derived table and reference table * feat: fix logic to check if a single unsharded keyspace is used * feat: fix test output --------- Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Improve release process post `v16.0.0 GA` code freeze (vitessio#12487) * Update the release instructions document with pre-requisites for release team Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Add Do Not Merge to release Pull Request upon creation Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Block merge if the `Do Not Merge` label is set (vitessio#12489) * Block Merge if the label is set Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix echo syntax Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix typo Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…io#12563) * collations: fix sorting in UCA900 collations When using the fast iterator to _compare_ two strings with an UCA collation, we need to keep in mind that the weights in the collation are in BIG ENDIAN (this is the output format for the weight strings, so we store the weights this way), so comparing them directly will not result in the proper collation order. They need to be byte-swapped before they can be compared with an arithmetic operation! * collations: comment --------- Signed-off-by: Vicent Marti <vmg@strn.cat>

…runners (vitessio#12583) (vitessio#12586) * CI: extend timeouts in onlineddl_vrepl due to slow CI runners Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * increase even further Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…er `65,528` parameters (vitessio#12628) * Fix `panic` when executing a prepare statement with over `65,528` parameters (vitessio#12614) * fix type conversion in query.go for the bitMap size Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * enhance the TestHighNumberOfParams test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix test comment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update the TestHighNumberOfParams test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…le (vitessio#12607) (vitessio#12646) * Fix random aggregation to not select Null column * stop pushing down projections that should be evaluated at the vtgate level * undo changes to AggregateRandom * clean up code * fix executor test mock --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…ma (vitessio#12641) (vitessio#12666) * Mysqld.GetSchema: tolerate tables being dropped while inspecting schema * lack of primary key columns in STATISTICS does not mean table is dropped. It can also mean the table does not have PRIMARY KEY * populate validTds rather than rely on nil hints * re-introdce earlier check * use validTds, sync * due to many tests consistently failing, trying a different approach: we keep the table, but with empty column/key/fields info * grammar --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…og` (vitessio#12566) (vitessio#12658) * Re-organize the `releasenotes` directory into `changelog` (vitessio#12566) * Move all release related documents to ./release and add tool to generate READMEs Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of the release.go file Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * simplify release.go Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * generate the release notes in the proper place Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * modify previous mentions of docs/releasenotes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * re-add v17.0.0 summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add new release tool to release instruction and ci Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * apply review suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * simplify release notes document path Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestions and fix team files Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update the changelog dir and release_notes_label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…#12700) * [planner bugfix] add expressions to HAVING (vitessio#12668) * [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the Signed-off-by: Andres Taylor <andres@planetscale.com> * update test expecteations Signed-off-by: Andres Taylor <andres@planetscale.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix plan tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

@mattlord

…ssio#12707) * Auto upgrade the Golang version (vitessio#12585) * initial addition of the go_upgrade tool to detect and bump the golang version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update go.mod automatically Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix isSameMajor version issue Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update the bootstrap version automatically Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update the bootstrap docker image changelog Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * uncomment code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of base to create-pull-request Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test create PR alternative Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add flags and getter methods Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * better PR message Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix no-workflow-update flag and better PR body msg Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix PR title, branch and body format Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test matrix and pwd path Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * enhanced matrix Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update_workflows option Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update workflows independently Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test without matrix Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Add docs to go_upgrade and re-add matrix to the workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * support major version upgrade Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * do not update bootstrap version if they are the same Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * migrate to cobra instead of pflags Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove redundant comment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * safety net around replaceGoVersionInCodebase to avoid unrequired upgrade Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove double negation in workflowUpdate flag Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Use regexp instead of mere string comparison Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Proper regexp for every string comparison Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * use better regex Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove useless flag and improve the auto-PR body description Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add note in the tool usage to run the tool at the root of the repo Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add comment in .github/workflows/update_golang_version.yml Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply @mattlord code suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * replace usages of old filename Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply suggestions from code review Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> * Use go1.18 compatible variable Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix regexp Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

…itessio#12704) (vitessio#12727) Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com> Co-authored-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>

…sio#12683) (vitessio#12743) * Reset the current lag when closing the replication lag reader. * Fix tests. --------- Signed-off-by: Johan Stenberg <johanstenberg92@github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Johan Stenberg <johanstenberg92@github.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Release notes for 14.0.5 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Release commit for 14.0.5 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix release doc path Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

This doesn't actually do anything yet except spark up the mysql server and start listening for connections.

* First draft of discovery * Fix address list collection * Fix nebula discovery

* Stash the connection attributes on the conn struct * Clean up code style around upstream server changes

* Cleanup discovery. Prep for load balancing * first draft of az affinity * Restore git deps * Honor num connections * fix bugs * Don't try to register channelz (this should be done elsewhere) lis, err := net.Listen("tcp", "localhost:8153") if err != nil { log.Fatalf("failed to listen: %v", err) } s := grpc.NewServer() service.RegisterChannelzServiceToServer(s) go s.Serve(lis)

* Draft: very messy and doesn't compile * Simplifyy * less log, plz * simplify more * Simplified by a lot - much simpler now pick fewer addresses * fixy * Account for infinite * copyright nonsense * clean up debug logging * round_robin works! * use rw mutex to serialize creation * rework the filtering to make everything parameterized and more explicit Change all the config so that instead of hard coded constants we set the various connection attributes, json field names, etc using command line flags. Then make the pool type and affinity arguments more explicit and less generic. * no longer needed * update comments * only pass through the URL params we need * affinity is actually optional --------- Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>

* Fix locking in getConnection Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Comment Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> * Undo bash change Signed-off-by: Henry Robinson <hrobinson@slack-corp.com> --------- Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* Make -grpc_prometheus work when not using a grpc server Signed-off-by: Henry Robinson <hrobinson@slack-corp.com>

* refactor a bit more to consolidate the command line flags * rework again to have a single parser and move around all the logic This way we only have a single entity watching the file and dispatching out to the resolvers when things change rather than a bunch of tickers watching the file. Also cleaned up the code a bunch. * redo the shuffle to be a single pass * actually use the builder rand not the global one * add some metrics * only stat once per second * split out counter for unknown affinity

* reinitalise targets when parsing host list * remove metrics and logging changes

* move organization of target hosts to parse time * rework metrics and logging of parse errors * add discovery bits to debug status page * reset parseErr in the right place * add sync and change debug page to do the shuffle * unrelated but just move some code around --------- Co-authored-by: Michael Demmer <mdemmer@slack-corp.com>

Commits on Apr 11, 2024

Enable prometheus stats on /metrics (#290 )

henryr authored Apr 11, 2024

Configuration menu

View commit details

Copy full SHA for 258acd6

Browse repository at this point

Copy the full SHA

258acd6 View commit details

Browse the repository at this point in the history

Commits on May 6, 2024

add execute timing stats (#329 )

demmer authored May 6, 2024

Configuration menu

View commit details

Copy full SHA for 10d4525

Browse repository at this point

Copy the full SHA

10d4525 View commit details

Browse the repository at this point in the history

Commits on May 15, 2024

include vtgate hostname in debug page

demmer committed May 15, 2024

Configuration menu

View commit details

Copy full SHA for 7a74f22

Browse repository at this point

Copy the full SHA

7a74f22 View commit details

Browse the repository at this point in the history

vtgateproxy include hostname in debug page #15949

vtgateproxy include hostname in debug page #15949

Commits on Jun 7, 2022

Commits on Jun 8, 2022

Commits on Jun 9, 2022

Commits on Jun 10, 2022

Commits on Jun 13, 2022

Commits on Jun 14, 2022

Commits on Jun 16, 2022

Commits on Jun 17, 2022

Commits on Jun 21, 2022

Commits on Jun 22, 2022

Commits on Jun 23, 2022

Commits on Jun 24, 2022

Commits on Jun 27, 2022

Commits on Jun 28, 2022

Commits on Jun 29, 2022

Commits on Jul 6, 2022

Commits on Jul 12, 2022

Commits on Jul 13, 2022

Commits on Jul 14, 2022

Commits on Jul 15, 2022

Commits on Jul 18, 2022

Commits on Jul 19, 2022

Commits on Jul 20, 2022

Commits on Jul 21, 2022

Commits on Jul 25, 2022

Commits on Jul 26, 2022

Commits on Aug 2, 2022

Commits on Aug 3, 2022

Commits on Aug 4, 2022

Commits on Aug 9, 2022

Commits on Aug 12, 2022

Commits on Aug 16, 2022

Commits on Aug 17, 2022

Commits on Aug 20, 2022

Commits on Aug 22, 2022

Commits on Aug 23, 2022

Commits on Aug 24, 2022

Commits on Aug 26, 2022

Commits on Aug 29, 2022

Commits on Aug 31, 2022

Commits on Sep 1, 2022

Commits on Sep 7, 2022

Commits on Sep 9, 2022

Commits on Sep 12, 2022

Commits on Sep 16, 2022

Commits on Sep 19, 2022

Commits on Sep 24, 2022

Commits on Sep 27, 2022

Commits on Sep 28, 2022

Commits on Sep 29, 2022

Commits on Sep 30, 2022

Commits on Oct 3, 2022

Commits on Oct 5, 2022

Commits on Oct 10, 2022

Commits on Oct 13, 2022

Commits on Oct 18, 2022

Commits on Oct 19, 2022

Commits on Oct 24, 2022

Commits on Oct 25, 2022

Commits on Nov 3, 2022

Commits on Nov 8, 2022

Commits on Nov 9, 2022

Commits on Nov 11, 2022

Commits on Nov 13, 2022

Commits on Nov 21, 2022

Commits on Nov 23, 2022

Commits on Nov 28, 2022

Commits on Nov 29, 2022

Commits on Nov 30, 2022

Commits on Dec 6, 2022

Commits on Dec 7, 2022

Commits on Dec 8, 2022

Commits on Dec 9, 2022

Commits on Dec 14, 2022

Commits on Dec 27, 2022

Commits on Jan 18, 2023

Commits on Jan 19, 2023

Commits on Feb 9, 2023