Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade the golang version used vitess-mixin #15972

Merged
merged 2 commits into from
May 20, 2024
Merged

Upgrade the golang version used vitess-mixin #15972

merged 2 commits into from
May 20, 2024

Conversation

frouioui
Copy link
Member

Description

Until we find out what we want to do with vitess-mixin this PR upgrades the golang version to what we use in the rest of the codebase and update the golang upgrade tool to also upgrade the go.mod of vitess-mixin in the future.

@frouioui
Upgrade the golang version used vitess-mixin
e6a292a 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@frouioui
bump to vitess 19.0.4
b006ffc 
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented May 17, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels May 17, 2024
@frouioui frouioui added Type: Internal Cleanup Component: Observability Pull requests that touch tracing/metrics/monitoring and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels May 17, 2024
@github-actions github-actions bot added this to the v20.0.0 milestone May 17, 2024
@codecov Codecov
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 68.44%. Comparing base (9911880) to head (b006ffc).

Files Patch % Lines
go/tools/go-upgrade/go-upgrade.go 0.00% 9 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15972      +/-   ##
==========================================
- Coverage   68.45%   68.44%   -0.01%     
==========================================
  Files        1562     1562              
  Lines      197057   197059       +2     
==========================================
- Hits       134891   134881      -10     
- Misses      62166    62178      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frouioui frouioui mentioned this pull request May 20, 2024
Closed
5 tasks
@harshit-gangal harshit-gangal merged commit 8b60b59 into vitessio:main May 20, 2024
105 checks passed
@harshit-gangal harshit-gangal deleted the fix-vitess-mixin-go-version branch May 20, 2024 06:44
@frouioui frouioui mentioned this pull request May 20, 2024
Merged
5 tasks
systay pushed a commit that referenced this pull request Jul 22, 2024
@planetscale-actions-bot @frouioui
CherryPick(#15972): Upgrade the golang version used vitess-mixin (#…
4ff89ac 
…5216)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshit-gangal harshit-gangal harshit-gangal approved these changes

@systay systay systay approved these changes

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 is a code owner

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@rohit-nayak-ps rohit-nayak-ps Awaiting requested review from rohit-nayak-ps rohit-nayak-ps is a code owner

Assignees
No one assigned
Labels
Component: Observability Pull requests that touch tracing/metrics/monitoring Type: Internal Cleanup
Projects
None yet
Milestone
v20.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@frouioui @systay @harshit-gangal