Vm slack 15.0 #16035
Closed
Vm slack 15.0 #16035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
* Release notes for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Release commit for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
vitessio#11448) * feat: call the logic for waiting for shard locks on synchronous on-term hooks and add tests for it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix comment for acceptSighupSignal function Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
… creation (vitessio#11415) (vitessio#11447) * Testing.... Signed-off-by: Matt Lord <mattalord@gmail.com> * Setup reverse routing rules at the start of the first partial movetables. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Update display representation of state for partially moved keyspaces Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Test improvements Signed-off-by: Matt Lord <mattalord@gmail.com> * Cleanup shard routing rules on cancel/complete Signed-off-by: Matt Lord <mattalord@gmail.com> * Cleanup intermediate changes Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix DryRun TrafficSwitcher and its tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Support concurrent partial movetables for N keyspaces And other minor changes after self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Avoid unnecessary save + rebuild steps Signed-off-by: Matt Lord <mattalord@gmail.com> * Add secondary ordering for shard routing rules on to_keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor changes after self review Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
…e correct binary. (vitessio#11450) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com>
* Use JSON for plan tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * move vschemas into single directory Signed-off-by: Andres Taylor <andres@planetscale.com> * indentation Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: FlorentP <35779988+frouioui@users.noreply.github.com>
…ssio#11469) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
This is to pick up the fix for golang/go#56152. Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>
…nShard`, `GetFullStatus` (vitessio#11438) (vitessio#11452) * Add validate Signed-off-by: notfelineit <notfelineit@gmail.com> * Add validate to cluster page Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Add UI for validate shard Signed-off-by: notfelineit <notfelineit@gmail.com> * Add validateShard Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web proto Signed-off-by: notfelineit <notfelineit@gmail.com> * Refactor validation results and implement validateShard Signed-off-by: notfelineit <notfelineit@gmail.com> * add http shards Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetFullStatus Signed-off-by: notfelineit <notfelineit@gmail.com> * Add keys and comment Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Add ValidateVersionShard to vtctldclient Signed-off-by: notfelineit <notfelineit@gmail.com> * Add ValidateVersionShard Signed-off-by: notfelineit <notfelineit@gmail.com> * Update test for vtctldclient Signed-off-by: notfelineit <notfelineit@gmail.com> * Add test for ValidateVersionShard Signed-off-by: notfelineit <notfelineit@gmail.com> * run lint prettier fix again Signed-off-by: notfelineit <notfelineit@gmail.com> * Modify during 1:1 with gomez Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Address PR review comments Signed-off-by: notfelineit <notfelineit@gmail.com> * Update indentation Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: notfelineit <notfelineit@gmail.com>
* Fix check_make_sizegen Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove test code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…1483) * feat: add replacer and code to always print semi-sync fields and decode the io and sql state from integers to strings Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: prettify the changed file Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix replication state strings and simplify code Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
…action Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
* Plan order by Count() Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Clean up the new aggregation E2E test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Push more order by needs to the select list Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove unrequired code in TestOrderByCount Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove unwanted directory Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
…k overflow (vitessio#11499) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>
* test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * log txID and reserveID in stream execute Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: maintain list of qd per key on the map and check for current connection id while removing Signed-off-by: Harshit Gangal <harshit@planetscale.com> * added additional comments Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Harshit Gangal <harshit@planetscale.com>
…ease-15.0 [release-15.0] fix: reserve connection to follow query timeout when outside of transaction (vitessio#11490)
* feat: added test for vtorc not being able to handle mutliple failures and fix it Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix code to delete rdonly tablet from the correct list Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>
* Adding deprecate message to backup hooks Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding markdeprecated Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing deprecation message Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing messaging Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix flag name Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>
* removing unncessary flags across binaries Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code review feedback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing blank space Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
[15.0] Fix query list override issue on mysql restart (vitessio#11309)
* remove excessive logging Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
…io#11493) * Move CI to mysql80 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * moving to apt-config 8.2 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>
I accidentally stumbled over the behavior outlined in `flag.PrintDefaults` [1], which `pflag` replicates, specifically: > The listed type, here int, can be changed by placing a back-quoted > name in the flag's usage string; the first such item in the message is > taken to be a parameter name to show in the message and the back quotes > are stripped from the message when displayed. [1]: https://pkg.go.dev/flag#PrintDefaults. Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>
…th transaction (vitessio#11527) * fix: stream exec once in case of transactional connection Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * generate ci worflow Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* Skip recalculating the rate in MaxReplicationLagModule when it can't be done (vitessio#12620) * Skip recalculating the rate in MaxReplicationLagModule when it can't be done This defends against lag records with nil stats which can lead to segfaults. See vitessio#12619 Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Throttled transactions return MySQL error code 1041 ER_OUT_OF_RESOURCES (vitessio#12949) This error code seems better suited to represent the fact that transactions are being throttled by the server due to some form of resource contention than the current code 1203 ER_TOO_MANY_USER_CONNECTIONS. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * MaxReplicationLagModule.recalculateRate no longer fills the log (vitessio#14875) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
* Fallback to poller replication lag if heartbeat lag fails * Try to make CI pipeline happy * Address PR comments * Fix typo --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>
* bugfix: fix nil pointer in vtgate on topo connection error (vitessio#13010) * fix nil pointer in vtgate on topo connection error Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * add test Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * fix year Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> --------- Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com> * VTGate Buffering: Use a more accurate heuristic for determining if we're doing a reshard (vitessio#13856) Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Olga Shestopalova <olgash@mit.edu> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
* add vtgate flag that explicitly allows vstream copy (#125) * fix fs.BoolVar Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * VSCopy: Resume the copy phase consistently from given GTID and lastpk (vitessio#11103) * VSCopy: Demonstrate to fail a test case on which the vstream API is supposed to resume the copy phase consistently Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Resume the copy phase consistently from given GTID and lastpk Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Build out the unit test some more Signed-off-by: Matt Lord <mattalord@gmail.com> * Update tests for new behavior Signed-off-by: Matt Lord <mattalord@gmail.com> * Improve comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Limit uvstreamer changes and update test Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert uvstreamer test changes Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert all uvstream changes Signed-off-by: Matt Lord <mattalord@gmail.com> * VCopy: Revert the last three commits Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VCopy: Add a new vstream type that allows picking up where we left off Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VCopy: Revert the unit test change Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VCopy: Fix the end-to-end CI test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Update logic for setting up uvstreamer based on input vgtid/tablepks. Add more catchup events to test Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Refactor logic to decide if event is to be sent. Enhance unit and e2e tests. Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Don't send events for tables which we can identify as ones we haven't started copy for Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Minor changes after self-review Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Add vstream copy resume to release notes Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * VSCopy: Send COPY_COMPLETED events when the copy operation is done (vitessio#11740) * VSCopy: Demonstrate to fail a test case on which the vstream API sends new events showing copy completed Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Send new events when the copy operation is done Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Fix typo Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Initialize new map for the 'vstream * from' vtgate sql interface. Make vtadmin web protos Signed-off-by: Rohit Nayak <rohit@planetscale.com> * VSCopy: Make TestVStreamCopyBasic fail fast to avoid the end2end timeout out Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: stop sharing the 't1' table among multiple test cases running concurrently Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: refactor the function signature to be clearer Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: refactor the VEvents sorter to be simpler Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: refactor to stop the sorter from including a fully copied event Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * VSCopy: Enable to copy from all shards in either a specified keyspace or all keyspaces (vitessio#11909) * VSCopy: Demonstrate to fail a test case on which the vstream API request doesn't include keyspace and shard Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Copy from all shards in all keyspaces by specifying only an empty gtid Signed-off-by: yoheimuta <yoheimuta@gmail.com> * tests: Make TestRowCount stable regardless of the number of keyspaces Signed-off-by: yoheimuta <yoheimuta@gmail.com> * tests: Cleanup TestCreateAndDropDatabase correctly to stop TestVStreamCopyWithoutKeyspaceShard from failing when running tests together Signed-off-by: yoheimuta <yoheimuta@gmail.com> * tests: Tweak to fix a comment Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: fix the unit tests when the input vgtid with an empty gtid lacks either keyspace or shard Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Keyspace wildcard selection lines up with the table wildcard selection Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Tests the VCopy with multiple keyspaces and resharding Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Make TestVStreamCopyMultiKeyspaceReshard clearer to check if the streaming two keyspaces works even after reshard Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Return an invalid argument error if shards are unspecified and gtid is neither 'current' nor empty Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a test description about its purpose and target Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Remove duplicate literals in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Retain defaultReplicas variable in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Explain why we are setting Match to 'customer.*' in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Remove an unused VStreamFlag for the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Use sentence capitalization in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Verify that we didn't lose any events or get duplicates of the keyspace being reshareded in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Return a value instead of a pointer because there is no need to modify the value Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a comment describing what TestVStreamCopyFromAllKeyspacesAndAllShards is doing and why Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a comment describing why we expect these specific numbers of events from VStream API Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Tweak the test case name Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Make a utility function to sort COPY_COMPLETED events in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Replace the matcher with a simpler one in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Move the print debug call to the FailNow section in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Use require.NoError in new tests Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Use require instead of t.Fatalf in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Apply the reviewer's suggestion to make the error message easier to read Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a comment noting what we're actually testing Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Correct the test comment and elaborate the special-case Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Tweak an error message and a comment Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Adjust to a change in the signature of a test function that was introduced in the main repository Signed-off-by: yoheimuta <yoheimuta@gmail.com> --------- Signed-off-by: yoheimuta <yoheimuta@gmail.com> * attempt unit test fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update test error expected Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: pbibra <pbibra@slack-corp.com> Co-authored-by: yohei yoshimuta <yoheimuta@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>
* `slack-15.0`: basic go.mod updates Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix signature in `go/vt/mysqlctl/azblobbackupstorage/azblob.go` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update expected error for new mysql driver Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * more go.mod updates Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * steal statsd fix from vitessio#11741 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flag e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flag e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flag e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>
* [release-17.0] VReplication: Take replication lag into account in VStreamManager healthcheck result processing (vitessio#15761) (vitessio#15772) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> * fix signature Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>
vmogilev
requested review from
deepthi,
harshit-gangal,
mattlord,
ajm188 and
notfelineit
as code owners
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
vmogilev
requested review from
systay,
shlomi-noach,
arthurschreiber and
derekperkins
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
forward ports slack specific PRS fix from v14 to v15: slackhq#177
Related Issue(s)
Checklist
Deployment Notes