Vm slack 15.0 #16035

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Release notes for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Release commit for 15.0.0-rc1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

vitessio#11448) * feat: call the logic for waiting for shard locks on synchronous on-term hooks and add tests for it Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix comment for acceptSighupSignal function Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

… creation (vitessio#11415) (vitessio#11447) * Testing.... Signed-off-by: Matt Lord <mattalord@gmail.com> * Setup reverse routing rules at the start of the first partial movetables. Enhance e2e test to test for this as well as switch the remaining shard so that all shards are switched Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Update display representation of state for partially moved keyspaces Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Test improvements Signed-off-by: Matt Lord <mattalord@gmail.com> * Cleanup shard routing rules on cancel/complete Signed-off-by: Matt Lord <mattalord@gmail.com> * Cleanup intermediate changes Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix DryRun TrafficSwitcher and its tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Support concurrent partial movetables for N keyspaces And other minor changes after self review Signed-off-by: Matt Lord <mattalord@gmail.com> * Avoid unnecessary save + rebuild steps Signed-off-by: Matt Lord <mattalord@gmail.com> * Add secondary ordering for shard routing rules on to_keyspace Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor changes after self review Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

…e correct binary. (vitessio#11450) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* Use JSON for plan tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * move vschemas into single directory Signed-off-by: Andres Taylor <andres@planetscale.com> * indentation Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: FlorentP <35779988+frouioui@users.noreply.github.com>

…ssio#11469) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

This is to pick up the fix for golang/go#56152. Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…nShard`, `GetFullStatus` (vitessio#11438) (vitessio#11452) * Add validate Signed-off-by: notfelineit <notfelineit@gmail.com> * Add validate to cluster page Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Add UI for validate shard Signed-off-by: notfelineit <notfelineit@gmail.com> * Add validateShard Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make web proto Signed-off-by: notfelineit <notfelineit@gmail.com> * Refactor validation results and implement validateShard Signed-off-by: notfelineit <notfelineit@gmail.com> * add http shards Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetFullStatus Signed-off-by: notfelineit <notfelineit@gmail.com> * Add keys and comment Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Add ValidateVersionShard to vtctldclient Signed-off-by: notfelineit <notfelineit@gmail.com> * Add ValidateVersionShard Signed-off-by: notfelineit <notfelineit@gmail.com> * Update test for vtctldclient Signed-off-by: notfelineit <notfelineit@gmail.com> * Add test for ValidateVersionShard Signed-off-by: notfelineit <notfelineit@gmail.com> * run lint prettier fix again Signed-off-by: notfelineit <notfelineit@gmail.com> * Modify during 1:1 with gomez Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Address PR review comments Signed-off-by: notfelineit <notfelineit@gmail.com> * Update indentation Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Co-authored-by: notfelineit <notfelineit@gmail.com>

* Fix check_make_sizegen Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fail the static_check_etc workflow when a script fails Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove test code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…1483) * feat: add replacer and code to always print semi-sync fields and decode the io and sql state from integers to strings Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: prettify the changed file Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix replication state strings and simplify code Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…action Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Plan order by Count() Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Clean up the new aggregation E2E test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Push more order by needs to the select list Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove unrequired code in TestOrderByCount Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove unwanted directory Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…k overflow (vitessio#11499) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com>

* test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * log txID and reserveID in stream execute Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: maintain list of qd per key on the map and check for current connection id while removing Signed-off-by: Harshit Gangal <harshit@planetscale.com> * added additional comments Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…ease-15.0 [release-15.0] fix: reserve connection to follow query timeout when outside of transaction (vitessio#11490)

* feat: added test for vtorc not being able to handle mutliple failures and fix it Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix code to delete rdonly tablet from the correct list Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* Adding deprecate message to backup hooks Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding markdeprecated Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing deprecation message Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing messaging Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix flag name Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* removing unncessary flags across binaries Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code review feedback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing blank space Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

[15.0] Fix query list override issue on mysql restart (vitessio#11309)

* remove excessive logging Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code feeback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…io#11493) * Move CI to mysql80 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * moving to apt-config 8.2 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

I accidentally stumbled over the behavior outlined in `flag.PrintDefaults` [1], which `pflag` replicates, specifically: > The listed type, here int, can be changed by placing a back-quoted > name in the flag's usage string; the first such item in the message is > taken to be a parameter name to show in the message and the back quotes > are stripped from the message when displayed. [1]: https://pkg.go.dev/flag#PrintDefaults. Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…th transaction (vitessio#11527) * fix: stream exec once in case of transactional connection Signed-off-by: Harshit Gangal <harshit@planetscale.com> * test: added e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * generate ci worflow Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

* Add web side of topology components Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetTopologyPath Signed-off-by: notfelineit <notfelineit@gmail.com> * Add protos Signed-off-by: notfelineit <notfelineit@gmail.com> * Add comment explaining why name is not needed at toplevel topo path Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetTopologyPath to vtadmin Signed-off-by: notfelineit <notfelineit@gmail.com> * Modify node code for non recursive Signed-off-by: notfelineit <notfelineit@gmail.com> * Update logic for GetTopologyPath Signed-off-by: notfelineit <notfelineit@gmail.com> * Render correct depth for nodes Signed-off-by: notfelineit <notfelineit@gmail.com> * Add tests TestGetTopologyPath Signed-off-by: notfelineit <notfelineit@gmail.com> * Add GetTopologyPath command Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> * Consolidate DecodeContent to vt/topo package - can't put in vt/topo/topoproto because of import cycle Signed-off-by: notfelineit <notfelineit@gmail.com> * Add rbac check for TopologyResource Signed-off-by: notfelineit <notfelineit@gmail.com> * Update DecodeContent of zkcmd.go Signed-off-by: notfelineit <notfelineit@gmail.com> * Update help text Signed-off-by: notfelineit <notfelineit@gmail.com> * Run make proto again Signed-off-by: notfelineit <notfelineit@gmail.com> * Run lint prettier fix Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: notfelineit <notfelineit@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…itessio#11528) * Allow version to be accessible via the -v shorthand Signed-off-by: Andrew Mason <andrew@planetscale.com> * update help text Signed-off-by: Andrew Mason <andrew@planetscale.com> * fix nonidempotence for tests Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com>

* feat: fix default for cell flag in vtgate Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: deprecate --enable-query-plan-field-caching and --enable_query_plan_field_caching properly Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: properly deprecate prefill flags Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: properly deprecate filtered_replication_wait_time flag in switch writes Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…gainst unsharded tables (vitessio#11461) (vitessio#11530) * Only perform vindex logic for deletes against sharded keyspaces. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Add a testcase covering deletes on an unsharded reference table. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Check if target keyspace is unsharded instead of checking opcode. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

* test: added failing e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: sequence execution of concate engine when in transaction Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: concatenate fix for olap transaction Signed-off-by: Harshit Gangal <harshit@planetscale.com> * fix: test race Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…sio#11526) * don't rewrite HAVING predicates that use table columns Signed-off-by: Andres Taylor <andres@planetscale.com> * Revert the changes made in vitessio#11306 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix early rewriter test Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: add hyperlink using fqdn in vtgates Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: provide correct vtgate web address in examples Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: fix prettier errors Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

* removing redundant flags across binaries Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding app pool flag back for some binaries Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * running generate_ci on prscomplex.yml Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code review Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing markdeprecated error Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * code feedback Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * doing some minor changes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…hin GoLand and to parse test flags in vtgate to allow running unit tests (vitessio#11551) * Update logic for parsing test flags to run unit tests within GoLand. Parse test flags in vtgate to allow running unit tests Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Minor changes after self-review Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com>

* feat: deprecate initshardprimary Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add summary docs Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: deprecate the correct command Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix expected output Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Instead of relying on a specific version check, detect if the new redo log location is present or not. This makes the backup logic independent from the version check against MySQL. With this change, 8.0.30 can be backed up just as well as any other version. Solves the backup part of vitessio#11554 by removing the dependency on the version check. There might be still other places where that issue can crop up, but it solves the immediate breaking issue with backups. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* feat: add a link to the VTOrc section in the summary doc Signed-off-by: Manan Gupta <manan@planetscale.com> * Fixup summary topics and links Signed-off-by: Matt Lord <mattalord@gmail.com> * Improve vdiff2 entry Signed-off-by: Matt Lord <mattalord@gmail.com> * summary: fix some formatting, organization and wording Signed-off-by: deepthi <deepthi@planetscale.com> * Format the summary with sections and sub-sections and proper order/naming Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Follow the same case for titles in the summary file Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Go from v15.0.0-rc1 to v15.0.0 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update the release summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * adding flag diff file Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding link on release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * separating out each binary flag diff Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * remove old diff file Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix typo Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * rename files Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix summary links Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of proper anchor to all the titles Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: deepthi <deepthi@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* Release notes for 15.0.0 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Release commit for 15.0.0 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* fix anchors for release notes and summary Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * adding # to link Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

* fix vdiff release notes Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fix anchor Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* Mention the --db-config-*-* flag in the release notes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix typo Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * removed unrequired dash in summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

) * feat: fix context of the docker files so that the release-script works as intended Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add release notes instructions Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update the vt_base_version Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix docker-image-version Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…1672) * Do not multiply `AggregateRandom` in `JOIN`s (vitessio#11633) * Do not multiply AggregateRandom in JOIN Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Update the releases notes with new known issue Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of the release notes for v15.0.1 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix format issue in the release notes summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * set sql mode in TestAggregateRandom Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

… active during resharding (vitessio#11640) (vitessio#11652) * VTexplain topology only uses serving shards This addresses isse vitessio#11632 , which causes vtexplain to sometimes give bad results if the keyspace is being resharded, because sometimes it picks source shards and other times target shards, for routing the query. The issue is that the `VTExplain.buildTopolog()` adds both source and destination shards to the map that holds shards per keyspace, when only one of them is actually serving traffic at any point in time. Later on, vtexplain loops over this map. Because looping over the map gives a non-deterministic order, sometimes the results are correct, and sometimes incorrect - that is, sometimes it gives the result of the shard that is serving, and other times, the shard that is not serving. This change ensures that only the serving shards are added to the shards per keyspace map, thus avoiding the incorrect vtexplain. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * This addresses issue vitessio#11632 , which causes vtexplain to sometimes give bad results if the keyspace is being resharded, because sometimes it picks source shards and other times target shards, for routing the query. The issue is that the VTExplain.buildTopolog() adds both source and destination shards to the map that holds shards per keyspace, when only one of them is actually serving traffic at any point in time. Later on, vtexplain loops over this map. Because looping over the map gives a non-deterministic order, sometimes the results are correct, and sometimes incorrect - that is, sometimes it gives the result of the shard that is serving, and other times, the shard that is not serving. This change ensures that only the serving shards are added to the shards per keyspace map, thus avoiding the incorrect vtexplain. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix check_make_vtadmin_authz_testgen Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * empty commit to trigger CI Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…pcs when transaction or reserved connection is acquired (vitessio#11687) * Fix ordering when error happens during stream setup (vitessio#11592) * Fix ordering when error happens during stream setup When we already have an error during the stream setup, that errors needs to be returned immediately. Otherwise the stream will already be started and the error message is never returned to the client and it silently looks like a success even if it's a failure. This in turn can result in an empty result for example when an error would have been expected. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Add a bunch of testing to verify stream execute behavior Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Send errors in stream instead of a grpc error from streaming rpcs when transaction or reserved connection is acquired (vitessio#11656) * wip Signed-off-by: Harshit Gangal <harshit@planetscale.com> * feat: send errors in stream instead of a grpc error from streaming rpcs Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…o#11696) * update jsonparser dependency Signed-off-by: deepthi <deepthi@planetscale.com> * small change to PR template Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: deepthi <deepthi@planetscale.com>

…o#11676) * Use go1.19.3 in the upgrade/downgrade tests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * revert unwanted changes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * apply go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…o#11691) (vitessio#11693) * improve handling of ORDER BY/HAVING rewriting Fixes vitessio#11641 Signed-off-by: Andres Taylor <andres@planetscale.com> * Go fmt file Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

…sio#11668) (vitessio#11712) * Addition of a CI tool to detect dead links in test/config.json (vitessio#11668) * Addition of a tool to detect unrequireed CI clusters in test/config.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * move mysql80 derived to queries/derived in config.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test: clean the user table as well Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix flakyness in TestDerivedTableWithHaving Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestDerivedAggregationOnRHS Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * apply go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

* Remove launchable in release-15.0 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of a CI tool to detect dead links in test/config.json (vitessio#11668) (vitessio#11712) * Addition of a CI tool to detect dead links in test/config.json (vitessio#11668) * Addition of a tool to detect unrequireed CI clusters in test/config.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * move mysql80 derived to queries/derived in config.json Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test: clean the user table as well Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix flakyness in TestDerivedTableWithHaving Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestDerivedAggregationOnRHS Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * apply go mod tidy Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…` instead of `StringSlice` (vitessio#11790) (vitessio#11801) * Switch ApplySchema `--sql` argument to be `StringArray` instead of `StringSlice` Fixes vitessio#11785. See [this comment](vitessio#11785 (comment)) for an explanation. Signed-off-by: Andrew Mason <andrew@planetscale.com> * add endtoend test Signed-off-by: Andrew Mason <andrew@planetscale.com> Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…cript (vitessio#11816) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* test go.sum modification Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test filter with different go.mod and go.sum rules Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * use different filters for go.mod and go.sum everywhere Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * clean up go.sum Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

On MariaDB, it's possible that an OK packet has `SERVER_SESSION_STATE_CHANGED` set to true, but it has no additional state change information as the end of the packet is reached. We should not treat this as an error condition and treat this as a proper OK packet. Fixes vitessio#11795 Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

… package (vitessio#11787) (vitessio#11792) * Update test runners to run all tests including outside package Sometimes it's necessary to have a separate _test package inside another package. Our current test runner doesn't run such tests though, leading to tests being broken without us knowing. Worst case it hides real bugs. So we should always ensure to also run these tests as well. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix tests Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

… (vitessio#11832) * codeowners: have at least two for almost every package Signed-off-by: deepthi <deepthi@planetscale.com> * codeowners: add release team to /doc/ Signed-off-by: deepthi <deepthi@planetscale.com> * Add rohit to relevant packages with single codeowner Signed-off-by: Rohit Nayak <rohit@planetscale.com> * codeowners: fix vttablet packages that had none Signed-off-by: deepthi <deepthi@planetscale.com> * added harshit to vttabet/grpc package Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…sio#11487) (vitessio#11834) Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* make sure planner works well with more than 64 tables Signed-off-by: Andres Taylor <andres@planetscale.com> * semantics: use an immutable bitset Signed-off-by: Vicent Marti <vmg@strn.cat> * bitset: add documentation Signed-off-by: Vicent Marti <vmg@strn.cat> * bitset: add license Signed-off-by: Vicent Marti <vmg@strn.cat> * use IsEmpty and NonEmpty more Signed-off-by: Andres Taylor <andres@planetscale.com> * rename file Signed-off-by: Andres Taylor <andres@planetscale.com> * bitset: better documentation Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Co-authored-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Vicent Marti <vmg@strn.cat> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Vicent Martí <42793+vmg@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

* Release notes for 15.0.1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Release commit for 15.0.1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…ssio#11860) * updating summary and release notes for v15.0.1 Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * fixing typos Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> Co-authored-by: Rameez Sajwani <rameezwazirali@hotmail.com>

The `set-output` command is deprecated and will break in the future. This moves to the new style for all our GitHub Actions. See also https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>

…vitessio#11900) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

* upgrade to go1.19.4 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * apply gofmt Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * regen proto Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * use go1.18.4 and bootstrap 11.2 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix go.mod Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * re gen proto Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…o#11924) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

… server side error (vitessio#11930) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…be handled correctly (vitessio#11911) (vitessio#11922) * bugfix: allow predicates on top of derived tables to be handled without dependencies Signed-off-by: Andres Taylor <andres@planetscale.com> * stop normalizer from changing literals into bindvars Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

…vitessio#11768) (vitessio#11943) * Prevent orphaned VDiffs in two ways... 1. When opening the engine, restart any vdiffs that are in the started state as this indicates it did not complete and was unable to save the final state and must be restarted. 2. When a vdiff run fails, retry saving the error state with an exponential backoff until the engine shuts down. This way the normal retry mechanism will kick in OR #1 will kick in when the engine is next opened on the primary tablet. Signed-off-by: Matt Lord <mattalord@gmail.com> * Handle failures before vdiff_table records are created Signed-off-by: Matt Lord <mattalord@gmail.com> * Add more ephemeral client errors Signed-off-by: Matt Lord <mattalord@gmail.com> * Show vdiff state of error even if no vdiff_table records Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Add vdiff2 unit tests Signed-off-by: Matt Lord <mattalord@gmail.com> * Add unit test for retry Signed-off-by: Matt Lord <mattalord@gmail.com> * Small cleanup Signed-off-by: Matt Lord <mattalord@gmail.com> * Addressing review comments and other improvements Signed-off-by: Matt Lord <mattalord@gmail.com> * Use warning log for ... warnings :-) Signed-off-by: Matt Lord <mattalord@gmail.com> * Minor touch ups Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com>

) (vitessio#11951) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…itessio#12038) * feat: fix rbac config in the operator example Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix clusters value too Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* increase the timeout to build binaries in codeql workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test codeql workflow on pr Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of Slack Workflow Notification Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of if condition to send slack message Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fail if needed Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * clean up codeql workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com>

Release of v15.0.2

* CI: remove pitrtls test Signed-off-by: deepthi <deepthi@planetscale.com> * feat: update onclose timeout to 10 seconds Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> * test: fix unit test Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix flaky test by not checking for an error Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: handle the case of empty hostname in tablet initialization Signed-off-by: Manan Gupta <manan@planetscale.com> * CI: don't run backup_transform tests during upgrade/downgrade because it has been removed in v16 Signed-off-by: deepthi <deepthi@planetscale.com> * flaky test fix - use new flag in v15 Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: deepthi <deepthi@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

* feat: add failing parsing test and fix parser Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add e2e tests for interval with math functions Signed-off-by: Manan Gupta <manan@planetscale.com> * test: explictly set the time-zone to prevent failures in CI Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

…upported (vitessio#12111) (vitessio#12117) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

* feat: remove enable_semi_sync and workflow flags from v16+ Signed-off-by: Manan Gupta <manan@planetscale.com> * test: also fix test for ers initialization Signed-off-by: Manan Gupta <manan@planetscale.com> * tests: remove workflow manager flags entirely Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…n Sync With Authoritative Map on Tablet Delete (vitessio#12178) (vitessio#12193) * Ensure secondary maps stay in sync with authoritative map on delete Signed-off-by: Matt Lord <mattalord@gmail.com> * Remove all possible entries for a tablet alias in secondary maps Signed-off-by: Matt Lord <mattalord@gmail.com> * Add unit test case Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

…itessio#12172) (vitessio#12230) * test: show that `autocommit` on lookup vindexes is broken when used after a savepoint is created Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * test: rework the test case to show that the problem lies with transactions Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Correctly handle `autocommit` in the `VIndexLookup` primitive. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> * Copy the `logging` struct so autocommit queries show up correctly in `vexplain` output. Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> --------- Signed-off-by: Arthur Schreiber <arthurschreiber@github.com> Co-authored-by: Arthur Schreiber <arthurschreiber@github.com>

* Move vtorc from go-sqlite3 to modernc.org/sqlite (vitessio#12214) * Move vtorc from go-sqlite3 to modernc.org/sqlite This moves vtorc from the go-sqlite3 library that uses CGO, to use modernc.org/sqlite which is a pure Go implementation. vtorc is the only component we have to build with CGO but it's causing pain for releases since we need to build it against an old Linux for linking against glibc. Using modernc.org/sqlite allows for using Go only again and makes all Vitess components buildable without CGO. In https://datastation.multiprocess.io/blog/2022-05-12-sqlite-in-go-with-and-without-cgo.html someone ran some basic benchmarks. It shows that the pure Go version can be twice as slow, but the usage of vtorc is very limited and we operate on small datasets, so I think the performance impact purely of a somewhat slower sqlite implementation is negligable. None of this is in a hot query serving path or anything like that, so I have little concern performance wise. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix error handling in RowToArray Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * empty-commit Signed-off-by: Manan Gupta <manan@planetscale.com> * Run go mod tidy Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* fix: aggregation coming from right hand side of left join check for null * test: added a sum test * addressed review comments --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…cessary GetTablet calls to topo (vitessio#12194) (vitessio#12244) * check filter later in loadTablets. Add tests to confirm expected behavior * remove unnecessary assignment * add some explanation around TestFilterByKeypsaceSkipsIgnoredTablets * simplify filter check logic as well as major test cleanup, using testify where possible --------- Signed-off-by: Brian Ramos <brirams@users.noreply.github.com> Co-authored-by: Brian Ramos <brirams@users.noreply.github.com>

* adding check for v16 for upgrade/downgrade backup tests Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * removing TestReparentDoesntHangIfPrimaryFails Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * Removing keep-data from upgrade/downgrade workflow Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> * setting -keep-data=false in workflows Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com> --------- Signed-off-by: Rameez Sajwani <rameezwazirali@hotmail.com>

…io#12468) (vitessio#12472) * fix: scalar aggregation truncation * test: added scalar aggr engine unit test * remove onecase change --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…itessio#12387) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…al table (vitessio#12484) (vitessio#12492) * BugFix: Unsharded query using a derived table and a dual table (vitessio#12484) * test: add failing test for a query in an unsharded keyspace using a derived table and reference table Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix logic to check if a single unsharded keyspace is used Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix test output Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove test files Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…nd (vitessio#12481) (vitessio#12531) * Add a Run func to `vtctldclient`'s Root command to return an error on unknown command Closes vitessio#12480. * Add test * flags test data --------- Signed-off-by: Andrew Mason <andrew@planetscale.com>

* [planner] Schema information on the information_schema views (vitessio#11941) * add info_schema information Signed-off-by: Andres Taylor <andres@planetscale.com> * add SchemaInformation handling for info_schema tables Signed-off-by: Andres Taylor <andres@planetscale.com> * fix bad test query Signed-off-by: Andres Taylor <andres@planetscale.com> * add support for information_schema on mysql 5.7 Signed-off-by: Andres Taylor <andres@planetscale.com> * columns sorted just like mysql, and tests for 5.7 Signed-off-by: Andres Taylor <andres@planetscale.com> * test: skip test that should not run Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix for USING when column names not lower cased (vitessio#12379) Signed-off-by: Andres Taylor <andres@planetscale.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com>

* Block merge if the `Do Not Merge` label is set (vitessio#12489) * Block Merge if the label is set Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix echo syntax Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Improve release process post `v16.0.0 GA` code freeze (vitessio#12487) * Update the release instructions document with pre-requisites for release team Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Add Do Not Merge to release Pull Request upon creation Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix typo Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…io#12562) * collations: fix sorting in UCA900 collations When using the fast iterator to _compare_ two strings with an UCA collation, we need to keep in mind that the weights in the collation are in BIG ENDIAN (this is the output format for the weight strings, so we store the weights this way), so comparing them directly will not result in the proper collation order. They need to be byte-swapped before they can be compared with an arithmetic operation! * collations: comment --------- Signed-off-by: Vicent Marti <vmg@strn.cat>

* handle filter on top of UNION Signed-off-by: Andres Taylor <andres@planetscale.com> * fix: conflict Signed-off-by: Harshit Gangal <harshit@planetscale.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…runners (vitessio#12583) (vitessio#12587) * CI: extend timeouts in onlineddl_vrepl due to slow CI runners Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * increase even further Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

* Purge logs without panicking * Purge logs without panicking * try moving the goroutine to the func itself --------- Signed-off-by: Andrew Mason <andrew@planetscale.com>

…ameters (vitessio#12614) (vitessio#12629) * fix type conversion in query.go for the bitMap size * enhance the TestHighNumberOfParams test * fix test comment --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…ma (vitessio#12641) (vitessio#12665) * Mysqld.GetSchema: tolerate tables being dropped while inspecting schema * lack of primary key columns in STATISTICS does not mean table is dropped. It can also mean the table does not have PRIMARY KEY * populate validTds rather than rely on nil hints * re-introdce earlier check * use validTds, sync * due to many tests consistently failing, trying a different approach: we keep the table, but with empty column/key/fields info * grammar --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…og` (vitessio#12566) (vitessio#12659) * Re-organize the `releasenotes` directory into `changelog` (vitessio#12566) * Move all release related documents to ./release and add tool to generate READMEs Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Addition of the release.go file Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * simplify release.go Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * generate the release notes in the proper place Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * modify previous mentions of docs/releasenotes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * re-add v17.0.0 summary Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add new release tool to release instruction and ci Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * apply review suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * simplify release notes document path Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestions and fix team files Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update the changelog dir and release_notes_label workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…le (vitessio#12607) (vitessio#12647) * [gen4 planner] Make sure to not push down expressions when not possible (vitessio#12607) * Fix random aggregation to not select Null column * stop pushing down projections that should be evaluated at the vtgate level * undo changes to AggregateRandom * clean up code * fix executor test mock Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix schema error Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

…tessio#12534) (vitessio#12692) * feat: fix initialization code to also stop replication * feat: fix tests expectations * feat: fix wrangler tests --------- Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…#12699) * [planner bugfix] add expressions to HAVING When a predicate contains aggregation, it should not be added to the WHERE clause. It should go to the * update test expecteations --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

@mattlord

…ssio#12708) * Auto upgrade the Golang version (vitessio#12585) * initial addition of the go_upgrade tool to detect and bump the golang version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update go.mod automatically Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix isSameMajor version issue Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update the bootstrap version automatically Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update the bootstrap docker image changelog Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * uncomment code Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * addition of base to create-pull-request Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test create PR alternative Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add flags and getter methods Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * better PR message Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix no-workflow-update flag and better PR body msg Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix PR title, branch and body format Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test matrix and pwd path Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * enhanced matrix Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update_workflows option Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * update workflows independently Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * test without matrix Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Add docs to go_upgrade and re-add matrix to the workflow Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * support major version upgrade Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * do not update bootstrap version if they are the same Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * migrate to cobra instead of pflags Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove redundant comment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * safety net around replaceGoVersionInCodebase to avoid unrequired upgrade Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Remove double negation in workflowUpdate flag Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Use regexp instead of mere string comparison Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Proper regexp for every string comparison Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * use better regex Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove useless flag and improve the auto-PR body description Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add note in the tool usage to run the tool at the root of the repo Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * add comment in .github/workflows/update_golang_version.yml Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply @mattlord code suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * replace usages of old filename Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply suggestions from code review Co-authored-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> * Fix regexp Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove the use of DateOnly Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

…er timeout (vitessio#12114) (vitessio#12302) * Retry error if it happens after timeout Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Address review comments Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Address review comments Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Improve unit tests Signed-off-by: Rohit Nayak <rohit@planetscale.com> --------- Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com> Co-authored-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com>

…g table schema (vitessio#12263) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…itessio#12704) (vitessio#12726) Signed-off-by: Andres Taylor <andres@planetscale.com>

…ce=innodb_system are included in the schema (vitessio#12672) (vitessio#12734) * Use a left join to make sure that tables with tablespace=innodb_system are not skipped when loading the schema (fixes vitessio#12669) Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com> * Set tablespace on a test table to see if it breaks vstreamer Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com> --------- Signed-off-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com> Co-authored-by: Oleksiy Kovyrin <oleksiy.kovyrin@shopify.com>

…sio#12683) (vitessio#12744) * Reset the current lag when closing the replication lag reader. * Fix tests. --------- Signed-off-by: Johan Stenberg <johanstenberg92@github.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Johan Stenberg <johanstenberg92@github.com>

…itessio#12747) Signed-off-by: Hormoz Kheradmand <hormoz.kheradmand@shopify.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Hormoz Kheradmand <hkdsun@users.noreply.github.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

* Release notes for 15.0.3 Signed-off-by: Matt Lord <mattalord@gmail.com> * Release commit for 15.0.3 Signed-off-by: Matt Lord <mattalord@gmail.com> * Rename directory Signed-off-by: Matt Lord <mattalord@gmail.com> * Update changelog/15.0/15.0.3/release_notes.md Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

Signed-off-by: Matt Lord <mattalord@gmail.com>

…12779) * fix: reset transaction session with better checks when no reserved connection Signed-off-by: Harshit Gangal <harshit@planetscale.com> * add to ci run Signed-off-by: Harshit Gangal <harshit@planetscale.com> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…tessio#12769) (vitessio#12795) * Fix incorrect path during release notes generation Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply review suggestion Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…12774) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…essio#12806) * Automatically add milestone to new Pull Request * Run the workflow on pull_request_target event * Use gh pr edit to add milestone * Use bash instead of go script --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…2821) We have tests like `TestMoveTablesV2` which end up reading and writing queries concurrently. This causes the race detector to appropriately trigger and detect issues here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

…tessio#12810) (vitessio#12824) * fixes vitessio#12798 * [planbuilder bugfix] don't push down predicates that need to be aggregated at the vtgate level --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Andres Taylor <andres@planetscale.com>

)

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…12838) (vitessio#12847) * fix float issue with bootstrap version increment Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * handle case where there are no minor bootstrap version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * avoid re-creating Pull Requests Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove parse float Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

…itessio#12853) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…de a subquery (vitessio#12890) * planner fix: scoping rules for JOIN ON expression inside a subquery (vitessio#12881) * fix: scoping rules for on clause expression inside a subquery Signed-off-by: Harshit Gangal <harshit@planetscale.com> * find the parent scope of the statement in on clause Signed-off-by: harshit-gangal <harshit@planetscale.com> * addressed review comments Signed-off-by: harshit-gangal <harshit@planetscale.com> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: harshit-gangal <harshit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix plan test expectation for v3 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Signed-off-by: harshit-gangal <harshit@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…o#12982) Signed-off-by: Harshit Gangal <harshit@planetscale.com>

…itessio#13035) Signed-off-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…initialization (vitessio#13080) (vitessio#13086) * feat: fix the resilient query code to work better right after it has started Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: return after erroring out in TimeoutAction Signed-off-by: Manan Gupta <manan@planetscale.com> --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

…ction ID on error (vitessio#13193) (vitessio#13196) * ReserveBeginExecute to return transaction id even if reserver id is not present when there is an error Signed-off-by: Harshit Gangal <harshit@planetscale.com> * enabled settings pool for e2e test Signed-off-by: Harshit Gangal <harshit@planetscale.com> --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

* test: add health-streamer test * feat: fix test * feat: fix health streamer * feat: fix health streamer tests --------- Signed-off-by: Manan Gupta <manan@planetscale.com>

Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

) (vitessio#13167)

…essio#13125) Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

… with a flag (vitessio#13315) * Set the number of threads for release notes generation with a flag (vitessio#13273) * Set the number of threads for release notes generation by a flag Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Add the flag to the release instructions and remove the make commande for release notes Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * remove os.Exit (vitessio#13310) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr>

…ation source (vitessio#13377) (vitessio#13393)

…13396) (vitessio#13403) Signed-off-by: Manan Gupta <manan@planetscale.com>

…essio#13375) (vitessio#13388) * BaseShowTablesWithSizes: optimize MySQL 8.0 query Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * adapt regular expression Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * adapt regular expression, 2 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * refactored query again to combat the many unit test query format assumptions Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * use t.table_schema in GROUP BY. Although not strictly necessary this may be faster Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Support views in BaseShowTablesWithSizes for MySQL 8.0 (vitessio#13394) * Support views in BaseShowTablesWithSizes for MySQL 8.0 Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * added test Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * fixed test Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * schema tracker: use null safe comparison Signed-off-by: Andres Taylor <andres@planetscale.com> --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Andres Taylor <andres@planetscale.com> * BaseShowTables Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> --------- Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…io#13421) (vitessio#13425) * ignore views load error * added unit test --------- Signed-off-by: Harshit Gangal <harshit@planetscale.com>

Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

vitessio#13463)

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

…ease-15.0 [release-15.0] `examples/compose`: fix `consul:latest` error w/`docker-compose up -d` (vitessio#13468)

…itessio#13469) (vitessio#13502) Fix `TestGatewayBufferingWhileReparenting` flakiness (vitessio#13469)

…io#13529) Signed-off-by: Manan Gupta <manan@planetscale.com>

…ssio#13570) Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…13590) (vitessio#13592) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…ones (vitessio#13398) (vitessio#13620)

Signed-off-by: Matt Lord <mattalord@gmail.com>

…sue (vitessio#13735) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…essio#13807) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com>

vitessio#13813) (vitessio#13818) Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…from schema tracker (vitessio#13673) (vitessio#13794) Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…postpone-completion strategy flag (vitessio#13832) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Deepthi Sigireddi <deepthi.sigireddi@gmail.com> Co-authored-by: Andrew Mason <amason@hey.com>

… migrations (vitessio#13928) (vitessio#13935) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

…` folder is out-of-date (vitessio#14003) (vitessio#14004) Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

…mode execution (vitessio#14012) (vitessio#14014) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…itessio#14025) Signed-off-by: Harshit Gangal <harshit@planetscale.com> Co-authored-by: Harshit Gangal <harshit@planetscale.com>

…ort `--retain-artifacts=<duration>` DDL strategy flag (vitessio#14029) (vitessio#14035) Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

… all semi sync actions (vitessio#13075) (vitessio#13957) Co-authored-by: William Lu <william@tamedfox.ca>

…frontmatter (vitessio#14056) (vitessio#14072) Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…itessio#14104) Signed-off-by: Andrew Mason <andrew@planetscale.com> Co-authored-by: Andrew Mason <andrew@planetscale.com>

…re way (vitessio#14119) (vitessio#14120) Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

…own within CI (vitessio#13793) (vitessio#14118) Co-authored-by: Matt Lord <mattalord@gmail.com>

…14093) (vitessio#14115) Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

Signed-off-by: Manan Gupta <manan@planetscale.com>

…vitessio#14145) Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>

…ces (vitessio#13654) (vitessio#14009) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Brendan Dougherty <brendan.dougherty@shopify.com> Signed-off-by: Austen Lacy <austen.lacy@shopify.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Brendan Dougherty <brendan.dougherty@shopify.com> Co-authored-by: Austen Lacy <austen.lacy@shopify.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

* `slack-vitess-r15.0.4`: setup CI jobs and CODEOWNERS * Run test on larger runner --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* make column resolution closer to mysql Signed-off-by: Andres Taylor <andres@planetscale.com> * Fix auto-merge-conflict resolution problem Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update expected plan in aggr_cases.json Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Andres Taylor <andres@planetscale.com>

* `slack-vitess-r15.0.5`: update `CODEOWNERS` and go runtime Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update MySQL apt package and GPG signature (vitessio#14785) Signed-off-by: Matt Lord <mattalord@gmail.com> * gofmt complaint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make sizegen Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update docker/bootstrap/Dockerfile.common Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use go1.20.14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make sizegen Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert to go1.18 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make proto again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

…izations (#227) * Load `--grpc_auth_static_client_creds` file once (vitessio#15030) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Filter by keyspace earlier in `tabletgateway`s `WaitForTablets(...)` (vitessio#15347) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Limit concurrent creation of healthcheck gRPC connections (vitessio#15053) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update MySQL apt package and GPG signature (vitessio#14785) Signed-off-by: Matt Lord <mattalord@gmail.com> * remove unrelated workflow files from v20 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

* go1.20.14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * more go-version: updates Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make proto w/go1.20 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix the golangci-lint config (vitessio#11812) There's a bunch of deprecated linters that don't work anymore, so let's remove them: ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * update golangci-lint to 1.50.1 (vitessio#11873) Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add timeout to golangci-lint and bump its version (vitessio#12852) (vitessio#12853) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Upgrade `release-16.0` to `go1.20.1` (vitessio#12398) * Upgrade release-16.0 to go1.19.6 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * upgrade to 1.20.1 Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * bump the golangci-lint version Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply linter suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Apply linter suggestions Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * fix TestTLSClientVerifyIdentity Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Switch to using new Go 1.19 CRL parser (vitessio#12315) `x509.ParseCRL` is deprecated, we should use `x509.ParseRevocationList` instead which is new in Go 1.19. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Skip TestFuzz for now Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> --------- Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> * Remove recent golangci-lint version bump (vitessio#12909) Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> * Fix conflict resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make ensure_bootstrap_version Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * hardcode previous release Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add comment for hardcoded previous release Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Andres Taylor <andres@planetscale.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Andres Taylor <andres@planetscale.com> Co-authored-by: Florent Poinsard <35779988+frouioui@users.noreply.github.com>

#256) * Pass BUILD_GIT_BRANCH and BUILD_GIT_REV env into docker build * Fix bootstrap version * Fix bootstrap version, again * Fix ws Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Florent Poinsard <florent.poinsard@outlook.fr> Co-authored-by: Florent Poinsard <florent.poinsard@outlook.fr>

… (#270) * Add structure logging to Vitess (vitessio#11960) * Create a function to replace glog with PlanetScale log Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Add test case for replacing glog Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Remove one test Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Add flag for PS Logger usage Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Update the usage test files and replace _ with - for the flag Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Apply code review comments Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Add copyrights and release notes Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Update the year in the copyrights Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Fix typo Signed-off-by: Emad Habib <ehabib@slack-corp.com> * Empty Commit Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Emad Habib <ehabib@slack-corp.com> * github.com/planetscale/log v0.0.0-20221118170849-fb599bc35c50 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy after rebase Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Emad Habib <ehabib@slack-corp.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Emad Mokhtar Elsayed Habib <emad.m.habib@gmail.com>

* backport pr 29 * fix missing variable * fix missing patch * update help text Co-authored-by: Tanjin Xu <109303790+tanjinx@users.noreply.github.com>

* `slack-vitess-r14.0.5`: allow conn overrides in consul topo (#111) * `slack-vitess-r14.0.5`: allow conn overrides in consul topo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix e2e test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update flags tests that didn't exist in v14 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Add basic metrics to `vttablet` transaction throttler (vitessio#12418) * Add basic stats to vttablet tx throttler Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * test new metrics Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * reorder Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * short names Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add max rate Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move NewGaugeFunc to under conditional Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use env Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Remove env from TxThrottler struct Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * PR suggestion Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix unit test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * reorder test vars Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix transaction throttler ignoring the initial rate (vitessio#12618) * Fix transaction throttler ignoring the initial rate This addresses the issue reported in vitessio#12549 Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Add missing override of max replication lag in `throttler.newThrottler()` Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Reorder functions to make diff easier to read Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix check for maxRate in `newThrottlerFromConfig()` Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix some CI pipeline issues Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comment. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix typo Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> * Cleanup panics in `txthrottler`, reorder for readability (vitessio#12901) * Cleanup tx_throttler.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Cleanup tx_throttler.go #2 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix throttlerFactoryFunc Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Undo if-cond consolidation Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Undo struct shuffling Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * prove that disabled config returns nil error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Improve test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Emit per workload labels for existing per table vttablet metrics (vitessio#12394) * Emit per workload labels for existing per table vttablet metrics This adds the possibility to configure vttablet (via CLI flag) to also have a workload label for existing per table metrics (query counts, query times, query errors, query rows affected, query rows returned, query error counts). Workload can be any string that makes sense for the client application. For example, API endpoint name, controller, batch job name, application name or something else. This is usefult to be able to gain observability about how the query load is distributed across different workloads. This is achieved with two new CLI flags, namely: * `enable-per-workload-table-metrics`: whether to enable or disable per workload metric collection - disabled by default to preserve the current behavior, thus making the new feature opt-in only. * `workload-label`: a string to look for in query comments to identify the workload running the current query. The workload is obtained by parsing query comments of the form: /* ... <workload_label>=<workload_name>; ... */ For example, if vttablet is started with `--enable-per-workload-table-metrics --workload-label app_name` anda query is issued with a comment like /* ... app_name=shop; ... */ then metrics will look like ``` vttablet_query_counts{plan="Select",table="dual", workload="shop"} 15479 ``` instead of ``` vttablet_query_counts{plan="Select",table="dual"} 15479 ``` Query comment parsing only takes place if `--enable-per-workload-table-metrics` is used, as to not incur parsing performance impact if the user does not want per workload metrics. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * fix flags e2e test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments: * Obtain workload information on the vtgate instead of the vttablet, avoiding double parsing. * Treat workload name as a query directive. * Send workload name from vtgate to vttablet as ExecuteOptions. Additionally, annotate tabletserver's execution span with the workload name to also enrich traces with workload name data, in addition to metrics. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * A few fixes: 1. Rebuild some files with `make proto`. 2. Protect against nil ExecuteOptions on the tabletserver. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix flags e2e test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fixes Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix a comment Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix e2e flag test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Update JS code for protobuf changes. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix QueryEngine unit test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix e2e flag test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix spurious tab in comment Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comment Don't use dual format flag for new flags - stick with - separated ones. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * remove mistaken git add Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make vtadmin_web_proto_types Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * test unit_race test on go-version: 1.18.9 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert "test unit_race test on go-version: 1.18.9" This reverts commit 922e897. * CI: Misc test improvements to limit failures with various runners (vitessio#13825) Signed-off-by: Matt Lord <mattalord@gmail.com> * Fix setup order to avoid races (vitessio#13871) Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

* `slack-vitess-r15.0.5`: revert CI PR vitessio#10768 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * rm .github/workflows/release_notes_label.yml Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* VTOrc running PRS when database_instance empty bug fix. (vitessio#12019) * feat: convert join with database_instance to a left join and prevent fixes from running if the information from database_instance is unavailable Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add tests to verify the fix works Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * Timeout Fixes and VTOrc Improvement (vitessio#11881) * refactor: move tests out of newfeaturestest so that they run on upgrade-downgrade tests too Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add failing ers test for handling multiple vttablet failures with default values of flags Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add a new lock-timeout flag and use that instead of remote-operation-timeout Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: augment DownPrimary test to reproduce the issue of VTOrc not handling multiple failures Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove LockShardTimeout configuration from VTOrc and add parallelism to refresh of tablets Signed-off-by: Manan Gupta <manan@planetscale.com> * log: add more logging lines around ers in vtorc Signed-off-by: Manan Gupta <manan@planetscale.com> * test: get the test to work Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix usage of wait for replicas timeout Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix flags expected output Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix race in test now that the function is called in parallel multiple times Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix default of onCloseTimeout to 1 second Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add failing unit test to refreshTabletsInKeyspaceShard Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix vtorc to not forget a tablet which has been deleted Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix backward compatibility, add tests and release notes docs Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix flags output Signed-off-by: Manan Gupta <manan@planetscale.com> * test: use disable-replication-manager instead of disable-active-reparents to allow vttablets to setup replication when restarted Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix flaky test by not checking for an error Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: handle the case of empty hostname in tablet initialization Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: update onclose timeout to 10 seconds Signed-off-by: Manan Gupta <manan@planetscale.com> * test: fix unit test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: address review comments Signed-off-by: Manan Gupta <manan@planetscale.com> * docs: add comments explaining the test functions Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add summary docs for 'lock-shard-timeout' deprecation Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * log: also log error in DiscoverInstance when force discovery is specified (vitessio#11936) Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * VTOrc Code Cleanup - generate_base, replace cluster_name with keyspace and shard. (vitessio#12012) * feat: refactor generate commands of VTOrc to be in a single file Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: cleanup create table formatting Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: cleanup the usage of IsSQLite and IsMySQL Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove unused minimal instance Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove unused table cluster_domain_name Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix vtorc database to store keyspace and shard instead of cluster Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove unused attributes Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove unused cluster domain Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: change GetClusterName to GetKeyspaceAndShardName Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix insertion into database_instance Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix SnapshotTopologies Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove inject unseen primary and inject seed Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove ClusterName from Instance Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix Audit operations Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add Keyspace and Shard to cluster information to replace ClusterName Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix attempt failure detection registeration Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix blocked topology recoveries Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix topology recovery Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: reading recovery instances Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix get replication and analysis Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix bug in query Signed-off-by: Manan Gupta <manan@planetscale.com> * test: add tests to check that filtering by keyspace works for APIs Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: remove remaining usages of ClusterName Signed-off-by: Manan Gupta <manan@planetscale.com> * refactor: fix comment explaining sleep in the test Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: add code to prevent filtering just by shard and add tests for it Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * Fix insert query of blocked_recovery table in VTOrc (vitessio#12091) * feat: add failing test and fix the query of insertion Signed-off-by: Manan Gupta <manan@planetscale.com> * empty-commit Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * Fix: VTOrc forgetting old instances (vitessio#12089) * test: add a failing test for the case where the port changes for a tablet Signed-off-by: Manan Gupta <manan@planetscale.com> * feat: fix the issue by adding alias as a unique field Signed-off-by: Manan Gupta <manan@planetscale.com> * empty-commit Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Manan Gupta <manan@planetscale.com> * Move vtorc from go-sqlite3 to modernc.org/sqlite (vitessio#12214) * Move vtorc from go-sqlite3 to modernc.org/sqlite This moves vtorc from the go-sqlite3 library that uses CGO, to use modernc.org/sqlite which is a pure Go implementation. vtorc is the only component we have to build with CGO but it's causing pain for releases since we need to build it against an old Linux for linking against glibc. Using modernc.org/sqlite allows for using Go only again and makes all Vitess components buildable without CGO. In https://datastation.multiprocess.io/blog/2022-05-12-sqlite-in-go-with-and-without-cgo.html someone ran some basic benchmarks. It shows that the pure Go version can be twice as slow, but the usage of vtorc is very limited and we operate on small datasets, so I think the performance impact purely of a somewhat slower sqlite implementation is negligable. None of this is in a hot query serving path or anything like that, so I have little concern performance wise. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Fix error handling in RowToArray Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> --------- Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * see if CI passes on v14.0.5 as previous release Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert "see if CI passes on v14.0.5 as previous release" This reverts commit 53a0e0c. --------- Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Manan Gupta <35839558+GuptaManan100@users.noreply.github.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

…pt. 2 (#350) * Add priority support to transaction throttler (vitessio#12662) * Add support for criticality query directive, and have TxThrottler respect that Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Remove unused variable Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix CI pipeline Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy & add extra test cases. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix circular import Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments: * Invalid criticality in query directive fails the query. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments: * Renamed criticality to priority. * Change error handling when parsing the priority from string to integer. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Add missing piece of code that got lost during merge conflict resolution Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix vtadmin.js Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix unit tests (I think) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Invert polarity of priority values With this change, queries with PRIORITY=0 never get throttled, whereas those with PRIORITY=100 always do (provided there is contention). Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix flag e2e test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Add flag to select tx throttler tablet type (vitessio#12174) * Add flag to select tx throttler tablet type Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * REPLICA and/or RDONLY only Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update flag help msg Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Lowercase types in help/doc Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Help update Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * No underscores in flag Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix merge Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * PR suggestion, consolidate config logic Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/vt/vttablet/tabletserver/tabletenv/config.go Co-authored-by: Andrew Mason <amason@hey.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use topoproto.TabletTypeListFlag to handle flag Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix unit test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/vt/vttablet/tabletserver/tabletenv/config.go Co-authored-by: Andrew Mason <amason@hey.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * improve test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * pr suggestions Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go fmt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Andrew Mason <amason@hey.com> * txthrottler: further code cleanup (vitessio#12902) * txthrottler: further code cleanup Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix bad merge resolution Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * TxThrottler support for transactions outside BEGIN/COMMIT (vitessio#13040) * TxThrottler support for transactions outside BEGIN/COMMIT This change allows the TxThrottler to throttle requests sent outside of explicit transactions (i.e. explicit BEGIN/COMMIT blocks) when configured to do so via a new config flag. Otherwise, it preserves the current/default behavior of only throttling transactions inside BEGIN/COMMIT. In addition, when this flag is passed, and because the call to throttle is done in a context in which the execution plan is already known, this change uses the plan type to make sure that throttling is triggered only when the query being executed is INSERT/UPDATE/DELETE/LOAD, so that SELECTs and others no longer get throttled unnecessarily, as they do not contribute to increasing replication lag, which is what the TxThrottler aims at controlling. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix e2e flag tests & TxThrottler unit test Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Throttle auto-commit statements in QueryExecutor instead of TxPool This changes where we call the transaction throttler: 1. Statements in `BEGIN/COMMIT` blocks keep being throttled in `TabletServer.begin()`. 2. Additionally, throttling is added in QueryExecutor.execAutocommit() and `QueryExecutor.execAsTransaction()`. We also change things so that throttling in this new case is not opt-in via configuration flag but instead is the new and only behavior. Finally, we remove some previously added changes to example scripts that had been added with the intention of testing and are not part of the PR. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Adds test cases for QueryExecutor.Execute() with TxThrottle throttling To make unit testing simple here, we separated the interface and implementation of the TxThrottle, and simply used a mock implementation of the interface in the tests. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Add note on new TxThrottler behavior in v17 changelog Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Fix PR number in changelog entry for TxThrottler behavior change. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * txthrottler: verify config at vttablet startup, consolidate funcs (vitessio#13115) * txthrottler: verify config at vttablet startup, consolidate funcs Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use explicit dest in prototext.Unmarshal Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use for loop for TestVerifyTxThrottlerConfig Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Cleanup test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix go vet complaint Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add back synonym flag Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update go/vt/vttablet/tabletserver/txthrottler/tx_throttler.go Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Address staticcheck linter error Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * gofumpt Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Andrew Mason <amason@hey.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com>

… reparent CIs (#356)

…pt. 3 + ci fixes (#351) * txthrottler: add metrics for topoWatcher and healthCheckStreamer (vitessio#13153) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Replace deprecated `github.com/golang/mock` with `go.uber.org/mock` (vitessio#13512) Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Per workload TxThrottler metrics (vitessio#13526) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * tx throttler: healthcheck all cells if `--tx-throttler-healthcheck-cells` is undefined (vitessio#12477) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> * Add dry-run/monitoring-only mode for TxThrottler (vitessio#13604) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> * `txthrottler`: remove `txThrottlerConfig` struct, rely on `tabletenv` (vitessio#13624) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * tx throttler: remove unused topology watchers (vitessio#14412) Signed-off-by: deepthi <deepthi@planetscale.com> * tx_throttler: delete topo watcher metric instead of deprecating (vitessio#14445) Signed-off-by: deepthi <deepthi@planetscale.com> * TxThrottler: dont throttle unless lag (vitessio#14789) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * go test -v Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * add mutex to flaky parseFlags() Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert tweaks for flaky tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix protojson err Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make vtadmin_web_proto_types Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * remove debug t.Logf(...) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> Signed-off-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> Signed-off-by: deepthi <deepthi@planetscale.com> Co-authored-by: Eng Zer Jun <engzerjun@gmail.com> Co-authored-by: Shlomi Noach <2607934+shlomi-noach@users.noreply.github.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Deepthi Sigireddi <deepthi@planetscale.com>

…cy (#266) * `slack-vitess-r15.0.5`: add `slack_cross_cell` custom durability policy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use tag Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * use v0.15.1 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update shim Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Make `Durabler` interface methods public (vitessio#15548) Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Manan Gupta <manan@planetscale.com> * Update `slack_cross_cell` shim Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy again Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Allow private go module from vitess-additions repo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix typo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Missing non-template update Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Missing non-template update Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Missing non-template update, pt 3 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Fix docker tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * make proto Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix upgrade/downgrade tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Update all the Go dependencies (vitessio#11741) * Update all the Go dependencies This seems to work for the basics just fine, so let's have CI take a run at this as well to update these. Only one small update to the Azure blob storage handling seems needed so far. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Use correct proto comparisons We're using `reflect.DeepEqual` or `testify` helpers that essentially use that in a number of places are comparing protobufs. This is not supported though, protobufs are not comparable with `reflect.DeepEqual`. This is exposed because of the tiny patch bump of protobuf which changes some internal optimization of how it initializes protobufs that breaks all this. Instead, move to the appropriate helpers here. Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> * Resolve signature mismatch Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert protobuf version Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * revert protobuf version, pt 2 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Revert "Update all the Go dependencies (vitessio#11741)" This reverts commit 18faa1e. * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Manan Gupta <manan@planetscale.com> Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com> Co-authored-by: Manan Gupta <manan@planetscale.com> Co-authored-by: Dirkjan Bussink <d.bussink@gmail.com>

* Add `VStreamerCount` stat to `vttablet` (vitessio#11978) * Add `VStreamersActive` stat to `vttablet` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Improve desc Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add PR suggestions Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move to *stats.Gauge Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Single defer Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Add `Uptime` metric (vitessio#12712) * Add `Uptime` metric to `vtgate`+`vttablet` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * move to go/vt/servenv/status.go Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use nanoseconds for uptime Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Move Uptime metrics to servenv.go, remove dupe start time.Time Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Use serverStart time.Time Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * Implement the RowsColumnTypeScanType interface in the go sql driver for Vitess in order to get the column types (vitessio#12007) Signed-off-by: Johan Oskarsson <joskarsson@slack-corp.com> Signed-off-by: Johan Oskarsson <joskarsson@slack-corp.com> Co-authored-by: Johan Oskarsson <joskarsson@slack-corp.com> * Add vstream metrics to vtgate (vitessio#13098) * Add vstream metrics to vtgate Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Update unit test name and use cell variable Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * Reset metrics for TestVStreamsCreatedAndLagMetrics, fix data race issue Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> --------- Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> * add lock to flaky TestValidateVersionShard test Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * typo Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: Johan Oskarsson <joskarsson@slack-corp.com> Signed-off-by: twthorn <thomaswilliamthornton@gmail.com> Co-authored-by: Johan Oskarsson <johan@oskarsson.nu> Co-authored-by: Johan Oskarsson <joskarsson@slack-corp.com> Co-authored-by: Thomas Thornton <thomaswilliamthornton@gmail.com>

Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* Skip recalculating the rate in MaxReplicationLagModule when it can't be done (vitessio#12620) * Skip recalculating the rate in MaxReplicationLagModule when it can't be done This defends against lag records with nil stats which can lead to segfaults. See vitessio#12619 Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Address PR comments. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Make linter happy Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * Throttled transactions return MySQL error code 1041 ER_OUT_OF_RESOURCES (vitessio#12949) This error code seems better suited to represent the fact that transactions are being throttled by the server due to some form of resource contention than the current code 1203 ER_TOO_MANY_USER_CONNECTIONS. Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> * MaxReplicationLagModule.recalculateRate no longer fills the log (vitessio#14875) Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

* Fallback to poller replication lag if heartbeat lag fails * Try to make CI pipeline happy * Address PR comments * Fix typo --------- Signed-off-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com> Signed-off-by: Eduardo J. Ortega U. <5791035+ejortegau@users.noreply.github.com> Co-authored-by: Eduardo J. Ortega U <5791035+ejortegau@users.noreply.github.com>

* bugfix: fix nil pointer in vtgate on topo connection error (vitessio#13010) * fix nil pointer in vtgate on topo connection error Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * add test Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> * fix year Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> --------- Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com> * VTGate Buffering: Use a more accurate heuristic for determining if we're doing a reshard (vitessio#13856) Signed-off-by: Matt Lord <mattalord@gmail.com> --------- Signed-off-by: Olga Shestopalova <oshestopalova@hubspot.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Olga Shestopalova <olgash@mit.edu> Co-authored-by: Olga Shestopalova <oshestopalova@hubspot.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

* add vtgate flag that explicitly allows vstream copy (#125) * fix fs.BoolVar Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * VSCopy: Resume the copy phase consistently from given GTID and lastpk (vitessio#11103) * VSCopy: Demonstrate to fail a test case on which the vstream API is supposed to resume the copy phase consistently Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Resume the copy phase consistently from given GTID and lastpk Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Build out the unit test some more Signed-off-by: Matt Lord <mattalord@gmail.com> * Update tests for new behavior Signed-off-by: Matt Lord <mattalord@gmail.com> * Improve comments Signed-off-by: Matt Lord <mattalord@gmail.com> * Limit uvstreamer changes and update test Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert uvstreamer test changes Signed-off-by: Matt Lord <mattalord@gmail.com> * Revert all uvstream changes Signed-off-by: Matt Lord <mattalord@gmail.com> * VCopy: Revert the last three commits Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VCopy: Add a new vstream type that allows picking up where we left off Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VCopy: Revert the unit test change Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VCopy: Fix the end-to-end CI test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Update logic for setting up uvstreamer based on input vgtid/tablepks. Add more catchup events to test Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Refactor logic to decide if event is to be sent. Enhance unit and e2e tests. Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Don't send events for tables which we can identify as ones we haven't started copy for Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Minor changes after self-review Signed-off-by: Rohit Nayak <rohit@planetscale.com> * Add vstream copy resume to release notes Signed-off-by: Matt Lord <mattalord@gmail.com> * Address review comments Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * VSCopy: Send COPY_COMPLETED events when the copy operation is done (vitessio#11740) * VSCopy: Demonstrate to fail a test case on which the vstream API sends new events showing copy completed Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Send new events when the copy operation is done Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Fix typo Signed-off-by: yoheimuta <yoheimuta@gmail.com> * Initialize new map for the 'vstream * from' vtgate sql interface. Make vtadmin web protos Signed-off-by: Rohit Nayak <rohit@planetscale.com> * VSCopy: Make TestVStreamCopyBasic fail fast to avoid the end2end timeout out Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: stop sharing the 't1' table among multiple test cases running concurrently Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: refactor the function signature to be clearer Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: refactor the VEvents sorter to be simpler Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: refactor to stop the sorter from including a fully copied event Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com> * VSCopy: Enable to copy from all shards in either a specified keyspace or all keyspaces (vitessio#11909) * VSCopy: Demonstrate to fail a test case on which the vstream API request doesn't include keyspace and shard Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Copy from all shards in all keyspaces by specifying only an empty gtid Signed-off-by: yoheimuta <yoheimuta@gmail.com> * tests: Make TestRowCount stable regardless of the number of keyspaces Signed-off-by: yoheimuta <yoheimuta@gmail.com> * tests: Cleanup TestCreateAndDropDatabase correctly to stop TestVStreamCopyWithoutKeyspaceShard from failing when running tests together Signed-off-by: yoheimuta <yoheimuta@gmail.com> * tests: Tweak to fix a comment Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: fix the unit tests when the input vgtid with an empty gtid lacks either keyspace or shard Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Keyspace wildcard selection lines up with the table wildcard selection Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Tests the VCopy with multiple keyspaces and resharding Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Make TestVStreamCopyMultiKeyspaceReshard clearer to check if the streaming two keyspaces works even after reshard Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Return an invalid argument error if shards are unspecified and gtid is neither 'current' nor empty Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a test description about its purpose and target Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Remove duplicate literals in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Retain defaultReplicas variable in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Explain why we are setting Match to 'customer.*' in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Remove an unused VStreamFlag for the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Use sentence capitalization in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Verify that we didn't lose any events or get duplicates of the keyspace being reshareded in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Return a value instead of a pointer because there is no need to modify the value Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a comment describing what TestVStreamCopyFromAllKeyspacesAndAllShards is doing and why Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a comment describing why we expect these specific numbers of events from VStream API Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Tweak the test case name Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Make a utility function to sort COPY_COMPLETED events in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Replace the matcher with a simpler one in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Move the print debug call to the FailNow section in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Use require.NoError in new tests Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Use require instead of t.Fatalf in the test Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Apply the reviewer's suggestion to make the error message easier to read Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Add a comment noting what we're actually testing Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Correct the test comment and elaborate the special-case Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Tweak an error message and a comment Signed-off-by: yoheimuta <yoheimuta@gmail.com> * VSCopy: Adjust to a change in the signature of a test function that was introduced in the main repository Signed-off-by: yoheimuta <yoheimuta@gmail.com> --------- Signed-off-by: yoheimuta <yoheimuta@gmail.com> * attempt unit test fix Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update test error expected Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Signed-off-by: yoheimuta <yoheimuta@gmail.com> Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Rohit Nayak <rohit@planetscale.com> Co-authored-by: pbibra <pbibra@slack-corp.com> Co-authored-by: yohei yoshimuta <yoheimuta@gmail.com> Co-authored-by: Matt Lord <mattalord@gmail.com> Co-authored-by: Rohit Nayak <rohit@planetscale.com>

* `slack-15.0`: basic go.mod updates Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * fix signature in `go/vt/mysqlctl/azblobbackupstorage/azblob.go` Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update expected error for new mysql driver Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * more go.mod updates Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * steal statsd fix from vitessio#11741 Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * go mod tidy Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flag e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flag e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> * update flag e2e tests Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com>

* [release-17.0] VReplication: Take replication lag into account in VStreamManager healthcheck result processing (vitessio#15761) (vitessio#15772) Signed-off-by: Matt Lord <mattalord@gmail.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com> * fix signature Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> --------- Signed-off-by: Matt Lord <mattalord@gmail.com> Signed-off-by: Tim Vaillancourt <tim@timvaillancourt.com> Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com> Co-authored-by: Matt Lord <mattalord@gmail.com>

Commits on Jun 1, 2024

forward ports slack specific v14 PRS fix

vmogilev committed Jun 1, 2024

Configuration menu

View commit details

Copy full SHA for 7175b0f

Browse repository at this point

Copy the full SHA

7175b0f View commit details

Browse the repository at this point in the history

Vm slack 15.0 #16035

Vm slack 15.0 #16035

Commits on Oct 4, 2022

Commits on Oct 5, 2022

Commits on Oct 6, 2022

Commits on Oct 10, 2022

Commits on Oct 12, 2022

Commits on Oct 13, 2022

Commits on Oct 14, 2022

Commits on Oct 15, 2022

Commits on Oct 17, 2022

Commits on Oct 18, 2022

Commits on Oct 19, 2022

Commits on Oct 20, 2022

Commits on Oct 21, 2022

Commits on Oct 24, 2022

Commits on Oct 25, 2022

Commits on Oct 26, 2022

Commits on Oct 27, 2022

Commits on Nov 3, 2022

Commits on Nov 4, 2022

Commits on Nov 9, 2022

Commits on Nov 10, 2022

Commits on Nov 11, 2022

Commits on Nov 13, 2022

Commits on Nov 15, 2022

Commits on Nov 16, 2022

Commits on Nov 17, 2022

Commits on Nov 22, 2022

Commits on Nov 24, 2022

Commits on Nov 28, 2022

Commits on Nov 29, 2022

Commits on Nov 30, 2022

Commits on Dec 7, 2022

Commits on Dec 9, 2022

Commits on Dec 10, 2022

Commits on Dec 13, 2022

Commits on Dec 14, 2022

Commits on Dec 27, 2022

Commits on Jan 4, 2023

Commits on Jan 5, 2023

Commits on Jan 10, 2023

Commits on Jan 11, 2023

Commits on Jan 13, 2023

Commits on Jan 18, 2023

Commits on Jan 19, 2023

Commits on Jan 25, 2023

Commits on Jan 26, 2023

Commits on Jan 31, 2023

Commits on Feb 3, 2023

Commits on Feb 6, 2023

Commits on Feb 9, 2023

Commits on Feb 13, 2023

Commits on Feb 17, 2023

Commits on Feb 24, 2023

Commits on Feb 27, 2023

Commits on Feb 28, 2023

Commits on Mar 1, 2023

Commits on Mar 5, 2023

Commits on Mar 7, 2023

Commits on Mar 8, 2023

Commits on Mar 9, 2023

Commits on Mar 13, 2023

Commits on Mar 16, 2023

Commits on Mar 20, 2023

Commits on Mar 21, 2023

Commits on Mar 23, 2023

Commits on Mar 24, 2023

Commits on Mar 27, 2023

Commits on Mar 28, 2023

Commits on Mar 29, 2023

Commits on Mar 30, 2023

Commits on Mar 31, 2023

Commits on Apr 3, 2023

Commits on Apr 4, 2023

Commits on Apr 5, 2023

Commits on Apr 7, 2023

Commits on Apr 11, 2023

Commits on Apr 17, 2023

Commits on Apr 18, 2023