Fix schemadiff semantics handling #16073
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem here is that we store entries in
.Tables
with their unescaped names, which is entirely safe to do here.However, we would use
sqlparser.String
to retrieve them. Now that normally works for table names, unless a table name is a SQL keyword. In that case, it turns into the escaped version with backticks and the whole table can't be found for semantic analysis.This can happen for example if you name a table
Order
.Related Issue(s)
Fixes #16072
Checklist