Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schemadiff semantics handling #16073

Merged

Commits on Jun 6, 2024

  1. Fix schemadiff semantics handling

    The problem here is that we store entries in `.Tables` with their
    unescaped names, which is entirely safe to do here.
    
    However, we would use `sqlparser.String` to retrieve them. Now that
    normally works for table names, unless a table name is a SQL keyword. In
    that case, it turns into the escaped version with backticks and the
    whole table can't be found for semantic analysis.
    
    This can happen for example if you name a table `Order`.
    
    Signed-off-by: Dirkjan Bussink <d.bussink@gmail.com>
    dbussink committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    0998590 View commit details
    Browse the repository at this point in the history