[CI/Build] Give PR cleanup job PR write access #10139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
When I ran this job on my own fork, it had the necessary permissions to edit my own PR. Here, we need to explicitly grant the workflow PR write access. Since we are giving the GITHUB_TOKEN some level of elevated access, it is safer to use `pull_request_event` instead of `pull_request`. The difference is that `pull_request_event` runs in the context of `main` instead of the PR. In other words, a PR will not run this workflow using changes from the PR itself. This prevents a malicious PR from editing this workflow, or a script that it executes, to do something malicious with the github token. Finally, run this on the reopened event, but not synchronize. It's not relevant for sync (new commits being pushed). Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
force-pushed
the
pr-body-cleanup-perms-fix
branch
from
f15d153
to
a0c0c43
Compare
njhill
approved these changes
Nov 8, 2024
Isotr0py
pushed a commit
to Isotr0py/vllm
that referenced
this pull request
Nov 8, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Isotr0py <2037008807@qq.com>
omer-dayan
pushed a commit
to omer-dayan/vllm
that referenced
this pull request
Nov 10, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: OmerD <omer@run.ai>
JC1DA
pushed a commit
to JC1DA/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
jeejeelee
pushed a commit
to jeejeelee/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
rickyyx
pushed a commit
to rickyyx/vllm
that referenced
this pull request
Nov 13, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: Russell Bryant <rbryant@redhat.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I ran this job on my own fork, it had the necessary permissions
to edit my own PR. Here, we need to explicitly grant the workflow PR
write access.
Since we are giving the GITHUB_TOKEN some level of elevated access, it
is safer to use
pull_request_eventinstead ofpull_request. Thedifference is that
pull_request_eventruns in the context ofmaininstead of the PR. In other words, a PR will not run this workflow
using changes from the PR itself. This prevents a malicious PR from
editing this workflow, or a script that it executes, to do something
malicious with the github token.
Signed-off-by: Russell Bryant rbryant@redhat.com