Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: (CLI): support colormap extension packages other than cblind (cmasher, cmocean, cmyt) #377

Conversation

neutrinoceros
Copy link
Collaborator

In the process of removing cblind as a requirement, I also added support for other known colormap packages if they are installed. I'll need to add test coverage too before I undraft.

@neutrinoceros neutrinoceros force-pushed the cli/enh/support_colormap_extensions_other_than_cblind branch 3 times, most recently from 83851e9 to c4c4859 Compare November 24, 2024 15:30
@neutrinoceros neutrinoceros force-pushed the cli/enh/support_colormap_extensions_other_than_cblind branch from c4c4859 to 2827015 Compare November 24, 2024 15:33
@neutrinoceros
Copy link
Collaborator Author

Note that I'm intentionally not including cmasher in test_all.txt because including creates a new failure mode when installing via uv: colorspacious (which cmasher depends on) raises a SyntaxWarning the first time it is imported. This can be worked around by passing --compile-bytecode to uv pip install but I just don't want to add this layer of complexity to this CI.

@neutrinoceros neutrinoceros marked this pull request as ready for review November 24, 2024 15:46
@neutrinoceros neutrinoceros merged commit 83757e4 into volodia99:main Nov 24, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant