Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Email Link and Phone Link (in Action Block) #236

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jbmoelker
Copy link
Member

@jbmoelker jbmoelker commented Dec 28, 2024

Important

Depends on #234, which should be merged first.

Changes

  • Adds Email Link to easily send an email (with optional subject and body text).
  • Adds Phone Link to easily start phone call, send sms (with optional text) or contact via WhatsApp (with optional message).

Associated issue

N/A

How to test

  1. Open preview link
  2. Navigate to Action Block demo > "Action block with Email Links" section
  3. Verify all variations (mailto only, with subject, with subject + body) work
  4. Navigate to Action Block demo > "Action block with Phone Links" section
  5. Verify all variations (call, sms, whatsapp) work (best to check on both Android and iOS)
  6. Go the the email-and-phone-links environment and play around with the new Email Link and Phone Link option in Action Blocks
  7. Verify changes made are reflected in the web page (note: run locally as changes are not updated on deploy preview)

Checklist

  • I have performed a self-review of my own code
  • I have made sure that my PR is easy to review (not too big, includes comments)
  • I have made updated relevant documentation files (in project README, docs/, etc)
  • I have added a decision log entry if the change affects the architecture or changes a significant technology
  • I have notified a reviewer

Copy link

cloudflare-workers-and-pages bot commented Dec 28, 2024

Deploying head-start with  Cloudflare Pages  Cloudflare Pages

Latest commit: eeb8b8f
Status: ✅  Deploy successful!
Preview URL: https://da44dd74.head-start.pages.dev
Branch Preview URL: https://feat-email-and-phone-links.head-start.pages.dev

View logs

@jbmoelker jbmoelker marked this pull request as ready for review December 28, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant