Adding options for the rpc audit provider #246
Conversation
It's currently defaulting to 1, which means it's insecure by default. I've set it to 1 by default, but at least now it can be overriden. Tests included
| @@ -63,6 +63,9 @@ | |||
| $ssl_server_private = undef, | |||
| $ssl_client_certs = 'puppet:///modules/mcollective/empty', | |||
| $ssl_client_certs_dir = undef, # default dependent on $confdir | |||
|
|
|||
| # Action policy settings | |||
| $allowunconfigured = '1', | |||
There was a problem hiding this comment.
would you mind changing this name to allow_unconfigured like the option is named as well?
|
@jaxxstorm thank you very much for this contribution! could you also document this new option? |
|
I kind of feel that we'd want to accept |
|
I agree on the whole, but it seems like overkill to have to refactor a bunch of stuff just to get this merged. It has parity with the current settings. It'll take me a little while longer to write tests/manifests for true == 1 and false == 0 |
Adding options for the rpc audit provider
|
0/1 is a mental overhead, compared to true / false. |
|
No worries! It's not documented, but thanks for merging :) |
|
argH! how did i not notice that :( #247 |
It's currently defaulting to 1, which means it's insecure by default.
I've set it to 1 by default, but at least now it can be overriden.
Tests included