Skip to content
This repository has been archived by the owner on Dec 20, 2024. It is now read-only.

Adding options for the rpc audit provider #246

Merged
merged 1 commit into from
Oct 20, 2015
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions manifests/init.pp
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,9 @@
$ssl_server_private = undef,
$ssl_client_certs = 'puppet:///modules/mcollective/empty',
$ssl_client_certs_dir = undef, # default dependent on $confdir

# Action policy settings
$allowunconfigured = '1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you mind changing this name to allow_unconfigured like the option is named as well?

) inherits mcollective::defaults {

# Because the correct default value for several parameters is based on another
Expand Down
2 changes: 1 addition & 1 deletion manifests/server/config/rpcauthprovider/action_policy.pp
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@
}

mcollective::server::setting { 'plugin.actionpolicy.allow_unconfigured':
value => 1,
value => $mcollective::allowunconfigured,
}
}
5 changes: 5 additions & 0 deletions spec/classes/mcollective_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,11 @@
let(:params) { { :server => true, :rpcauthprovider => 'action_policy' } }
it { should contain_mcollective__server__setting('plugin.actionpolicy.allow_unconfigured').with_value('1') }
end

context 'allow_unconfigured' do
let(:params) { { :server => true, :rpcauthprovider => 'action_policy', :allowunconfigured => '0' }}
it { should contain_mcollective__server__setting('plugin.actionpolicy.allow_unconfigured').with_value('0') }
end
end

describe '#rpcauditprovider' do
Expand Down