Add storybook in the project #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thayannevls
force-pushed
the
chore/add-storybook
branch
2 times, most recently
from
aaeb41c
to
f125265
Compare
emersonlaurentino
requested changes
Apr 9, 2020
emersonlaurentino
requested changes
Apr 9, 2020
emersonlaurentino
requested changes
Apr 9, 2020
| delay={number('Delay(ms)', 0)} | ||
| fallbackPosition={select('Fallback Position', positions, 'right')} | ||
| > | ||
| <Button>Button</Button> |
There was a problem hiding this comment.
here is the typescript error that I couldn't solve yet
There was a problem hiding this comment.
🤔 I think I solved, can you check?
|
@emersonlaurentino eslint+prettier was configured but my vscode didn't checked the new files that's why I didn't notice the errors 😅 I'm going to fix now |
…heme and add stories eexamples
thayannevls
force-pushed
the
chore/add-storybook
branch
from
51029ac
to
901b15d
Compare
thayannevls
force-pushed
the
chore/add-storybook
branch
from
901b15d
to
1f24f7e
Compare
emersonlaurentino
approved these changes
Apr 9, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add storybook configurations, addons, stories examples and the documentation about it.
Addons configured here:
What problem is this solving?
We need an enviroment with hot-loading and that builds components in isolation to help us develop our components.
How should this be manually tested?
yarn && yarn storybookand then visit localhost:6006 in your browser.To Do
Types of changes