SHACL on Graphs #25

VladimirAlexiev · 2024-11-28T18:20:01Z

closes #24

README.md

tpluscode · 2024-11-28T20:08:49Z

README.md

+- SHACL on Graphs (as discussed in [shacl#22](https://github.com/w3c/shacl/issues/22) and [Inst4CIM-KG#140](https://github.com/Sveino/Inst4CIM-KG/issues/140))
+  - [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph are the inputs to a SHACL validator - But these are "ephemeral", and spec doesn't concretize how to pass them to the validator.
+  - [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) - A triple in the data that **suggests** which shapes to select for validation.
+  - `rdf4j:SHACLShapeGraph` - in RDF4J is the default shape (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).
+  - `rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph` - in RDF4J allow to describe exactly which shapes go with which graphs (see [doc](https://graphdb.ontotext.com/documentation/10.8/shacl-validation.html#union-of-data-graphs-when-validating-the-results) or [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).
+  - [Extending SHACL to RDF Datasets](https://afs.github.io/shacl-datasets.html) - Proposal that describes applying SHACL to RDF Datasets by Jena's author.


I'm a little hesitant to accept vendor-specific extensions in the "Specifications" section.
If we are to include these, maybe add a clear separation from the standards?

is it ok now: https://github.com/w3c-cg/awesome-semantic-shapes/blob/VladimirAlexiev-patch-1/README.md#specifications

Data Graph and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.

sh:shapesGraph (SHACL spec) - A triple in the data graph that suggests which shapes to select for validation.

rdf4j:SHACLShapeGraph (RDF4J extension) - default shape graph in RDF4J (see this blog).

rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph (RDF4J extension) - describe exactly which shapes go with which graphs (see doc or this blog).

Extending SHACL to RDF Datasets (by Jena's author) - Proposal that describes applying SHACL to RDF Datasets.

@tpluscode is it ok now?

Not sure, sorry. Would like a second opinion. @TallTed @amivanoff ?

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

TallTed

I'm good with the other changes. One small additional suggestion.

README.md

amivanoff · 2024-12-13T11:36:54Z

It will be good to pick a default way to ignore linter's errors.

Examples of two approaches below, assuming there are link duplication (links differs only in #fragments treated as the same) and item formatting problems:

Ignore several lines. This approach will provoke inconsistencies in the formatting of list items.

<!--lint disable awesome-list-item double-link-->
A whole document
or a section,
or several list items here
<!--lint enable awesome-list-item double-link-->

Ignore non-standard list items one-by-one (one per line). This approach will show more clearly problematic items. But requires more efforts.

  <!--lint ignore awesome-list-item double-link-->
  - [SomeSoftware](https://acme.com/some-duplicated-link) some text within an item's name but not a part of the link - description starts with lower-case letter and without an ending comma
  <!--lint ignore awesome-list-item double-link-->
  - [SomeSoftware](https://acme.com/some-duplicated-link) some text within an item's name but not a part of the link - description starts with lower-case letter and without an ending comma

amivanoff · 2024-12-13T11:42:18Z

I added code suggestions to the relevant lines according to the approach from n.2 (one-by-one).

amivanoff

Some issues lines causes linting errors

amivanoff · 2024-12-13T11:12:59Z

README.md

@@ -139,6 +144,13 @@ Data viewers/Editors based on shapes.
 - SHACL-related specifications
  - [The Shape Topologies algorithm](https://treecg.github.io/specification/shape-topologies)
  - [DASH Data Shapes](https://www.datashapes.org/) - Platform-independent extensions of SHACL for common tasks. Stuff that could become an official standard in the future.
+
+- SHACL on Graphs (as discussed in [shacl#22](https://github.com/w3c/shacl/issues/22) and [Inst4CIM-KG#140](https://github.com/Sveino/Inst4CIM-KG/issues/140))
+  - [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.


Suggested change

- [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.



- [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) - The input to a SHACL validator (along with the Shapes Graph or SHACL spec), but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.

hi @amivanoff , so it ignores the fragment when checking for duplicated links?

Yes, it does. We can enable/disable separate linter's rulesets per list item only -- "ignore" (or enable/disable it globally -- "disable").

Just put the ruleset IDs after the "lint ignore" and separate it with a space from each other.

double-link -- checks list item duplication

awesome-list-item -- checks list item formatting

Examples:

  

The awesome linter "ignores the fragment when checking for duplicated links"? That's not awesome! It should result in feedback to the linter project! Different fragments are different URIs, even if dereferencing both results in the browser displaying approximately the same information.

Ignoring double-links should not be the only way to handle such fragment differences, not only because actual double links (i.e., with no fragment differentation) should still be flagged.

amivanoff · 2024-12-13T11:38:25Z

README.md

+  - [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.
+  - [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that **suggests** which shapes to select for validation.
+  - `rdf4j:SHACLShapeGraph` (RDF4J extension) - default shape graph in RDF4J (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).
+  - `rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph` (RDF4J extension) - describe exactly which shapes go with which graphs (see [doc](https://graphdb.ontotext.com/documentation/10.8/shacl-validation.html#union-of-data-graphs-when-validating-the-results) or [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).


Suggested change

- `rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph` (RDF4J extension) - describe exactly which shapes go with which graphs (see [doc](https://graphdb.ontotext.com/documentation/10.8/shacl-validation.html#union-of-data-graphs-when-validating-the-results) or [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).



- `rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph` (RDF4J extension) - describe exactly which shapes go with which graphs (see [doc](https://graphdb.ontotext.com/documentation/10.8/shacl-validation.html#union-of-data-graphs-when-validating-the-results) or [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).

amivanoff · 2024-12-13T11:38:52Z

README.md

+- SHACL on Graphs (as discussed in [shacl#22](https://github.com/w3c/shacl/issues/22) and [Inst4CIM-KG#140](https://github.com/Sveino/Inst4CIM-KG/issues/140))
+  - [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.
+  - [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that **suggests** which shapes to select for validation.
+  - `rdf4j:SHACLShapeGraph` (RDF4J extension) - default shape graph in RDF4J (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).


Suggested change

- `rdf4j:SHACLShapeGraph` (RDF4J extension) - default shape graph in RDF4J (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).



- `rdf4j:SHACLShapeGraph` (RDF4J extension) - default shape graph in RDF4J (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).

amivanoff · 2024-12-13T11:39:39Z

README.md

+
+- SHACL on Graphs (as discussed in [shacl#22](https://github.com/w3c/shacl/issues/22) and [Inst4CIM-KG#140](https://github.com/Sveino/Inst4CIM-KG/issues/140))
+  - [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.
+  - [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that **suggests** which shapes to select for validation.


Suggested change

- [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that **suggests** which shapes to select for validation.



- [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that **suggests** which shapes to select for validation.

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

SHACL on Graphs

027751e

closes #24

VladimirAlexiev requested a review from tpluscode November 28, 2024 18:20

Update README.md

a5ab291

tpluscode requested changes Nov 28, 2024

View reviewed changes

VladimirAlexiev and others added 3 commits December 3, 2024 11:53

fix by TallTed

6580ef5

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

"part of Stardog RDF Languages Extension Pack"

9bfff0d

SHACL on Graphs: delineate spec vs vendor extensions

e73f718

tpluscode requested review from TallTed and amivanoff December 12, 2024 20:42

TallTed suggested changes Dec 12, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

amivanoff suggested changes Dec 13, 2024

View reviewed changes

commit TallTed's suggestion

b1cd058

Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>

VladimirAlexiev mentioned this pull request Dec 17, 2024

rudof gives lint:double-link warnings #21

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SHACL on Graphs #25

SHACL on Graphs #25

VladimirAlexiev commented Nov 28, 2024

tpluscode Nov 28, 2024

VladimirAlexiev Dec 3, 2024 •

edited

Loading

VladimirAlexiev Dec 12, 2024

tpluscode Dec 12, 2024

TallTed left a comment

amivanoff commented Dec 13, 2024 •

edited

Loading

amivanoff commented Dec 13, 2024

amivanoff left a comment

amivanoff Dec 13, 2024

VladimirAlexiev Dec 17, 2024

amivanoff Dec 18, 2024 •

edited

Loading

TallTed Dec 19, 2024 •

edited

Loading

amivanoff Dec 13, 2024

amivanoff Dec 13, 2024

amivanoff Dec 13, 2024

	- [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) and Shapes Graph (SHACL spec) - the inputs to a SHACL validator, but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.
	<!--lint ignore double-link-->
	- [Data Graph](https://w3c.github.io/data-shapes/shacl/#data-graph) - The input to a SHACL validator (along with the Shapes Graph or SHACL spec), but these are "ephemeral", and spec doesn't concretize how to pass them to the validator.

	- `rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph` (RDF4J extension) - describe exactly which shapes go with which graphs (see [doc](https://graphdb.ontotext.com/documentation/10.8/shacl-validation.html#union-of-data-graphs-when-validating-the-results) or [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).
	<!--lint ignore awesome-list-item double-link-->
	- `rsx:DataAndShapesGraphLink, rsx:shapesGraph, rsx:dataGraph` (RDF4J extension) - describe exactly which shapes go with which graphs (see [doc](https://graphdb.ontotext.com/documentation/10.8/shacl-validation.html#union-of-data-graphs-when-validating-the-results) or [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).

	- `rdf4j:SHACLShapeGraph` (RDF4J extension) - default shape graph in RDF4J (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).
	<!--lint ignore awesome-list-item double-link-->
	- `rdf4j:SHACLShapeGraph` (RDF4J extension) - default shape graph in RDF4J (see [this blog](https://www.ontotext.com/blog/shacl-ing-the-data-quality-dragon-iii-a-good-artisan-knows-their-tools/)).

	- [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that suggests which shapes to select for validation.
	<!--lint ignore double-link-->
	- [sh:shapesGraph](https://w3c.github.io/data-shapes/shacl/#sh-shapes-graph) (SHACL spec) - A triple in the data graph that suggests which shapes to select for validation.

SHACL on Graphs #25

Are you sure you want to change the base?

SHACL on Graphs #25

Conversation

VladimirAlexiev commented Nov 28, 2024

Choose a reason for hiding this comment

VladimirAlexiev Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TallTed left a comment

Choose a reason for hiding this comment

amivanoff commented Dec 13, 2024 • edited Loading

amivanoff commented Dec 13, 2024

amivanoff left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amivanoff Dec 18, 2024 • edited Loading

Choose a reason for hiding this comment

TallTed Dec 19, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

VladimirAlexiev Dec 3, 2024 •

edited

Loading

amivanoff commented Dec 13, 2024 •

edited

Loading

amivanoff Dec 18, 2024 •

edited

Loading

TallTed Dec 19, 2024 •

edited

Loading