Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHACL on Graphs #25
base: main
Are you sure you want to change the base?
SHACL on Graphs #25
Changes from 2 commits
027751e
a5ab291
6580ef5
9bfff0d
e73f718
b1cd058
8617526
f7bbda8
dbb77a7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a little hesitant to accept vendor-specific extensions in the "Specifications" section.
If we are to include these, maybe add a clear separation from the standards?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it ok now: https://github.com/w3c-cg/awesome-semantic-shapes/blob/VladimirAlexiev-patch-1/README.md#specifications
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tpluscode is it ok now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure, sorry. Would like a second opinion. @TallTed @amivanoff ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TallTed @amivanoff @labra @dontcallmedom Please weigh in here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, I need to clarify some terminology and initial intentions of this sections (embedded in the initial structure of sections). Maybe it needs to be corrected. Maybe some corrected version needs o be added as a brief explainer in each of sections.
Maybe it would be better to break-down "Specifications" into several subsections?
For example:
a. "Current W3C Recommendations"
b. "Ongoing Work in Progress in W3C WG" (I think, "WG SHACL Drafts" as well as "SHACL on Graphs" belongs here). All vendor-spec extensions, related to the new "work-in-progress" features/issues, covered by the new W3C draft, belongs here (with a hope it will be aligned to the spec in the end, or not then it goes to 2.c)
c. "Vendor-Specific Extensions" (which are not in scope of the new spec draft, or a clear deviations from current Recommendations)
d. "SHACL-Related Specifications"
Result section structure (section headers):