Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-scroll-snap-2] Drop scroll-start and add issue to :snapped #10505

Merged
merged 3 commits into from
Jul 10, 2024

Conversation

DavMila
Copy link
Contributor

@DavMila DavMila commented Jun 26, 2024

Towards resolving 6985 this patch removes scroll-start from the spec and notes that :snapped is being replaced.

Towards resolving [6985](w3c#6985 (comment))
this patch removes scroll-start from the spec and notes that :snapped
is being replaced.
@DavMila DavMila requested a review from flackr June 26, 2024 14:15
Interaction with RTL and LTR</h4>

Logical properties are offered for length offsets that should be flow relative. Furthermore, the ''end'' and ''start'' keywords are always logical.

The 'scroll-start-target' property {#scroll-start-target}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scroll-start-target says it is a shorthand but I think that's no longer true since becoming a single property, right?

Copy link
Contributor Author

@DavMila DavMila Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's correct. Good catch. I've removed the "shorthand" references.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remnants of scroll-start-target-* longhands are still there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out. Created #10554 to remove them.

@DavMila DavMila requested a review from flackr June 28, 2024 14:14
@@ -70,36 +71,6 @@ First Layout {#first-layout}
Motivating Examples {#examples}
===============================

<div class="example">
A carousel that starts in the middle:
Copy link
Contributor

@flackr flackr Jun 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is still a good example, it just requires that we add a class to the middle item in the carousel which sets scroll-start-target. This at least works for the case where the carousel shows one item at a time or when the items are snap center aligned. Can you update the example instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, done.

@DavMila DavMila requested a review from flackr July 5, 2024 13:44
@DavMila DavMila requested a review from tabatkins July 9, 2024 17:13
@tabatkins tabatkins merged commit a285f77 into w3c:main Jul 10, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants