[css-scroll-snap-2] Drop scroll-start and add issue to :snapped #10505
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,12 +39,13 @@ Introduction {#intro} | |
| <em>This is currently a delta spec over Scroll Snap 1.</em> | ||
|
|
||
| Scroll experiences don't always start at the beginning. Interactions with | ||
| carousels, swipe controls, and listviews often intend to begin from some element | ||
| which might not be positioned at the beginning of the scroll container. | ||
| JavaScript is required to make the scroll container initially scrolled | ||
| to that element. By enabling CSS to specify that an element should be | ||
| initially scrolled to, both users, page authors and browsers benefit. | ||
|
|
||
| In addition to setting an initial scroll target, | ||
| developers need insights and events into Scroll Snap. | ||
| Events like which element is snapped on which axis, | ||
| when the snap event is changing, | ||
|
|
@@ -70,36 +71,6 @@ First Layout {#first-layout} | |
| Motivating Examples {#examples} | ||
| =============================== | ||
|
|
||
| <div class="example"> | ||
| A search bar is available when the user scrolls back to the top: | ||
|
|
||
|
|
@@ -137,93 +108,6 @@ Motivating Examples {#examples} | |
| Setting Where Scroll Starts {#properties-on-the-scroll-container} | ||
| ================================================================= | ||
|
|
||
| The 'scroll-start-target' property {#scroll-start-target} | ||
|
There was a problem hiding this comment. scroll-start-target says it is a shorthand but I think that's no longer true since becoming a single property, right? There was a problem hiding this comment. Yes that's correct. Good catch. I've removed the "shorthand" references. There was a problem hiding this comment. Remnants of There was a problem hiding this comment. Thanks for pointing this out. Created #10554 to remove them. |
||
| ------------------------------------------- | ||
|
|
||
|
|
@@ -289,7 +173,7 @@ Interaction with 'place-content'</h4> | |
| <h4 id="scroll-start-fragment-navigation"> | ||
| Post-first layout arrivals</h4> | ||
|
|
||
| While the document is being [[html#updating-the-document|updated]], | ||
| a <a>scroll container's</a> [=initial scroll target=] might arrive | ||
| after that <a>scroll container</a> has been laid out. | ||
| If this happens, | ||
|
|
@@ -313,6 +197,9 @@ Post-first layout arrivals</h4> | |
| Styling Snapped Items {#styling-snapped} | ||
| ============================= | ||
|
|
||
| Issue: The ':snapped' pseudo-class is being dropped in favor of a | ||
| <a href="https://drafts.csswg.org/css-contain-4/scroll_state_explainer.html">container state query</a> approach. | ||
|
|
||
| The Snapped-element Pseudo-class: '':snapped'' {#snapped} | ||
| ------------------------------------------------------- | ||
|
|
||
|
|
@@ -650,47 +537,7 @@ when the scrolling operation ends. | |
| █████ ███▌ █▌ ▐▌ ███▌ █▌ █▌ █▌ █▌ █▌ ▐▌ ████▌ | ||
| --> | ||
|
|
||
| Appendix A: Event Handlers {#event-handlers} | ||
| ============================================================ | ||
|
|
||
| ISSUE: This section should be moved to the HTML event handler | ||
|
|
@@ -736,9 +583,9 @@ Extensions to the <code>GlobalEventHandlers</code> Interface Mixin {#interface-g | |
| Privacy Considerations {#privacy} | ||
| ====================== | ||
|
|
||
| The features in this spec have no known privacy implications. | ||
|
|
||
| Security Considerations {#security} | ||
| ======================= | ||
|
|
||
| The features in this spec have no known security implications. | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is still a good example, it just requires that we add a class to the middle item in the carousel which sets scroll-start-target. This at least works for the case where the carousel shows one item at a time or when the items are snap center aligned. Can you update the example instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, done.