Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix setting defaultDimRed #321

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuel-marsh
Copy link
Contributor

Hi LIGER team,

Just quick PR here to fix issue. Right now runTSNE and runUMAP don't appropriately update the default dim reduc when a dimreduc is already present in object (for instance if seurat object with reductions is converted to liger object). This PR just adds single line to each of the functions to explicitly update the dim reduc after being run.

Thanks!
Sam

@samuel-marsh samuel-marsh changed the title fix setting default fix setting defaultDimRed Sep 25, 2024
@mvfki
Copy link
Collaborator

mvfki commented Sep 25, 2024

Hi Sam,

Thank you for being our active user! Indeed I have found this a problem a while ago and have already got a fix in my dev branch. Would you mind have a look in my forked repo "mvfki/liger" in master branch and see if that looks like working fine?

Best,
Yichen

@mvfki
Copy link
Collaborator

mvfki commented Sep 25, 2024

So basically I got one more step before setting. If the defaultDimRed is set, don't update it by default unless explicitly asked with asDefault. If defaultDimRed is NULL, just set the result as defaultDimRed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants