Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isotropic Remeshing Part 2 (Works without MM) #812

Draft
wants to merge 70 commits into
base: main
Choose a base branch
from

Conversation

mtao
Copy link
Collaborator

@mtao mtao commented Oct 6, 2024

More granular updates to finalize impl of isotropic remeshing (supporting multimesh configuratinos and other ocncepts).
Current impl has some idiosyncracies in how the input/output component are used which will be solved too

Copy link

codecov bot commented Oct 6, 2024

Codecov Report

Attention: Patch coverage is 20.35398% with 270 lines in your changes missing coverage. Please review.

Project coverage is 60.45%. Comparing base (cacc499) to head (fe4e076).

Files with missing lines Patch % Lines
applications/procedural/main.cpp 45.56% 43 Missing ⚠️
.../isotropic_remeshing/IsotropicRemeshingOptions.cpp 0.00% 35 Missing ⚠️
...edural/wmtk/components/procedural/Grid2Options.cpp 0.00% 31 Missing ⚠️
...edural/wmtk/components/procedural/Grid3Options.cpp 0.00% 31 Missing ⚠️
...ts/isotropic_remeshing/internal/configure_swap.cpp 0.00% 29 Missing ⚠️
.../wmtk/components/procedural/TriangleFanOptions.cpp 0.00% 21 Missing ⚠️
...sotropic_remeshing/internal/configure_collapse.cpp 0.00% 19 Missing ⚠️
...l/wmtk/components/procedural/ProceduralOptions.cpp 0.00% 17 Missing ⚠️
...cedural/wmtk/components/procedural/DiskOptions.cpp 0.00% 10 Missing ⚠️
...onents/isotropic_remeshing/isotropic_remeshing.cpp 0.00% 8 Missing ⚠️
... and 11 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #812      +/-   ##
==========================================
- Coverage   62.28%   60.45%   -1.83%     
==========================================
  Files         457      466       +9     
  Lines       22520    22774     +254     
  Branches     2537     2565      +28     
==========================================
- Hits        14026    13769     -257     
- Misses       8483     8994     +511     
  Partials       11       11              
Flag Coverage Δ
wildmeshing 60.45% <20.35%> (-1.83%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtao mtao changed the title Isotropic Remeshing Part 2 Isotropic Remeshing Part 2 (Works without MM) Oct 7, 2024
mtao and others added 26 commits October 7, 2024 15:12
…ildmeshing-toolkit into mtao/isotropic_remeshing_2
…entations and adding swap mode option for isotropic remeshing
mtao and others added 30 commits November 7, 2024 13:14
…ildmeshing-toolkit into mtao/isotropic_remeshing_2
…ildmeshing-toolkit into mtao/isotropic_remeshing_2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants