Update README.md fixing grammar #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitkent
approved these changes
Jun 27, 2024
|
The action "CI / lint-test (pull_request)" fails with
I the version bump be including in this PR? What are the steps for this? |
I don't think we need to bump chart version if it is just README change. Can we please update CI to run chart-testing only when files under Ref: https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions |
DanielFran
added a commit
to DanielFran/helm-charts
that referenced
this pull request
Jul 3, 2024
- Update image version and index - Updated readme with instructions to use helm repository - Updated notes and readme with port-forward instructions - Switch to Helm v2 - Substitute WIREMOCK_OPTION by args - Cleanup _helpers.tpl - Support additional pod annotations - Update configmaps - Update service - Fix ingress - Add imagePullSecrets support - Add service account support - Add pod and container security context support - Add horizontal pod autoscaler support - Updated CI and CD pipelines Fix wiremock#21 Fix wiremock#22 Fix wiremock#25 Fix wiremock#27 Fix wiremock#28 Fix wiremock#34 Fix wiremock#40 Close wiremock#29 Close wiremock#31 Close wiremock#33 Close wiremock#39
DanielFran
added a commit
to DanielFran/helm-charts
that referenced
this pull request
Jul 3, 2024
- Update image version and index - Update readme with instructions to use helm repository - Update notes and readme with port-forward instructions - Switch to Helm v2 - Substitute WIREMOCK_OPTION by args - Cleanup _helpers.tpl - Support additional pod annotations - Update configmaps - Update service - Fix ingress - Add imagePullSecrets support - Add service account support - Add pod and container security context support - Add horizontal pod autoscaler support - Update CI and CD pipelines Fix wiremock#21 Fix wiremock#22 Fix wiremock#25 Fix wiremock#27 Fix wiremock#28 Fix wiremock#34 Fix wiremock#40 Close wiremock#29 Close wiremock#31 Close wiremock#33 Close wiremock#39
DanielFran
added a commit
to DanielFran/helm-charts
that referenced
this pull request
Jul 3, 2024
- Update image version and index - Update readme with instructions to use helm repository - Update notes and readme with port-forward instructions - Switch to Helm v2 - Substitute WIREMOCK_OPTION by args - Cleanup _helpers.tpl - Support additional pod annotations - Update configmaps - Update service - Fix ingress - Add imagePullSecrets support - Add service account support - Add pod and container security context support - Add horizontal pod autoscaler support - Update CI and CD pipelines Fix wiremock#21 Fix wiremock#22 Fix wiremock#25 Fix wiremock#27 Fix wiremock#28 Fix wiremock#34 Fix wiremock#40 Close wiremock#29 Close wiremock#31 Close wiremock#33 Close wiremock#39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wrong grammar in the readme file.
References
nope
Submitter checklist
#help-contributingor a project-specific channel like#wiremock-java