Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to make tado x devices compatible with old tado devices #123

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

changes to make tado x devices compatible with old tado devices #123

wants to merge 8 commits into from

Conversation

wmalgadey
Copy link
Owner

Description

In home-assistant/core#129600 @Moritz-Schmidt tried to change the tado integration in home assistant to support Tado X devices with PyTado.

We want to reduce the changes to the integration and add compatibility changes to tado x responses.

Related Issues

Type of Changes

Mark the type of changes included in this pull request:

  • Bugfix
  • New Feature
  • Documentation Update
  • Refactor
  • Other (please specify):

Checklist

  • I have tested the changes locally and they work as expected.
  • I have added/updated necessary documentation (if applicable).
  • I have followed the code style and guidelines of the project.
  • I have searched for and linked any related issues.

Additional Notes

Add any additional comments, screenshots, or context for the reviewer(s).

Thank you for your contribution to PyTado! 🎉

@wmalgadey wmalgadey added this to the Support Tado X milestone Dec 26, 2024
@Moritz-Schmidt
Copy link

Thanks for your work! I hope I'll find some time in the following day to help to get this library and the home assistant integration ready for TadoX. Is there anything you still need help with or would like me to test with my TadoX setup?

@inverse inverse mentioned this pull request Dec 26, 2024
Merged
9 tasks
This was referenced Dec 26, 2024
Merged
Merged
@wmalgadey
Copy link
Owner Author

Is there anything you still need help with or would like me to test with my TadoX setup?

adding more test cases to increase coverage would be a good task 😄

@inverse inverse mentioned this pull request Dec 27, 2024
Merged
9 tasks
@wmalgadey wmalgadey reopened this Dec 28, 2024
@wmalgadey wmalgadey force-pushed the seamless-tadox-support branch from 0c7a006 to 6c0a938 Compare December 28, 2024 20:14
Moritz-Schmidt
Moritz-Schmidt suggested changes Dec 29, 2024
View reviewed changes
Copy link

@Moritz-Schmidt Moritz-Schmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All features that are shared universally across Tado generations should remain within the TadoBase class, ensuring accessibility for both inheriting classes. Features that are not universal to all generations should be placed in the corresponding class specific to that generation.

PyTado/interface/api/base_tado.py Outdated Show resolved Hide resolved
PyTado/interface/api/my_tado.py Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Complexity Health
. 74% 0 ➖
interface 71% 0 ➖
interface.api 43% 0 ❌
zone 93% 0 ✔
Summary 63% (724 / 1158) 0 ➖

Minimum allowed line rate is 60%

@wmalgadey
Copy link
Owner Author

@Moritz-Schmidt what do you think? is something missing to be compatible with tado pre X?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moritz-Schmidt Moritz-Schmidt Moritz-Schmidt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Support Tado X
Development

Successfully merging this pull request may close these issues.
2 participants
@wmalgadey @Moritz-Schmidt