Support devices with serialNumber as their property #124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When I try and use the library to fetch data from my account I noticed the devices have the
serialNo
property asserialNumber
. This change adds support for that and skips over devices that dont match either. Perhaps it'll be better to raise in such case?I only have Tado X within my account so perhaps it's related to that?
Related Issues
Link any related issues that this pull request resolves or is associated with:
Example:
Type of Changes
Mark the type of changes included in this pull request:
Checklist
Additional Notes
Thank you for your contribution to PyTado! 🎉