Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support devices with serialNumber as their property #124

Merged
merged 3 commits into from
Dec 28, 2024

Conversation

inverse
Copy link

@inverse inverse commented Dec 26, 2024

Description

When I try and use the library to fetch data from my account I noticed the devices have the serialNo property as serialNumber. This change adds support for that and skips over devices that dont match either. Perhaps it'll be better to raise in such case?

I only have Tado X within my account so perhaps it's related to that?

Related Issues

Link any related issues that this pull request resolves or is associated with:

Example:


Type of Changes

Mark the type of changes included in this pull request:

  • Bugfix
  • New Feature
  • Documentation Update
  • Refactor
  • Other (please specify):

Checklist

  • I have tested the changes locally and they work as expected.
  • I have added/updated necessary documentation (if applicable).
  • I have followed the code style and guidelines of the project.
  • I have searched for and linked any related issues.

Additional Notes


Thank you for your contribution to PyTado! 🎉

@wmalgadey wmalgadey self-assigned this Dec 27, 2024
@wmalgadey wmalgadey mentioned this pull request Dec 28, 2024
9 tasks
@wmalgadey wmalgadey merged commit 71849f4 into wmalgadey:master Dec 28, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants