Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert #6536 types.h one line HAVE_PTHREAD #6549

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

gojimmypi
Copy link
Contributor

@gojimmypi gojimmypi commented Jun 27, 2023

Description

This update reverts one line of #6536 that was seen to be problematic in wolfCLU

Fixes zd# n/a

Testing

checked wolfCLU

#!/bin/bash
rm -rf /mnt/c/test/wolfssl-install/bin
rm -rf /mnt/c/test/wolfssl-install/include
rm -rf /mnt/c/test/wolfssl-install/lib
rm -rf /mnt/c/test/wolfssl-install/share

./configure --enable-wolfclu  --prefix=/mnt/c/test/wolfssl-install && make clean && make && make install

# make && make install && cd /mnt/c/test/wolfCLU-fix && make clean && make && cd /mnt/c/test/wolfssl-master

Default config, threading enabled:

./configure &&  make && ./wolfcrypt/test/testwolfcrypt

Forced single-thread. This was observed to have failed during PRB with prior changes:

 ./configure --enable-singlethreaded --disable-fastmath --enable-smallstack --enable-smallstackcache  --disable-shared  && make && ./wolfcrypt/test/testwolfcrypt 
  • edit: for reference wolfSSL compiled to enable wolfCLU support, and install to /home/gojimmypi/wolfssl-install:
./configure --enable-wolfclu  --prefix=/home/gojimmypi/wolfssl-install
make clean && make && make install

wolfCLU configured to use specific /mnt/c/test/wolfssl-install

./configure --with-wolfssl=/mnt/c/test/wolfssl-install
make clean && make

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@gojimmypi gojimmypi requested a review from dgarske June 27, 2023 19:41
@gojimmypi gojimmypi self-assigned this Jun 27, 2023
@gojimmypi gojimmypi added the bug label Jun 27, 2023
@dgarske dgarske self-assigned this Jun 27, 2023
@dgarske dgarske merged commit d9d9c5c into wolfSSL:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants