Import Raw RSA Private Key #7608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarske
requested changes
Jun 1, 2024
ejohnstown
force-pushed
the
rsa-add
branch
3 times, most recently
from
2cdbde4
to
639d5f7
Compare
dgarske
previously approved these changes
Jun 2, 2024
SparkiDev
previously requested changes
Jun 2, 2024
wolfcrypt/src/rsa.c
Outdated
|
|
||
| #if defined(WOLFSSL_KEY_GEN) || defined(OPENSSL_EXTRA) || !defined(RSA_LOW_MEM) | ||
| /* | ||
| * Calculate y = x^(-1) mod d. |
There was a problem hiding this comment.
This comment doesn't match the code.
There was a problem hiding this comment.
I renamed the function as well.
1. Add API for importing an RSA private key, `wc_RsaPrivateKeyDecodeRaw()`, when all you have are the components of the key in raw arrays. Also recalculates dP and dQ if missing. 2. Add API test for `wc_RsaPrivateKeyDecodeRaw()`.
dgarske
approved these changes
Jun 3, 2024
4 tasks
jefferyq2
pushed a commit
to jefferyq2/wolfssl
that referenced
this pull request
Jun 9, 2024
Import Raw RSA Private Key
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add API
wc_RsaPrivateKeyDecodeRaw()for importing an RSA private key when all you have are the components of the key in raw arrays. Also recalculates dP and dQ if missing.Testing
Built wolfSSL with
--enable-wolfssh --enable-lowresource. Tested against a pending build of wolfSSH that uses the new function if available. Tested with and without low resource set.Checklist