-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Mark formatting #1073
Improve Mark formatting #1073
Conversation
…ing color customization
aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Outdated
Show resolved
Hide resolved
aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Outdated
Show resolved
Hide resolved
…is no longer active
Hey there @antonis 👋 I was wondering if you would be able to help me out with a PR review 😄, I've updated the Highlight color implementation so it fixes some issues for this feature since we first partially implemented it in #943 A lot of testing has been already done in WordPress/gutenberg#57650 so I was wondering if you'd have some time to check the native code for the Aztec side. Let me know if you could take a look! Thank you! |
I'll be glad to help with this @geriux :) I plan to get to this later today or tomorrow 🙇 |
Thank you so much! |
aztec/src/main/kotlin/org/wordpress/aztec/formatting/InlineFormatter.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @geriux ⭐
The code overall looks good and works as expected. I added some suggestions which are not blocking.
…es changes to how new values are set
Related PRs:
This PR adds missing implementation for the Mark formatting style.
MarkPlugin
that will handle adding the needed CSS attributes.MarkSpan
to receive a color param and to set it as the current color.applyMarkInlineStyle
in favor ofapplyAfterMarkInlineStyle
which will handle if the color changes while editing a Mark span.Test
Please follow the testing instructions in this PR's description.
This shouldn't affect other Aztec functionalities.
Make sure strings will be translated:
strings.xml
as a part of the integration PR.