Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight color fixes #6517

Merged
merged 24 commits into from
Mar 21, 2024
Merged

Highlight color fixes #6517

merged 24 commits into from
Mar 21, 2024

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jan 8, 2024

Related PRs:

To test:

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@geriux geriux force-pushed the fix/ios-highlight-feature branch from b4a10de to 666caf2 Compare January 19, 2024 13:25
@geriux geriux changed the title Highlight color fixes for iOS Highlight color fixes Jan 19, 2024
@derekblank
Copy link
Contributor

Hey @geriux! This PR is tagged with the 1.112.0 milestone, which I'll be cutting tomorrow. Let me know if you'd like to include it! No worries if not, and we can bump this PR to the next milestone.

@geriux geriux removed this from the 1.113.0 (24.3) milestone Feb 12, 2024
# Conflicts:
#	gutenberg
#	ios-xcframework/Podfile.lock
@geriux geriux added this to the 1.115.0 (24.5) milestone Mar 7, 2024
@geriux geriux modified the milestones: 1.115.0 (24.5), 1.116.0 Mar 14, 2024
@antonis antonis self-requested a review March 20, 2024 09:20
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested along with the changes in wordpress-mobile/AztecEditor-Android#1073 and WordPress/gutenberg#57650 and everything worked as expected 🎉

@geriux geriux merged commit cbfbf61 into trunk Mar 21, 2024
23 checks passed
@geriux geriux deleted the fix/ios-highlight-feature branch March 21, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants