Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Update targetSdk to 34 from 33. #1074

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

notandyvee
Copy link
Contributor

@notandyvee notandyvee commented Jan 23, 2024

Fix

Issue: #1072
Related: wordpress-mobile/gutenberg-mobile#6533.

This PR bumps the targetSdk version from 33 to 34. It depends on WP Utils 141: wordpress-mobile/WordPress-Utils-Android#141

Test

  • Ensure build passes.
  • Ensure the sample app is showing rich text properly.

Review

@irfano

Note

I'm not 100% sure how to test this against WP-util, other than waiting until that one is merged and then updating it here. Thoughts @ravishanker

Make sure strings will be translated:

  • If there are new strings that have to be translated, I have added them to the client's strings.xml as a part of the integration PR.

@notandyvee
Copy link
Contributor Author

Looks like there are build issues. Will fix.

@irfano
Copy link
Member

irfano commented Jan 23, 2024

I tested and confirmed targetSdk upgrade works. 👍🏻
UI tests are failing because Robolectric added Android support with 4.11, and we are currently using 4.9. If you wish, you can upgrade the Robolectric version in a separate PR by targeting fix/target-sdk-34-update to distinguish the context from this PR.

@notandyvee
Copy link
Contributor Author

Done @irfano . Thanks!

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano irfano merged commit 1aa0a85 into trunk Jan 25, 2024
14 checks passed
@irfano irfano deleted the fix/target-sdk-34-update branch January 25, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants