Add iOS Request Interception #33
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
changed the base branch from
trunk
to
add/android-request-interception
dcalhoun
force-pushed
the
add/android-request-interception
branch
from
ac9d15f
to
8ed393e
Compare
dcalhoun
reviewed
Oct 24, 2024
Comment on lines
+382
to
+383
| // We care about WordPress.com resources – let's modify those if needed | ||
| if request.url?.host?.contains("wordpress.com") == true { |
There was a problem hiding this comment.
Eventually, we should hoist this conditional into the host app, as we want to avoid such references in Gutenberg.
Comment on lines
+376
to
+377
| // We don't want to interfere with loading the editor JS | ||
| guard request.url?.host != "localhost" else { |
There was a problem hiding this comment.
The development server can also be an IP when testing with a physical device. Maybe we can check against the GUTENBERG_EDITOR_URL environment variable as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.