-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS Request Interception #33
Draft
jkmassel
wants to merge
2
commits into
trunk
Choose a base branch
from
add/ios-request-interception
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -132,6 +132,8 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro | |
} | ||
|
||
private func setUpEditor() { | ||
registerRequestInterceptor() | ||
|
||
let webViewConfiguration = webView.configuration | ||
let userContentController = webViewConfiguration.userContentController | ||
let editorInitialConfig = getEditorConfiguration() | ||
|
@@ -368,6 +370,64 @@ private final class GutenbergEditorController: NSObject, WKNavigationDelegate, W | |
} | ||
} | ||
|
||
private extension WKWebView { | ||
class InterceptionProtocol: URLProtocol { | ||
override class func canInit(with request: URLRequest) -> Bool { | ||
|
||
// We don't want to interfere with loading the editor JS | ||
guard request.url?.host != "localhost" else { | ||
debugPrint("Not intercepting \(request)") | ||
return false | ||
} | ||
|
||
// We care about WordPress.com resources – let's modify those if needed | ||
if request.url?.host?.contains("wordpress.com") == true { | ||
Comment on lines
+382
to
+383
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Eventually, we should hoist this conditional into the host app, as we want to avoid such references in Gutenberg. |
||
return request.value(forHTTPHeaderField: "Authorization") == nil // If there's no auth header, we need to intercept | ||
} | ||
|
||
return false | ||
} | ||
|
||
override class func canonicalRequest(for request: URLRequest) -> URLRequest { | ||
var mutableRequest = request | ||
mutableRequest.allHTTPHeaderFields?["Authorization"] = "Bearer [REDACTED]" | ||
return mutableRequest | ||
} | ||
|
||
private var taskHandle: Task<Void, Error>? | ||
private let session: URLSession = URLSession(configuration: .ephemeral) | ||
|
||
override func startLoading() { | ||
self.taskHandle = Task { | ||
do { | ||
let (data, response) = try await session.data(for: self.request) | ||
self.client?.urlProtocol(self, didReceive: response, cacheStoragePolicy: .allowedInMemoryOnly) | ||
self.client?.urlProtocol(self, didLoad: data) | ||
self.client?.urlProtocolDidFinishLoading(self) | ||
|
||
} catch { | ||
self.client?.urlProtocol(self, didFailWithError: error) | ||
} | ||
} | ||
} | ||
|
||
override func stopLoading() { | ||
self.taskHandle?.cancel() | ||
} | ||
} | ||
|
||
private extension EditorViewController { | ||
|
||
// Inject the interceptor | ||
func registerRequestInterceptor() { | ||
let browsingContextClass: AnyClass = NSClassFromString("WKBrowsingContextController")! | ||
let registerSchemeSelector: Selector = NSSelectorFromString("registerSchemeForCustomProtocol:") | ||
// let unregisterSchemeSelector: Selector = NSSelectorFromString("unregisterSchemeForCustomProtocol:") | ||
|
||
if browsingContextClass.responds(to: registerSchemeSelector) == true { | ||
browsingContextClass.performSelector(inBackground: registerSchemeSelector, with: "http") | ||
browsingContextClass.performSelector(inBackground: registerSchemeSelector, with: "https") | ||
} | ||
|
||
URLProtocol.registerClass(InterceptionProtocol.self) | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The development server can also be an IP when testing with a physical device. Maybe we can check against the
GUTENBERG_EDITOR_URL
environment variable as well?