Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS Request Interception #33

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 61 additions & 1 deletion Sources/GutenbergKit/Sources/EditorViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,8 @@ public final class EditorViewController: UIViewController, GutenbergEditorContro
}

private func setUpEditor() {
registerRequestInterceptor()

let webViewConfiguration = webView.configuration
let userContentController = webViewConfiguration.userContentController
let editorInitialConfig = getEditorConfiguration()
Expand Down Expand Up @@ -368,6 +370,64 @@ private final class GutenbergEditorController: NSObject, WKNavigationDelegate, W
}
}

private extension WKWebView {
class InterceptionProtocol: URLProtocol {
override class func canInit(with request: URLRequest) -> Bool {

// We don't want to interfere with loading the editor JS
guard request.url?.host != "localhost" else {
Comment on lines +376 to +377
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The development server can also be an IP when testing with a physical device. Maybe we can check against the GUTENBERG_EDITOR_URL environment variable as well?

debugPrint("Not intercepting \(request)")
return false
}

// We care about WordPress.com resources – let's modify those if needed
if request.url?.host?.contains("wordpress.com") == true {
Comment on lines +382 to +383
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually, we should hoist this conditional into the host app, as we want to avoid such references in Gutenberg.

return request.value(forHTTPHeaderField: "Authorization") == nil // If there's no auth header, we need to intercept
}

return false
}

override class func canonicalRequest(for request: URLRequest) -> URLRequest {
var mutableRequest = request
mutableRequest.allHTTPHeaderFields?["Authorization"] = "Bearer [REDACTED]"
return mutableRequest
}

private var taskHandle: Task<Void, Error>?
private let session: URLSession = URLSession(configuration: .ephemeral)

override func startLoading() {
self.taskHandle = Task {
do {
let (data, response) = try await session.data(for: self.request)
self.client?.urlProtocol(self, didReceive: response, cacheStoragePolicy: .allowedInMemoryOnly)
self.client?.urlProtocol(self, didLoad: data)
self.client?.urlProtocolDidFinishLoading(self)

} catch {
self.client?.urlProtocol(self, didFailWithError: error)
}
}
}

override func stopLoading() {
self.taskHandle?.cancel()
}
}

private extension EditorViewController {

// Inject the interceptor
func registerRequestInterceptor() {
let browsingContextClass: AnyClass = NSClassFromString("WKBrowsingContextController")!
let registerSchemeSelector: Selector = NSSelectorFromString("registerSchemeForCustomProtocol:")
// let unregisterSchemeSelector: Selector = NSSelectorFromString("unregisterSchemeForCustomProtocol:")

if browsingContextClass.responds(to: registerSchemeSelector) == true {
browsingContextClass.performSelector(inBackground: registerSchemeSelector, with: "http")
browsingContextClass.performSelector(inBackground: registerSchemeSelector, with: "https")
}

URLProtocol.registerClass(InterceptionProtocol.self)
}
}