-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Show "Create Post" FAB in Reader #20910
Conversation
This is where logic should be added if we need to also limit specific scenarios for showing the button in a specific page (such as a feature flag).
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20910 +/- ##
==========================================
+ Coverage 41.00% 41.04% +0.03%
==========================================
Files 1512 1514 +2
Lines 69401 69442 +41
Branches 11446 11457 +11
==========================================
+ Hits 28459 28502 +43
+ Misses 38361 38357 -4
- Partials 2581 2583 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @thomashorta. It's working as expected and code LGTM. I've left a couple of optional suggestions, so I'm approving it.
Fixes #20908
reader_floating_button
remote feature flagreader_floating_button
feature flagMainCreateSheetHelper
for better organizationTo Test:
Showing FAB on Reader page
Debug Settings
reader_floating_buitton
remote flagDebug Settings
reader_floating_button
remote flagAnalytics
Debug Settings
reader_floating_button
remote flagreader_create_fab_shown
reader_create_sheet_shown
reader_create_sheet_prompt_help_tapped
Answer prompt
(if a prompt is available for the tested site)reader_create_sheet_answer_prompt_tapped
Blog post
reader_create_sheet_action_tapped, Properties: {"action":"create_new_post"}
Sanity
Please also test the FAB works normally on "My Site" page as expected, and the FAB is not shown in other pages, nor on the Reader when the
reader_floating_button
is disabled.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
MainCreateSheetHelper
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):