-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reader] Show "Create Post" FAB in Reader #20925
[Reader] Show "Create Post" FAB in Reader #20925
Conversation
This is where logic should be added if we need to also limit specific scenarios for showing the button in a specific page (such as a feature flag).
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Code already reviewed on #20910 |
This layout is usually inflated in Reader feeds inside the Main Activity of the app, which already contains a View with the same ID that's used for snackbar and properly positioning the FAB, which is now visible in Reader. This was causing a bug where the snackbar was shown behind the bottom bar instead of pushing the FAB up and being shown between the bottom bar and FAB.
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/25.0 #20925 +/- ##
================================================
+ Coverage 41.02% 41.06% +0.03%
================================================
Files 1512 1515 +3
Lines 69383 69426 +43
Branches 11440 11451 +11
================================================
+ Hits 28462 28507 +45
+ Misses 38342 38338 -4
- Partials 2579 2581 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving it since Renan already reviewed this code (which was originally made by me on a different PR) but since he opened this PR he can't approve it again.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Fixes #20908
reader_floating_button
remote feature flagreader_floating_button
feature flagMainCreateSheetHelper
for better organizationTo Test:
Showing FAB on Reader page
Debug Settings
reader_floating_buitton
remote flagDebug Settings
reader_floating_button
remote flagAnalytics
Debug Settings
reader_floating_button
remote flagreader_create_fab_shown
reader_create_sheet_shown
reader_create_sheet_prompt_help_tapped
Answer prompt
(if a prompt is available for the tested site)reader_create_sheet_answer_prompt_tapped
Blog post
reader_create_sheet_action_tapped, Properties: {"action":"create_new_post"}
Sanity
Please also test the FAB works normally on "My Site" page as expected, and the FAB is not shown in other pages, nor on the Reader when the
reader_floating_button
is disabled.Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
MainCreateSheetHelper
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):