-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Automattic/dangermattic action to v1.1.1 #20917
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
@@ -7,7 +7,7 @@ on: | |||
jobs: | |||
dangermattic: | |||
if: ${{ (github.event.pull_request.draft == false) }} | |||
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.0 | |||
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iangmaia WDYT about using v1 here?
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.1 | |
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1 |
This should always use the latest v1 version, and would save us from bumping the action with PRs like this. I guess it's safe as semantic versioning will prevent from bumping a breaking change version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, nice that Renovate catches even reusable workflows 👍
Hmm yeah if that works (indeed I think it should but I haven't tried it for reusable workflows) it should be safe by now (I wanted to be more strict in the beginning / developing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wzieba unfortunately, it failed: https://github.com/wordpress-mobile/WordPress-Android/actions/runs/9322366874
This would work only if we maintain a v1
tag that we always keep updated by moving it to the latest v1.x.x
🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right - I'll revert and merge this PR and we can discuss v1
tag separately
It will match the newest v1.x.x release
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
This reverts commit 13f5363.
Quality Gate passedIssues Measures |
This PR contains the following updates:
v1.0.0
->v1.1.1
v1.1.0
->v1.1.1
Release Notes
Automattic/dangermattic (Automattic/dangermattic)
v1.1.1
Compare Source
v1.1.0
Compare Source
v1.0.2
Compare Source
v1.0.1
Compare Source
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.