Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Automattic/dangermattic action to v1.1.1 #20917

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 31, 2024

Mend Renovate

This PR contains the following updates:

Package Type Update Change
Automattic/dangermattic action minor v1.0.0 -> v1.1.1
Automattic/dangermattic action patch v1.1.0 -> v1.1.1

Release Notes

Automattic/dangermattic (Automattic/dangermattic)

v1.1.1

Compare Source

v1.1.0

Compare Source

v1.0.2

Compare Source

v1.0.1

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@dangermattic
Copy link
Collaborator

dangermattic commented May 31, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 31, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20917-5c8dc48
Commit5c8dc48
Direct Downloadwordpress-prototype-build-pr20917-5c8dc48.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 31, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20917-5c8dc48
Commit5c8dc48
Direct Downloadjetpack-prototype-build-pr20917-5c8dc48.apk
Note: Google Login is not supported on these builds.

@wzieba wzieba added the bot: dependencies update PRs that update a dependency file, used by Dependabot. label May 31, 2024
@@ -7,7 +7,7 @@ on:
jobs:
dangermattic:
if: ${{ (github.event.pull_request.draft == false) }}
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.0
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iangmaia WDYT about using v1 here?

Suggested change
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.1
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1

This should always use the latest v1 version, and would save us from bumping the action with PRs like this. I guess it's safe as semantic versioning will prevent from bumping a breaking change version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, nice that Renovate catches even reusable workflows 👍

Hmm yeah if that works (indeed I think it should but I haven't tried it for reusable workflows) it should be safe by now (I wanted to be more strict in the beginning / developing).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wzieba unfortunately, it failed: https://github.com/wordpress-mobile/WordPress-Android/actions/runs/9322366874

This would work only if we maintain a v1 tag that we always keep updated by moving it to the latest v1.x.x 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right - I'll revert and merge this PR and we can discuss v1 tag separately

It will match the newest v1.x.x release
Copy link
Contributor Author

renovate bot commented May 31, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@wzieba wzieba enabled auto-merge June 3, 2024 07:54
Copy link

sonarcloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wzieba wzieba merged commit a3a9fe1 into trunk Jun 3, 2024
20 checks passed
@wzieba wzieba deleted the renovate/automattic-dangermattic-1.x branch June 3, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: dependencies update PRs that update a dependency file, used by Dependabot. Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants