Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Automattic/dangermattic action to v1.1.1 #20917

Merged
merged 3 commits into from
Jun 3, 2024
Merged

Update Automattic/dangermattic action to v1.1.1 #20917

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3718c0
Update Automattic/dangermattic action to v1.1.1
renovate[bot] May 31, 2024
13f5363
Use v1 for dangermattic GitHub Actions
wzieba May 31, 2024
5c8dc48
Revert "Use v1 for dangermattic GitHub Actions"
wzieba Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-danger.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
jobs:
dangermattic:
if: ${{ (github.event.pull_request.draft == false) }}
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.0
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iangmaia WDYT about using v1 here?

Suggested change
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1.1.1
uses: Automattic/dangermattic/.github/workflows/reusable-retry-buildkite-step-on-events.yml@v1

This should always use the latest v1 version, and would save us from bumping the action with PRs like this. I guess it's safe as semantic versioning will prevent from bumping a breaking change version.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, nice that Renovate catches even reusable workflows 👍

Hmm yeah if that works (indeed I think it should but I haven't tried it for reusable workflows) it should be safe by now (I wanted to be more strict in the beginning / developing).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wzieba unfortunately, it failed: https://github.com/wordpress-mobile/WordPress-Android/actions/runs/9322366874

This would work only if we maintain a v1 tag that we always keep updated by moving it to the latest v1.x.x 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right - I'll revert and merge this PR and we can discuss v1 tag separately

with:
org-slug: "automattic"
pipeline-slug: "wordpress-android"
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-issues.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
check-labels-on-issues:
uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@v1.0.0
uses: Automattic/dangermattic/.github/workflows/reusable-check-labels-on-issues.yml@v1.1.1
with:
label-format-list: '[
"^\[.+\]",
Expand Down
Loading