[Issue/20295] Location metadata in uploaded pictures #20955

pantstamp · 2024-06-07T15:56:12Z

Fixes #20295

This is the companion PR for wordpress-mobile/WordPress-FluxC-Android#3030

Merge Instructions

Make sure the FLuxC PR has been merged to trunk
Grab the FluxC trunk has from CI and update build.gradle
Merge as normal

This PR aims to resolve the issues described above. After investigating, I found that there were two issues:

When the "Optimize Images" option was enabled, we didn't copy the ExifInterface data (which includes location metadata) to the new optimized file.
When the "Optimize Images" option was disabled, we could not access the location data in the latest Android API versions because we were not requesting the ACCESS_MEDIA_LOCATION permission.

This PR requests the necessary permissions and uses the new ExifUtils functions to copy the ExifInterface data to the optimized media files.

To Test:

First check the existing problem:

Install on your device the latest version of Jetpack app from PlayStore.
Log in.
Tap on Me -> App Settings -> Verify that "Optimize Images" is enabled and "Remove location from media" is disabled.
Go to My Site -> Media -> Tap on the "+" icon at the top right corner -> Choose from device
Give all the permissions asked.
Choose an image from your device and upload
Find the uploaded image in the media library and open it
Tap the "share" icon at the top right corner
Choose your email client like Gmail and send it to your email address
Open the mail from your browser, tap on the link of the image.
Right click on the image and save it on your computer.
Open the image using "Preview" on your Mac, and click on Tools -> Show Inspector.
Tap on the "More Info" icon

Verify that there are no Exif or GPS data.

Tap on Me -> App Settings -> Disable "Optimize Images".
Repeat steps 4-13

Verify that there are Exif data and GPS are zero.

Test Solution
16. Install the app from this PR.
17. Repeat steps 4-13

Verify that Exif and GPS data exist

Repeat steps 14-15

Verify that Exif and GPS data exist

Try to upload an image from the editor while creating a post using an image block.

Verify that Exif and GPS data exist

ATTENTION: If users chooses to "Take a photo" from our app and not choose a photo from the device, no location data are saved in the uploaded image. This functionality in not in the scope of this PR.

Regression Notes

Potential unintended areas of impact
- N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
- Manual testing

dangermattic · 2024-06-07T15:58:39Z

	2 Warnings
⚠️	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
⚠️	This PR is assigned to the milestone 25.1. The due date for this milestone has already passed. Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

wpmobilebot · 2024-06-07T16:15:31Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20955-f0902d8
	Commit	`f0902d8`
	Direct Download	`wordpress-prototype-build-pr20955-f0902d8.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2024-06-07T16:15:49Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20955-f0902d8
	Commit	`f0902d8`
	Direct Download	`jetpack-prototype-build-pr20955-f0902d8.apk`

Note: Google Login is not supported on these builds.

antonis

Awesome work @pantstamp 🏅
I've tested the implementation on a Pixel 8 / Android 14 and the exif data were saved as expected. The code also looks good 🎉

Before	After

I also checked the failed Sonar report and I don't see any blocking issue. The code duplication refers to a small 3 line if statement (which I don't see value on extracting) and the security issue refers to the addition of the ACCESS_MEDIA_LOCATION permission which is expected.

…ictures # Conflicts: # build.gradle

sonarqubecloud · 2024-06-10T15:31:44Z

Quality Gate failed

Failed conditions
1 Security Hotspot
25.0% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

wpmobilebot · 2024-06-10T15:33:18Z

Found 1 violations:

The PR caused some dependency changes (expand to see details)

-+--- org.wordpress:fluxc:{strictly 2.83.0} -> 2.83.0
-|    +--- org.wordpress:wellsql:2.0.0
-|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
-|    +--- org.wordpress.fluxc:fluxc-annotations:2.83.0
-|    +--- org.greenrobot:eventbus:3.3.1
-|    |    \--- org.greenrobot:eventbus-java:3.3.1
-|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
-|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
-|    +--- androidx.paging:paging-runtime:2.1.2
-|    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
-|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
-|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
-|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    +--- com.goterl:lazysodium-android:5.0.2
-|    +--- net.java.dev.jna:jna:5.5.0
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.22 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
-|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
-|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6 (*)
-|    +--- androidx.security:security-crypto:1.0.0
-|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
-|    |    \--- com.google.crypto.tink:tink-android:1.5.0
-|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
-|    +--- org.apache.commons:commons-text:1.10.0
-|    |    \--- org.apache.commons:commons-lang3:3.12.0
-|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0
-|    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
-|    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.2.0 (*)
-|    |    +--- androidx.room:room-common:2.5.0
-|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 -> 1.9.10 (*)
-|    |    +--- androidx.sqlite:sqlite:2.3.0
-|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    |    \--- androidx.sqlite:sqlite-framework:2.3.0
-|    |         +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
-|    |         +--- androidx.sqlite:sqlite:2.3.0 (*)
-|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    +--- androidx.room:room-ktx:2.4.2 -> 2.5.0
-|    |    +--- androidx.room:room-common:2.5.0 (*)
-|    |    +--- androidx.room:room-runtime:2.5.0 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3 (*)
-|    +--- com.google.dagger:dagger:2.42 -> 2.50
-|    |    \--- javax.inject:javax.inject:1
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
-|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
++--- org.wordpress:fluxc:{strictly trunk-f111f9d00446395f16550bca872c6098c23529e9} -> trunk-f111f9d00446395f16550bca872c6098c23529e9
+|    +--- org.wordpress:wellsql:2.0.0
+|    |    +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:2.0.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-f111f9d00446395f16550bca872c6098c23529e9
+|    +--- org.greenrobot:eventbus:3.3.1
+|    |    \--- org.greenrobot:eventbus-java:3.3.1
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.12.0 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.1
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.2.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.6.2 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.6.2 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.20 -> 1.9.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.20 -> 1.9.22 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.6.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.3.0 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.6 (*)
+|    +--- androidx.security:security-crypto:1.0.0
+|    |    +--- androidx.annotation:annotation:1.1.0 -> 1.6.0 (*)
+|    |    \--- com.google.crypto.tink:tink-android:1.5.0
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.10.1
+|    +--- org.apache.commons:commons-text:1.10.0
+|    |    \--- org.apache.commons:commons-lang3:3.12.0
+|    +--- androidx.room:room-runtime:2.4.2 -> 2.5.0
+|    |    +--- androidx.annotation:annotation-experimental:1.1.0 -> 1.3.1 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.2.0 (*)
+|    |    +--- androidx.room:room-common:2.5.0
+|    |    |    +--- androidx.annotation:annotation:1.3.0 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.7.20 -> 1.9.10 (*)
+|    |    +--- androidx.sqlite:sqlite:2.3.0
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.6.0 (*)
+|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+|    |    \--- androidx.sqlite:sqlite-framework:2.3.0
+|    |         +--- androidx.annotation:annotation:1.2.0 -> 1.6.0 (*)
+|    |         +--- androidx.sqlite:sqlite:2.3.0 (*)
+|    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+|    +--- androidx.room:room-ktx:2.4.2 -> 2.5.0
+|    |    +--- androidx.room:room-common:2.5.0 (*)
+|    |    +--- androidx.room:room-runtime:2.5.0 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.7.20 -> 1.9.22 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.6.4 -> 1.7.3 (*)
+|    +--- com.google.dagger:dagger:2.42 -> 2.50
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.7.3 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.7.3 (*)
 \--- org.wordpress:login:1.15.0
-     \--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> 2.83.0 (*)
+     \--- org.wordpress:fluxc:trunk-ed60798b4d96ec19863c74b0f525e2e20f4525db -> trunk-f111f9d00446395f16550bca872c6098c23529e9 (*)

Please review and act accordingly

sentry-io · 2024-06-10T19:46:21Z

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

‼️ ApplicationNotResponding: Application Not Responding for at least 5000 ms. org.wordpress.android.ui.prefs.AppPrefs in prefs View Issue

_{Did you find this useful? React with a 👍 or 👎}

pantstamp added 3 commits June 6, 2024 13:37

Adds: ACCESS_MEDIA_LOCATION request

b590298

Fixes: Adds Exif data to optimized media

b311efa

Update FluxC version

9990b25

pantstamp added the [Type] Bug label Jun 7, 2024

pantstamp requested review from antonis, zwarm and AjeshRPai June 7, 2024 15:56

antonis approved these changes Jun 10, 2024

View reviewed changes

antonis mentioned this pull request Jun 10, 2024

Issue/20295 Location metadata in uploaded pictures wordpress-mobile/WordPress-FluxC-Android#3030

Merged

AjeshRPai added this to the 25.1 milestone Jun 10, 2024

Antonis Lilis added 2 commits June 10, 2024 18:26

Merge branch 'trunk' into issue/20295-location-metadata-in-uploaded-p…

6ac9f0f

…ictures # Conflicts: # build.gradle

Updated FluxC version to point to trunk

f0902d8

antonis enabled auto-merge June 10, 2024 15:34

antonis merged commit 2b56186 into trunk Jun 10, 2024
18 of 20 checks passed

antonis deleted the issue/20295-location-metadata-in-uploaded-pictures branch June 10, 2024 16:00

zwarm mentioned this pull request Jun 17, 2024

[Voice to Content\ Implement elapsed time indicator #20984

Merged

3 tasks

geriux mentioned this pull request Jul 1, 2024

WPMediaUtils - Set normal orientation for the exif data #21024

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Issue/20295] Location metadata in uploaded pictures #20955

[Issue/20295] Location metadata in uploaded pictures #20955

pantstamp commented Jun 7, 2024 •

edited by antonis

Loading

dangermattic commented Jun 7, 2024 •

edited

Loading

wpmobilebot commented Jun 7, 2024 •

edited

Loading

wpmobilebot commented Jun 7, 2024 •

edited

Loading

antonis left a comment

sonarqubecloud bot commented Jun 10, 2024

wpmobilebot commented Jun 10, 2024

sentry-io bot commented Jun 10, 2024

[Issue/20295] Location metadata in uploaded pictures #20955

[Issue/20295] Location metadata in uploaded pictures #20955

Conversation

pantstamp commented Jun 7, 2024 • edited by antonis Loading

To Test:

Regression Notes

dangermattic commented Jun 7, 2024 • edited Loading

wpmobilebot commented Jun 7, 2024 • edited Loading

wpmobilebot commented Jun 7, 2024 • edited Loading

antonis left a comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Jun 10, 2024

Quality Gate failed

wpmobilebot commented Jun 10, 2024

sentry-io bot commented Jun 10, 2024

Suspect Issues

pantstamp commented Jun 7, 2024 •

edited by antonis

Loading

dangermattic commented Jun 7, 2024 •

edited

Loading

wpmobilebot commented Jun 7, 2024 •

edited

Loading

wpmobilebot commented Jun 7, 2024 •

edited

Loading