Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Voice to Content\ Implement elapsed time indicator #20984

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

zwarm
Copy link
Contributor

@zwarm zwarm commented Jun 14, 2024

Closes https://github.com/Automattic/wordpress-mobile/issues/82

UPDATE: The elapsed timer logic has been updated and simplified in #20955

This PR implements the time elapsed visual indicator in the recorder view.

Alt desc

Important

Merge Instructions

Note

The following have not yet been implemented:

  • Orientation changes
  • Overall polishing of the UI
  • Launching Edit Post
  • Remove debug log lines and comments
  • Unit tests

To Test:

  • Install and launch the app
  • Login with an account that has access to AI credits (Any a8c P2 will have this - other free sites have 20 requests)
  • Navigate to Me > Debug Settings and enable the voice_to_content flag (restart the app)
  • Navigate to My Site and tap the FAB
  • Select the Post with Audio option
  • Start the recording session by tapping on the mic icon
  • ✅ Verify the elapsed time is showing under the Recording header

Regression Notes

  1. Potential unintended areas of impact
    The elapsed time is not showing

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manual testing

  3. What automated tests I added (or what prevented me from doing so)
    N/A


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones): N/A

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20984-b65e2a1
Commitb65e2a1
Direct Downloadwordpress-prototype-build-pr20984-b65e2a1.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20984-b65e2a1
Commitb65e2a1
Direct Downloadjetpack-prototype-build-pr20984-b65e2a1.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 30 lines in your changes missing coverage. Please review.

Project coverage is 40.74%. Comparing base (9aa4aec) to head (b65e2a1).

Files Patch % Lines
.../android/ui/voicetocontent/VoiceToContentScreen.kt 0.00% 22 Missing ⚠️
...droid/ui/voicetocontent/VoiceToContentViewModel.kt 20.00% 4 Missing ⚠️
.../org/wordpress/android/util/audio/AudioRecorder.kt 0.00% 4 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           issue/v2c-clear-resources   #20984      +/-   ##
=============================================================
- Coverage                      40.75%   40.74%   -0.01%     
=============================================================
  Files                           1528     1528              
  Lines                          70174    70194      +20     
  Branches                       11607    11612       +5     
=============================================================
+ Hits                           28596    28603       +7     
- Misses                         38988    39001      +13     
  Partials                        2590     2590              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwarm zwarm requested a review from notandyvee June 14, 2024 19:22
@zwarm zwarm changed the base branch from trunk to issue/v2c-clear-resources June 14, 2024 19:34
Base automatically changed from issue/v2c-clear-resources to trunk June 17, 2024 15:39
Copy link
Contributor

@notandyvee notandyvee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I'm only looking at the UI and you have other PRs that build on it, things as they are look good to me 🍕

@notandyvee notandyvee merged commit ff17d3b into trunk Jun 17, 2024
20 checks passed
@notandyvee notandyvee deleted the issue/v2c-show-elapsed-time branch June 17, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants