-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Voice to Content\ Implement elapsed time indicator #20984
Conversation
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## issue/v2c-clear-resources #20984 +/- ##
=============================================================
- Coverage 40.75% 40.74% -0.01%
=============================================================
Files 1528 1528
Lines 70174 70194 +20
Branches 11607 11612 +5
=============================================================
+ Hits 28596 28603 +7
- Misses 38988 39001 +13
Partials 2590 2590 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I'm only looking at the UI and you have other PRs that build on it, things as they are look good to me 🍕
Closes https://github.com/Automattic/wordpress-mobile/issues/82
UPDATE: The elapsed timer logic has been updated and simplified in #20955
This PR implements the time elapsed visual indicator in the recorder view.
Important
Merge Instructions
Note
The following have not yet been implemented:
To Test:
Regression Notes
Potential unintended areas of impact
The elapsed time is not showing
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones): N/A