Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Revert] This reverts adding foregroundServiceType to many services. #20978

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

notandyvee
Copy link
Contributor

@notandyvee notandyvee commented Jun 12, 2024

After some testing I learned that the foregroundServiceType was unnecessary in many of the services I previously thought required them. This was an oversight. This PR reverts that PR which shouldn't affect any functionality.

To Test:

  • ReaderUpdateJobService
    Get’s triggered when you change tabs

  • ReaderDiscoverJobService
    When the reader discover tab loads

  • ReaderPostJobService
    Service which updates posts with specific tags. Will not happen on discover, but on tabs like subscriptions.

  • ReaderSearchJobService
    Happens when searching for blogs/posts in the reader.

  • ReaderCommentService
    Loads comment on a post when clicking comments in the reader.

  • SuggestionService
    Loads suggestions for autocompletion purposes in the comments section in the reader

  • NotificationsProcessingService
    Dismiss or like directly from a notification

  • NotificationsUpdateJobService
    Loading recent notifications

  • InstallationReferrerJobService
    Service that runs 1 time on clean install in order to track if the app was referred.

  • LoginWpcomService
    Login through Wordpress.com.

  • SiteCreationService
    Create a site

  • WidgetService
    Service used to update the jetpack widget.

  • GCMMessageService
    Real-time notifications


Regression Notes

  1. Potential unintended areas of impact

    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    Manual testing

  3. What automated tests I added (or what prevented me from doing so)

    N/A


PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20978-69efddc
Commit69efddc
Direct Downloadwordpress-prototype-build-pr20978-69efddc.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20978-69efddc
Commit69efddc
Direct Downloadjetpack-prototype-build-pr20978-69efddc.apk
Note: Google Login is not supported on these builds.

Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano irfano merged commit dc5473e into trunk Jun 13, 2024
21 checks passed
@irfano irfano deleted the andy/revert-foreground-service-types branch June 13, 2024 20:10
@irfano irfano added this to the 25.2 milestone Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants