[Revert] This reverts adding foregroundServiceType to many services. #20978
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some testing I learned that the
foregroundServiceType
was unnecessary in many of the services I previously thought required them. This was an oversight. This PR reverts that PR which shouldn't affect any functionality.To Test:
ReaderUpdateJobService
Get’s triggered when you change tabs
ReaderDiscoverJobService
When the reader discover tab loads
ReaderPostJobService
Service which updates posts with specific tags. Will not happen on discover, but on tabs like subscriptions.
ReaderSearchJobService
Happens when searching for blogs/posts in the reader.
ReaderCommentService
Loads comment on a post when clicking comments in the reader.
SuggestionService
Loads suggestions for autocompletion purposes in the comments section in the reader
NotificationsProcessingService
Dismiss or like directly from a notification
NotificationsUpdateJobService
Loading recent notifications
InstallationReferrerJobService
Service that runs 1 time on clean install in order to track if the app was referred.
LoginWpcomService
Login through Wordpress.com.
SiteCreationService
Create a site
WidgetService
Service used to update the jetpack widget.
GCMMessageService
Real-time notifications
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
Manual testing
What automated tests I added (or what prevented me from doing so)
N/A
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.