Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2671 - avoid auto connect when last used wallet was WalletConnect #2686

Merged

Conversation

sebastianscatularo
Copy link
Collaborator

  • if the previous connected wallet was WalletConnect, avoid auto connecting it

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for wormhole-connect-mainnet ready!

Name Link
🔨 Latest commit 7e480f5
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect-mainnet/deploys/66edbfa9cf9856000840c4ca
😎 Deploy Preview https://deploy-preview-2686--wormhole-connect-mainnet.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 20, 2024

Deploy Preview for wormhole-connect ready!

Name Link
🔨 Latest commit 7e480f5
🔍 Latest deploy log https://app.netlify.com/sites/wormhole-connect/deploys/66edbfa90e92d70009704203
😎 Deploy Preview https://deploy-preview-2686--wormhole-connect.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kev1n-peters
Copy link
Collaborator

Prior to this change, I was able to auto-reconnect WalletConnect w/o the QR code popup appearing. Is it worth investigating why the QR code would appear for some users, but not others when auto-reconnecting WC?

@sebastianscatularo
Copy link
Collaborator Author

@kev1n-peters, this was in V1:

Using a mobile wallet as an example, if you disconnect your mobile app or if the session has expired, once you open a Connect instance again, WalletConnect will try to reuse the session. However, since it’s no longer valid, the WalletConnect popup will appear, and without a clear context, it may seem confusing.

I’ll check if there’s an easy way to detect whether WalletConnect still has a valid active session. But even if that’s the case, I’m not sure if it would be secure to auto-connect, as you could be accessing someone else’s wallet session

@sebastianscatularo sebastianscatularo merged commit 28ef5e8 into development Sep 20, 2024
16 checks passed
@sebastianscatularo sebastianscatularo deleted the bugs/avoid-auto-connect-for-wallet-connect branch September 20, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants