tokenBridge: fromIdentifier amount scaling fix #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were not scaling the transfer amount on the VAA to the source chain amount correctly. Fixes wormhole-foundation#580
kev1n-peters
commented
Sep 21, 2024
artursapek
previously approved these changes
Sep 23, 2024
artursapek
approved these changes
Sep 23, 2024
kev1n-peters
added a commit
to wormholelabs-xyz/wormhole-connect
that referenced
this pull request
Sep 23, 2024
Upgrade SDK to include this fix: wormhole-foundation/wormhole-sdk-ts#700
kev1n-peters
added a commit
to wormhole-foundation/wormhole-connect
that referenced
this pull request
Sep 24, 2024
Upgrade SDK to include this fix: wormhole-foundation/wormhole-sdk-ts#700
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not scaling the transfer amount on the VAA to the source chain amount correctly.
Fixes #580