Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: displayName added to all components #305

Open
techoneel opened this issue Aug 20, 2024 · 1 comment · Fixed by #307
Open

enhancement: displayName added to all components #305

techoneel opened this issue Aug 20, 2024 · 1 comment · Fixed by #307
Assignees
@techoneel
Labels
enhancement New feature or request

Comments

@techoneel
Copy link
Member

Description

Need to add a name property to all available core components.
@techoneel techoneel added the enhancement New feature or request label Aug 20, 2024
@techoneel techoneel self-assigned this Aug 20, 2024
techoneel added a commit that referenced this issue Aug 20, 2024
@techoneel
feat(core): 🎨 core component name added
c028a0f 
core component CoreAvatar name added

Ref #305
@techoneel techoneel mentioned this issue Aug 20, 2024
Merged
8 tasks
@anantakumarghosh
Copy link
Member

anantakumarghosh commented Aug 21, 2024 •
edited
Loading

name is read only
displayName should be used instead.

@techoneel techoneel changed the title enhancement: name added to all components enhancement: displayName added to all components Aug 21, 2024
techoneel added a commit that referenced this issue Aug 21, 2024
@techoneel
fix(core): 🐛 name will be converted to displayName
66e69d5 
name will be converted to displayName for react purposes

Ref #305
@techoneel techoneel mentioned this issue Aug 21, 2024
Merged
8 tasks
@techoneel techoneel linked a pull request Aug 21, 2024 that will close this issue
bugfix: name to displayName #307
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@techoneel techoneel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix: name to displayName wrappid/core
2 participants
@techoneel @anantakumarghosh