Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: name to displayName #307

Merged
merged 2 commits into from
Aug 21, 2024
Merged

bugfix: name to displayName #307

merged 2 commits into from
Aug 21, 2024

Conversation

techoneel
Copy link
Member

@techoneel techoneel commented Aug 21, 2024 •
edited
Loading

Description

name can't be accessible in react of any component so we need to make changes for displayName

Related Issues

#305

Testing

Checklist

  • I have performed a thorough self-review of my code.
  • I have added or updated relevant tests for my changes.
  • My code follows the project's style guidelines and best practices.
  • I have updated the documentation if necessary.
  • I have added or updated relevant comments in my code.
  • I have resolved any merge conflicts of my branch.

Screenshots (if applicable)

Additional Notes

Reviewers

Maintainer Notes

  • Has this change been tested in a staging environment?
  • Does this change introduce any breaking changes or deprecations?

@techoneel
fix(core): 🐛 name will be converted to displayName
66e69d5 
name will be converted to displayName for react purposes

Ref #305
@techoneel techoneel linked an issue Aug 21, 2024 that may be closed by this pull request
enhancement: displayName added to all components #305
Open
@techoneel techoneel self-assigned this Aug 21, 2024
@techoneel techoneel added the enhancement New feature or request label Aug 21, 2024
@techoneel techoneel enabled auto-merge August 21, 2024 06:18
@techoneel techoneel disabled auto-merge August 21, 2024 06:19
@techoneel techoneel changed the base branch from main to development August 21, 2024 06:19
@techoneel techoneel merged commit 1ad2cf2 into development Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@techoneel techoneel

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enhancement: displayName added to all components
1 participant
@techoneel