Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back the removed sms otp regex configuration #790

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

shanggeeth
Copy link
Contributor

Proposed changes in this pull request

With the following PRs, SMS OTP regex configuration has been replaced and OTP pattern configurations

  1. Add feature to send OTPs in e-mail verifications.  #776
  2. Add feature to send OTPs in e-mail verifications. wso2/carbon-identity-framework#5028

This was not backward compatible.

With changes from this PR, we do the following changes

  1. The removed SMS OTP regex config is added back
  2. Default values for new OTP pattern config is set as empty so that old sms otp regex pattern config will be prioritized.

The new otp pattern will be resolved in terms old sms otp regex pattern configuration with

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7114145374

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7114145374
Status: failure

@shanggeeth
Copy link
Contributor Author

shanggeeth commented Dec 7, 2023

The test failure is expected

[INFO] Results:
 [INFO] 
 [ERROR] Failures: 
 [ERROR] org.wso2.identity.integration.test.rest.api.server.identity.governance.v1.IdentityGovernanceSuccessTest.testSearchGovernanceConnectorProperties(org.wso2.identity.integration.test.rest.api.server.identity.governance.v1.IdentityGovernanceSuccessTest)
 [INFO] Run 1: PASS
 [ERROR] Run 2: IdentityGovernanceSuccessTest.testSearchGovernanceConnectorProperties:329 1 expectation failed.
 JSON path find{ it.('connector-name') == 'self-sign-up' }.properties[3].value doesn't match.
 Expected: true
 Actual: 
 
 [INFO] Run 3: PASS
 [ERROR] Run 4: IdentityGovernanceSuccessTest.testSearchGovernanceConnectorProperties:329 1 expectation failed.
 JSON path find{ it.('connector-name') == 'self-sign-up' }.properties[3].value doesn't match.
 Expected: true
 Actual: 

Fix PR: wso2/product-is#18469

@shanggeeth shanggeeth merged commit 546a235 into wso2-extensions:master Dec 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants