Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test failures due to adding back sms OTP regex configuration #18469

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

shanggeeth
Copy link
Contributor

Proposed changes in this pull request

With the following PRs, SMS OTP regex configuration has been added back to keep backward compatibility.

  1. Add back the removed sms otp regex configuration wso2-extensions/identity-governance#790
  2. Resolve new OTP pattern configuration with old SMS OTP regex pattern configuration carbon-identity-framework#5278

This PR adds back the removed sms OTP regex related test configurations removed with

nilasini
nilasini previously approved these changes Dec 7, 2023
@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7124635200

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7124635200
Status: cancelled

@jenkins-is-staging
Copy link
Contributor

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/7124673491

@jenkins-is-staging
Copy link
Contributor

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/7124673491
Status: success

Copy link
Contributor

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/7124673491

@shanggeeth shanggeeth merged commit d609b51 into wso2:master Dec 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants